Closed Bug 775770 Opened 10 years ago Closed 10 years ago

Add "Copy Phone Number" to long press context menu

Categories

(Firefox for Android Graveyard :: General, enhancement)

ARM
Android
enhancement
Not set
normal

Tracking

(firefox14 wontfix, firefox15 wontfix, firefox16 wontfix)

VERIFIED FIXED
Firefox 17
Tracking Status
firefox14 --- wontfix
firefox15 --- wontfix
firefox16 --- wontfix

People

(Reporter: mcomella, Assigned: mcomella)

References

Details

Attachments

(2 files, 1 obsolete file)

A long press on a "tel:" link should open the context menu with a "Copy Phone Number" option.
Severity: normal → enhancement
Attached patch Patch (obsolete) — Splinter Review
Builds on patch from Bug 775766 which is not yet reviewed. You should probably review that first.

A long press on a "tel:..." link has the following options:
*Open Link in New Tab
*Copy Phone Number (added with this patch)
*Share Link
*Bookmark Link
*Open With an App

New tab, share link, and bookmark link all use the phone number with the "tel:". Opening this link in Firefox causes the Phone app's numberpad to open. For this reason, I think we can remove "Open Link in New Tab" as it exhibits the same behavior as a short press except an extra tab is opened (a tab that you probably don't want).

I think sharing should use the number without the scheme (similar to email's bug 744662, though that's undecided) and bookmarking can be done away with (since it fits better to have an "Add to contacts" option anyway, as per bug 684380).

What are your thoughts?
Attachment #644123 - Flags: review?(mark.finkle)
(In reply to Michael Comella (:mcomella) from comment #1)

> I think sharing should use the number without the scheme (similar to email's
> bug 744662, though that's undecided) and bookmarking can be done away with
> (since it fits better to have an "Add to contacts" option anyway, as per bug
> 684380).
> 
> What are your thoughts?

Sounds righteous
Comment on attachment 644123 [details] [diff] [review]
Patch

Looks good too. Same note about Wes doing his code reorg and rebasing.

Are you going to file a new bug to change the other menu items (New Tab, Share, etc) behavior?
Attachment #644123 - Flags: review?(mark.finkle) → review+
(In reply to Mark Finkle (:mfinkle) from comment #3)
> Are you going to file a new bug to change the other menu items (New Tab,
> Share, etc) behavior?

Bug 776064.
Attached patch Patch v2Splinter Review
Rebased to inbound (including wej's patch). Moved r+.
Attachment #644123 - Attachment is obsolete: true
Attachment #644534 - Flags: review+
To checker-in:
Apply bug 775766 before applying this patch.
Depends on: 775766
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/045c11dd41a6
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
Aurora/Beta nom?
(In reply to Aaron Train [:aaronmt] from comment #9)
> Aurora/Beta nom?

(Same reasoning as bug 775766 – "Copy Email Address")
While this bug is a simple change, it relies on several code changes which may not be as simple or low risk. As this is not an essential fix, I think it would be safer to leave it on central.
Sounds like this is mozilla-15 wontfix then.
Attached image Screenshot
Build ID: 17.0a2 (2012-10-08)Aurora Channel
          18.0 (2012-10-08) Nightly Channel
          19.0 (2012-10-09) Nightly Channel
Device: Samsung Galaxy Nexus
OS: Android 4.1

Tested with http://dump.lassey.us/proto.html - Context menu according to phone numbers.
Marking bug as verify fixed.
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.