776449 - Pages with spaces in the slug are corrupted

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: General, defect, P1)

Description

[Jonathan Protzenko [:protz]]

https://developer-new.mozilla.org/en-US/docs/Extensions/Thunderbird%20Extensions

I tried to edit Extensions/Thunderbird. When trying to save:
- Kuma told me that a page already existed with this slug (I know what a slug is, but for a non-native English speaker, it's an animal that eats lettuce)
- I picked another slug (why? I'm editing a page, I should be able to keep the same slug),
- and saved the page.

Comment 1

[John Karahalis [:openjck]]

Thank you for reporting this, Jonathan!

The "slug" issue is bug 774184, and someone is working on it right now. The second issue you mention (the garbage being displayed) is related to bug 776248.

I am going to mark this bug as a duplicate of bug 774184. Thank you so much for confirming that this is happening to more than one person.

Comment 2

[John Karahalis [:openjck]]

Thanks for keeping me honest on this one, Jonathan. I think I remember coming across another page that had this problem, but I can't remember which at the moment.

Reopening and updating the bug title.

Thanks again.

Comment 3

[John Karahalis [:openjck]]

Looks good in the WYSIWYG, interestingly.

Comment 4

[John Karahalis [:openjck]]

Bug 776018 may be related to this.

Comment 5

[Les Orchard [:lorchard]]

(In reply to Jonathan Protzenko [:protz] from comment #0)
 
> - Kuma told me that a page already existed with this slug (I know what a
> slug is, but for a non-native English speaker, it's an animal that eats
> lettuce)

FWIW, "slug" is also a technical term in publishing - "a slug is a short name given to an article that is in production"

    http://en.wikipedia.org/wiki/Slug_%28production%29

I was an editor on my high school newspaper, so I don't think I ever thought of a "slug" in the animal sense :)

Comment 6

[Les Orchard [:lorchard]]

I think this has do to with articles with slugs that contain spaces. I renamed the thunderbird document, and it worked:

https://developer-new.mozilla.org/en-US/docs/Extensions/Thunderbird_Extensions

That's not necessarily the solution, because renaming will break links to the page. But, it's a clue. Still investigating.

Comment 7

[Les Orchard [:lorchard]]

Two notes:

* New documents with slugs containing spaces should be hard to create - they should get turned into underscores and/or rejected as invalid. Need to check that.

* There are only 3 documents that currently have slugs containing spaces:

mysql> select slug from wiki_document where slug like '% %';
+----------------------------------------+
| slug                                   |
+----------------------------------------+
| Extensions/Thunderbird Extensions      |
| Mozilla_event_reference/reset (event)  |
| Mozilla_event_reference/submit (event) |
+----------------------------------------+
3 rows in set (0.04 sec)

Comment 9

[Jonathan Protzenko [:protz]]

Just for the record, the "Thunderbird Extensions" page should go away. It's supposed to be "Extensions/Thunderbird" but as I hit the "a page with this slug already exists" bug, I was forced into picking something else.

Comment 10

[Jonathan Protzenko [:protz]]

And then I couldn't find how to revert the changes on the original Extensions/Thunderbird page :)

Comment 11

[John Karahalis [:openjck]]

(In reply to Jonathan Protzenko [:protz] from comment #9)
> Just for the record, the "Thunderbird Extensions" page should go away. It's
> supposed to be "Extensions/Thunderbird" but as I hit the "a page with this
> slug already exists" bug, I was forced into picking something else.

That bug has been fixed. I have manually renamed the slug back to Extensions/Thunderbird.

> * New documents with slugs containing spaces should be hard to create - they
> should get turned into underscores and/or rejected as invalid. Need to check
> that.

We want to make it impossible for normal users to edit slugs anyway. See bug 771679. With some convincing, I might even be able to get the docs team to agree that /no one/ needs to edits slugs.

Comment 12

[Les Orchard [:lorchard]]

(In reply to John Karahalis [:openjck] from comment #11)

> We want to make it impossible for normal users to edit slugs anyway. See bug
> 771679. With some convincing, I might even be able to get the docs team to
> agree that /no one/ needs to edits slugs.

Not quite right: Even per bug 771679, users will still be able to *move* pages. That's just a fancier way to edit slugs, which takes into account the ripple effect of editing a slug.

Comment 13

[ali spivak]

should this be marked a duplicate of 805147?

Comment 14

[Les Orchard [:lorchard]]

I don't think this is a dupe of bug 805147 - this isn't related to page move.

This is a bug (I think) in kumascript, where it's unhappy with spaces in page slugs. The pages aren't *corrupted*, in that the content is fine in the database. It's just that when we go to display the rendered page, some things go haywire.

But, we disallow spaces in the slugs of new pages since the launch of Kuma. So, this mainly applies to migrated pages. Might be a non-issue, but should probably get fixed anyway.

Comment 15

[John Karahalis [:openjck]]

Closing out my NEEDINFO as per comment 14.

Comment 16

[John Karahalis [:openjck]]

I don't see this issue any more. Please reopen if I'm mistaken.