776669 - Add pinned tabs to All Tabs drop-down menu

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, enhancement, P5)

Description

[Gordon P. Hemsley [:GPHemsley]]

I know they were purposely removed in bug 714594, but I don't use the All Tabs menu simply for tab overflow. I use it so that I can easily see a list of open tabs, and their (mostly) full titles.

As my brain stores the location of tabs based on other tabs surrounding it, it is always confusing when I don't see the app tabs at the top of the All Tabs list.

I ask that app tabs be readded to the All Tabs list. (I think it would make sense to also include bug 626854.)

Comment 1

[alex_mayorga]

Big +1 for this.

Either fix it or change the tooltip to "List some but not all tabs" =)

Comment 2

[alex_mayorga]

Why not actually fix bug 626854 too while at it?

Comment 4

[Chris Peterson [:cpeterson]]

Hi Dão, I see there are plans for a new Tab Manager design (bug 1494755). Will Proton include that new Tab Manager design? In the meantime, would you accept a trivial fix for this bug to include pinned tabs in the Tab Manager's drop-down list?

If so, are there existing tests for the Tab Manager that should be updated? I see a browser_tab_manager_visibility.js test, but it only tests whether the Tab Manager button is visible, not whether the drop-down list contains the correct information.

Would you accept a patch to fix bug 626854 ("Add a separator after pinned tabs in the drop-down list")? You WONTFIX'd that bug 9 years ago. :)

Would you accept a patch to always enable the Tab Manager (change browser.tabs.tabmanager.enabled pref default to true)? Currently, the Tab Manager button only appears if I open >= 17 tabs on a maximized browser window on my MacBook Pro. I find the Tab Manager helpful even with fewer tabs open because the drop-down list shows the full page titles. (The browser.tabs.tabmanager.enabled pref was added in bug 1480542.)

Comment 5

[Chris Peterson [:cpeterson]]

Attachment: Bug 776669 - Add pinned tabs to the "List all tabs" drop-down list. r?dao

Comment 6

[Chris Peterson [:cpeterson]]

are there existing tests for the Tab Manager that should be updated? I see a browser_tab_manager_visibility.js test, but it only tests whether the Tab Manager button is visible, not whether the drop-down list contains the correct information.

Here's a Try run of my patch. There are quite a few random test failures :( but none of them look related to the Tab Manager. :)

https://treeherder.mozilla.org/jobs?repo=try&revision=f66271d1410d1878427cd474502ed35ccbfe6767

Comment 7

[Dão Gottwald [:dao]]

(In reply to Chris Peterson [:cpeterson] from comment #4)

Hi Dão, I see there are plans for a new Tab Manager design (bug 1494755). Will Proton include that new Tab Manager design?

I have no idea. As far as I know UX folks are still in the drawing-board stage.

In the meantime, would you accept a trivial fix for this bug to include pinned tabs in the Tab Manager's drop-down list?

I would with explicit UX approval.

Would you accept a patch to fix bug 626854 ("Add a separator after pinned tabs in the drop-down list")? You WONTFIX'd that bug 9 years ago. :)

It was wontfixed because we went a different direction for good reasons. Certainly we can reverse course for other good reasons, but I think this should be part of a holistic approach such as the Tab Manager design.

Would you accept a patch to always enable the Tab Manager (change browser.tabs.tabmanager.enabled pref default to true)?

I would with explicit UX/product approval. I suspect we'd want to finish implementing the whole proposal though.

Comment 8

[Dão Gottwald [:dao]]

verdi, can you please take a look at this bug, the last few comments in particular, and let me know what you think about cpeterson's questions?

Comment 9

[Chris Peterson [:cpeterson]]

(In reply to Dão Gottwald [::dao] from comment #8)

verdi, can you please take a look at this bug, the last few comments in particular, and let me know what you think about cpeterson's questions?

Verdi, what is your UX opinion on this bug to stop excluding pinned tabs from the (so-called) "All Tabs" drop down menu?

You can the other questions in my comment 4. At this time, the only change I'd like to make is including pinned tabs in the "All Tabs" drop down menu.

Comment 10

[Mos At]

While at it,

place List all tabs button at the left side where it belongs, it can be hit effortlessly on a maximized window
suitable for browser.tabs.tabmanager.enabled, unlike now, button moving on opening a tab until reaching the end
many would stop chasing clumsy / inefficient / potentially insecure vertical tabs, if aware it can be moved via Customize

increase browser.tabs.tabMinWidth or scale it based on res, 160 is close to ideal 11-12 tabs on 1080p
not useful to have twice the number of tabs in view, when you can't read any titles
with 80 bugzillas open in 768p or 1080p 150% can read 3 numbers perfectly + 1 dimmed + 1 barely visible..

use the same size for min, max, close buttons as for tab scroll and List all buttons, just like under full-screen mode
also remove the 2 x button size separator at the right of the tab strip, just like under full-screen mode

remove overflow-start-indicator / overflow-end-indicator, the respective tab scroll button already lights up as indicator
it's looks so objectively ugly that a new user would mistake it for a visual artifact bug, not a design choice
can't even fix it via userChrome.css as it seems to be overridden somewhere in javascript

remove mask-image of tab label overflow and port the tab separator over to Proton, it's indispensable for clarity
.tab-label-container[textoverflow] {mask-image: unset !important;}

add Restore Previous Session entry to the History toolbar menu
a new annoyance with Proton, entry in hamburger menu was removed

add Bookmark All Tabs entry back, it's removal totally missed the point of urgently clicking it because your pc is shutting down or whatever

Implementation cost: 5 minutes. Maintenance cost: none. User impact: happy, happy, happy [1]
[1] based on user study, details available on request

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1781844682c3
Add pinned tabs to the "List all tabs" drop-down list. r=dao

Comment 12

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/1781844682c3

Comment 13

[inutsume]

Would it be possible to add a toggle in about:config if pinned tabs should be included in the "All tabs" drop-down or not? I have usually around 60~70 tabs open, about 30 of them pinned and now with all tabs showing in the "All tabs" menu it involves quite a lot of scrolling since I need to scroll through my pinned tabs, which I'm seeing anyways to get to the unpinned ones. :(

Thanks for considering!