779714 - mail.tabs.autoHide=true causes tilebar is too narrow after australis tab design

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Makoto Kato [:m_kato]]

Attachment: screenshot with autohide=yes

See screenshot.  title bar is too narrow on Windows 7 with the latest Daily.

Comment 1

[Richard Marti (:Paenglab)]

That's true, but you have gained some pixels for the content ;). When bug 771816 lands you can disable draw in titlebar and you have the standard titlebar back.

Comment 2

[Javi Rueda :javirid]

Did comment 1 fixed this problem?

Comment 3

[Makoto Kato [:m_kato]]

(In reply to Javi Rueda from comment #2)
> Did comment 1 fixed this problem?

No, Although I test on version 33.0, this still occurs.

Comment 4

[Richard Marti (:Paenglab)]

You have set mail.tabs.drawInTitlebar to false and the titlebar is still to narrow? Maybe we should add a logic to disable the draw in titlebar when mail.tabs.autoHide is on true.

Comment 6

[Richard Marti (:Paenglab)]

Attachment: bug779714.patch

This patch adds the logic to disable the draw in titlebar when mail.tabs.autoHide is true. This means draw in titlebar is only enabled when mail.tabs.drawInTitlebar is true and mail.tabs.autoHide is false. Every other combination disables it.

Comment 7

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 8514471 [details] [diff] [review]
bug779714.patch

Review of attachment 8514471 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, this makes sense to me, although I think we will want to mention it somewhere public-ish (Mozillazine, perhaps?) so that we don't get a lot of complaints that people's Thunderbirds aren't drawing in the titlebar anymore…  ;)

Comment 8

[Richard Marti (:Paenglab)]

(In reply to Blake Winton (:bwinton) from comment #7)
> Yeah, this makes sense to me, although I think we will want to mention it
> somewhere public-ish (Mozillazine, perhaps?) so that we don't get a lot of
> complaints that people's Thunderbirds aren't drawing in the titlebar
> anymore…  ;)

But I think the complaints about the not existing titlebar where more. There where more bugs than this one and his dupe.

Comment 9

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/74c1f07e5c52

Comment 10

[Richard Marti (:Paenglab)]

Comment on attachment 8514471 [details] [diff] [review]
bug779714.patch

[Approval Request Comment]
User impact if declined: With autohide=true not dragable titlebar
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): small, only a small js change in the draw in titlebar logic.

Comment 11

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/comm-aurora/rev/49d7c18fa0a1

Comment 12

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/comm-beta/rev/41934b5d9bf9

Comment 13

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/comm-esr31/rev/e6e0aeec5c98

Comment 17

[Charles]

I'm not understanding something...

I have a netbook with a very small screen.

I always use TB maximized, with a minimal UI.

When the UI is maximized, there is never, ever a need to have to move/drag the window.

Prior to this change, I had the Menu Bar displayed in the Titlebar, with the tab bar hidden (only comes up if/when I open the calendar to do something there, then close it to reclaim my minimalist UI). This was an extremely minimal UI that really made working on my netbook much more comfortable.

Am I correct that this change was intentional due solely to the fact that the window cannot be moved/dragged when the Menu bar is displayed in the Titlebar?

If so, I'll go open a bug to bring back this ability when the window is maximized.

Comment 18

[Charles]

Done anyway...

Bug 1273199 - Allow both mail.tabs.drawInTitlebar and mail.tabs.autoHide to be True when window is maximized

Comment 19

[Charles]

And opened bug 1336959 to allow moving the window by click-dragging a blank space on the Menu Toolbar.