78376 - ###!!! ASSERTION: New URI failed: 'Error', file mozilla\netwerk\base\src\nsProtocolProxyService.cpp, line 302

Status: RESOLVED FIXED

(Core :: Networking, defect, P2)

Description

[Gustavo Verdun]

###!!! ASSERTION: New URI failed: 'Error', file 
C:\sb\TazMozilla\mozilla\netwerk\base\src\nsProtocolProxyService.cpp, line 302 

This assertion occurs when opening a browser window for the first time. It 
occurs in the Mozilla mfcEmbed test app.

In this case, the member variable pps->mPACURL is blank. Therefore, the call to 
NewURI fails. There should be a check for this to avoid the assertion.

Comment 1

[drapeau]

Looks like this bug might be a duplicate of a bug that Ed Burns recently fixed.
 Changing ownership to Ed so he can look at it and possible close it as a dup.

Comment 2

[edburns]

No, I don't think this has anything to do with my fix for bug 76921.  If 
anything it looks dependent on bug 53080.  Reassigning to module owner.

Comment 3

[Marek Z. Jeziorek]

Due to interest from the very important embedding customer I'm setting --- or
Future target milestone to 0.9.1

Comment 4

[neeti]

I am not able to reproduce this assertion in a build pulled on 5/02/01 in 
mfcembed.exe. Reporter: are you still seeing the assertion?

Comment 5

[Gagan]

let's anyway verify that pps->mPACURL is not null and return an error if it is.
Should be a small fix.

Comment 6

[Gustavo Verdun]

My fault, I did not mention I was looking at the MOZILLA_0_9_BRANCH branch. 

Could it be that the 1.19 revision in nsProtocolProxyService.cpp fixed it?

Comment 7

[neeti]

Attachment: attaching patch for review

Comment 8

[neeti]

gagan, darin,

Could you r= and sr= the attached patch?

Thanks,
neeti

Comment 9

[Gagan]

r=gagan

Comment 10

[Darin Fisher]

sr=darin

Comment 11

[neeti]

Checked in fix

Comment 12

[Marek Z. Jeziorek]

can thsi also be checked into 0.9?

Comment 13

[neeti]

reopening bug.

Comment 14

[neeti]

attinasi: My fix to remove the assertion in the trunk was simply to check for 
null pps->mPACURL and return an error, since I could not reproduce this 
assertion. Apparently, the assertion got fixed by your checkin to the trunk in 
1.19 revision of nsProtocolProxyService.cpp for bug 53080.

Could you check this in to the branch too?

Comment 15

[Marc Attinasi]

Neeti, so you just checked into the trunk? I'm happy to check the patch into the
branch, I just need to pull a branch and merge it in - I'll do that now.

Comment 16

[neeti]

I checked the patch attached for this bug 78376 into the trunk. I applied 
this patch to the branch, but, this patch does not fix the assertion in the 
branch. We need to checkin your patch for revision 1.19 revision of 
nsProtocolProxyService.cpp into the branch too.

Comment 17

[Marc Attinasi]

Attachment: Patch for branch for review

Comment 18

[Marc Attinasi]

I've attached the patch used for bug 53080 for review. This is the same change
as we applied to the trunk, but I applied it manually (like, I typed it in).

Once reviews are in, I'll commit it. Thanks.

Comment 19

[Jon Granrose]

SPAM: mozilla 0.9 (and M1, and 0.8.1, etc.) has left the building.  please
update the target milestone so we can get a good idea of what's left for 0.9.1.

Comment 20

[Marc Attinasi]

This is already in the trunk, but was requested for the 0./9 branch. Updating
milestone anyway to avoid further spam...

Comment 21

[Darin Fisher]

sr=darin

Comment 22

[Marc Attinasi]

Checked into branch:
/cvsroot/mozilla/netwerk/base/src/nsProtocolProxyService.cpp,v  <-- 
nsProtocolProxyService.cpp
new revision: 1.18.8.1; previous revision: 1.18
done