78410 - Unable to send to mailing lists.

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P1)

Description

[Suresh]

Compose a msg and address to a mailing list. (I selected the mailing list from
the autocomplete pop-up, if that matters).  Send the msgs. Notice that it will
bounce back.  

Build: Yesterdays commercial build on Win NT, Today's commercial build on Mac.
(Hoping the same on Mac).

Note: 
1. In my case I had list called "test1" with couple of valid email id in it.
From the returned email looks like it tried to send to '[e-mail]'. 

2. Can this be dup of http://bugzilla.mozilla.org/show_bug.cgi?id=68188? In my
case mail bounces back, unlike the other bug.

Comment 1

[Suresh]

OR can this be dup of http://bugzilla.mozilla.org/show_bug.cgi?id=54521? I'm
pretty sure when I filed bug 54521, it only adds the domain name to the end of
the list. But if I delete just the default domain name, the mail would go tgh!!

Comment 2

[Suresh]

Re-assigning to myself

Comment 3

[scottputterman]

marking nsbeta1+

Comment 4

[chuang]

I tried it, it looks like the mailing list didn't get expanded.  I have a fix 
which I'll attach later.  

The problem is with the address book refactoring,  the RDF root for all address 
book is "abdirectory://" and the mork address book is "abmdbdirectory://".  To 
get all directories from RDF, we need to use "abdirectory://".

Comment 5

[chuang]

Attachment: fix in mailnews/addrbook

Comment 6

[chuang]

Attachment: fix in mailnews/compose

Comment 7

[chuang]

Suresh,  please try on the patch to see if it fixed the problem you have.

Comment 8

[Jean-Francois Ducarroz]

Candice, can your fix places in mailnews where abdirectories:// still harcoded:

S:\mozilla\mailnews\addrbook\src\nsAbAutoCompleteSession.cpp(401):    if
(!fileName.EqualsWithConversion("abdirectory://"))
S:\mozilla\mailnews\addrbook\src\nsAbAutoCompleteSession.cpp(532):
		  nsAutoString root; root.AssignWithConversion("abdirectory://");
S:\mozilla\mailnews\addrbook\src\nsAbBSDirectory.cpp(133):
	if (!PL_strcmp(mURI, "abdirectory://") && GetDirList())
S:\mozilla\mailnews\addrbook\src\nsAddressBook.cpp(70):static const char
*kBSDDirectoryRoot = "abdirectory://";
S:\mozilla\mailnews\import\src\nsImportAddressBooks.cpp(65):static const char
*kDirectoryDataSourceRoot = "abdirectory://";

Comment 9

[chuang]

I will.

Comment 10

[Suresh]

Candice, The patch fixes the mailing list pbm!!!

Comment 11

[chuang]

I'll clean up the harded string regarding the uris.  Now we have these constants  
spread around the code

In mozilla/mailnews/addrbook/src/nsAddressBook.cpp --
const char *kDirectoryDataSourceRoot = kDirectoryRoot;
const char *kCardDataSourceRoot = kCardRoot;

//use this for creating new address book or directory
static const char *kBSDDirectoryRoot = "abdirectory://";

In mozilla/mailnews/addrbook/src/nsDirPrefs.h --
#define kCardRoot                  "abmdbcard://"
#define kDirectoryRoot		   "abmdbdirectory://"
#define kPersonalAddressbook       "abook.mab"
#define kPersonalAddressbookUri	   "abmdbdirectory://abook.mab"
#define kCollectedAddressbook	   "history.mab"
#define kCollectedAddressbookUri   "abmdbdirectory://history.mab"

In mozilla/mailnews/import/src/nsImportAddressBooks.cpp --
-static const char *kDirectoryDataSourceRoot = "abdirectory://";


I'll put all uri constants in mozilla/mailnews/addrbook/src/nsDirPrefs.h and 
replace all related cinstants and hard coded strings.

#define kAllDirectoryRoot         "abdirectory://" 
#define kMDBCardRoot              "abmdbcard://"
#define kMDBDirectoryRoot	  "abmdbdirectory://"
#define kPersonalAddressbook      "abook.mab"
#define kPersonalAddressbookUri	  "abmdbdirectory://abook.mab"
#define kCollectedAddressbook     "history.mab"
#define kCollectedAddressbookUri  "abmdbdirectory://history.mab"


kDirectoryDataSourceRoot, kDirectoryRoot will be replaced with kMDBDirectoryRoot	  
.
kCardDataSourceRoot, kCardRoot will be replaced with kMDBCardRoot.
kBSDDirectoryRoot will be replaced with kAllDirectoryRoot.

I'll attach the patch later.

Comment 12

[chuang]

Attachment: Patch for clean up the hard coded string and bug fix

Comment 13

[Suresh]

r=suresh

Comment 14

[Jean-Francois Ducarroz]

R=ducarroz

Comment 15

[(not reading, please use [e-mail] instead)]

sr=sspitzer

Comment 16

[chuang]

Fix checked in.

Comment 17

[Oliver Klee]

*** Bug 78986 has been marked as a duplicate of this bug. ***

Comment 18

[Oliver Klee]

*** Bug 68188 has been marked as a duplicate of this bug. ***

Comment 19

[fenella]

Linux (2001-05-09-08 trunk)
Win32 (2001-05-09-06 trunk)
Mac (2001-05-09-08 trunk)
This problem has been fixed.