784114 - [AustralisBird] Make TB tabstrip border color and styling consistent with Australis.

Status: RESOLVED DUPLICATE of bug 952953

(Thunderbird :: Toolbars and Tabs, defect)

Description

[aleth [:aleth]]

Attachment: australis-tab.png

User Agent: Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20120819 Firefox/16.0
Build ID: 20120819042007

Steps to reproduce:

The outline of the tab itself is noticeably darker (or "thicker") than the horizontal border of the tab strip it continues into (see screenshot). This transition should be smooth.

Comment 1

[Richard Marti (:Paenglab)]

Are you using Clearlooks as Linux theme? The problem is, some Linux themes are using borders for the toolbars (like Clearlooks) and some not. My initial patch added a border with the same color as the tab border. But this made on themes like Clearlooks a fat border together with the theme border. So we decided to remove the border and show only the Linux theme border. Unfortunately we can't remove the theme border and add only our border.

I assign Andreas. Maybe he has a solution for this.

Comment 2

[aleth [:aleth]]

(In reply to Richard Marti [:paenglab] from comment #1)
> I assign Andreas. Maybe he has a solution for this.

The screenshot is actually cropped from one by andreasn on #maildev, so he will know which gnome3 theme he is using ;) 

I don't think there's a problem with missing borders so much as a mismatch between colours (which may be related of course, if it's impossible to get the correct colour from the theme).

Comment 3

[Michael Monreal [:micmon]]

Attachment: Screenshot GNOME 3.6

Running current "Earlybird" builds in GNOME 3.6.x (official theme "Adwaita") actually looks worse, the line is missing now (not just colored differently) so the active tab ends "nowhere".

Comment 4

[Richard Marti (:Paenglab)]

Attachment: Screenshot Daily on Mint with Adwaita theme

Bug 824778 made a change with always drawing a line. Maybe this should be backported to TB 17.

Please can you test an actual Daily under Gnome 3.6 and add a screenshot here?

Comment 5

[Richard Marti (:Paenglab)]

Attachment: Screenshot Daily on Ubuntu with Adwaita theme

Comment 6

[Josiah Bruner [:jsbruner]]

Yep, this is a problem. Though on many themes the difference is very subtle. We should however, mimic how Firefox's new Australis theme handles tabstrip border color, which looks much better with lightweight themes.

Comment 7

[Richard Marti (:Paenglab)]

The patch in bug 952953 also implements the Fx tabstrip border color.

Duping this bug to bug 952953.