The default bug view has changed. See this FAQ.

Docked chat boxes should not overlap vertical top-level scrollbars

RESOLVED FIXED in Firefox 17

Status

()

Firefox
SocialAPI
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jaws, Assigned: jaws)

Tracking

Trunk
Firefox 17
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Fx17])

Attachments

(1 attachment, 2 obsolete attachments)

From bug 779686 comment #22:

> If there is a chat window that is right-most, as in this screenshot, does it
> block access to the bottom part of the scrollbars?
> 
> We should move the chat window over just enough to not block any part of the
> scrollbars (even on pages that lack scrollbars, so as not to jump when
> switching tabs or when dynamic changes to content are made).
You're saying scrollbars, but it seems like you're only talking about the vertical scrollbar. How would you address horizontal scrollbar being blocked?

Secondly, I don't think it's kosher to special-case the default scrollbar here and disregard any custom UI implemented by content (such as Facebook's custom scrollbars).

See also bug 779686 comment 57.
Created attachment 655273 [details] [diff] [review]
Patch

This patch fixes the vertical scrollbar issue. I don't have a good solution for third-party vertical scrollbars, nested scrollbars, or horizontal scrollbars.

The vertical ones are much more prevalent though, and we should at least fix this first since it's pretty easy.
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Attachment #655273 - Flags: review?(mixedpuppy)
I spun off the work for horizontal and third-party scrollbars to bug 785591.
Summary: Docked chat boxes should not overlap top-level scrollbars → Docked chat boxes should not overlap vertical top-level scrollbars
Created attachment 655473 [details] [diff] [review]
Patch v2

This patch uses margin instead of padding, which I think is more semantic for the purpose here.
Attachment #655273 - Attachment is obsolete: true
Attachment #655273 - Flags: review?(mixedpuppy)
Attachment #655473 - Flags: review?(mixedpuppy)
Attachment #655473 - Flags: review?(mixedpuppy) → review+
Created attachment 655475 [details] [diff] [review]
Patch for checkin
Attachment #655473 - Attachment is obsolete: true
Attachment #655475 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/469f4e91bb5d
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/469f4e91bb5d
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17

Updated

5 years ago
Blocks: 785593
You need to log in before you can comment on or make changes to this bug.