784272 - Docked chat boxes should not overlap vertical top-level scrollbars

Status: RESOLVED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

From bug 779686 comment #22:

> If there is a chat window that is right-most, as in this screenshot, does it
> block access to the bottom part of the scrollbars?
> 
> We should move the chat window over just enough to not block any part of the
> scrollbars (even on pages that lack scrollbars, so as not to jump when
> switching tabs or when dynamic changes to content are made).

Comment 1

[Dão Gottwald [:dao]]

You're saying scrollbars, but it seems like you're only talking about the vertical scrollbar. How would you address horizontal scrollbar being blocked?

Secondly, I don't think it's kosher to special-case the default scrollbar here and disregard any custom UI implemented by content (such as Facebook's custom scrollbars).

See also bug 779686 comment 57.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

This patch fixes the vertical scrollbar issue. I don't have a good solution for third-party vertical scrollbars, nested scrollbars, or horizontal scrollbars.

The vertical ones are much more prevalent though, and we should at least fix this first since it's pretty easy.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

I spun off the work for horizontal and third-party scrollbars to bug 785591.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch v2

This patch uses margin instead of padding, which I think is more semantic for the purpose here.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch for checkin

Comment 6

[Mark Hammond [:markh] [:mhammond]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/469f4e91bb5d

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/469f4e91bb5d