78619 - View-source: pages have a view source option if opened by hyperlink

Status: NEW

(SeaMonkey :: UI Design, defect)

Description

[Skewer]

Procedure: Load this page:

view-source:http://www.yahoo.com/

Expected: The source code for the website is displayed in the same manner as if
the view source option had been selected.

Actual: The context menu includes an option to view source on a view-source:
URL. Of course, this does not work.

Comment 1

[Boris Zbarsky [:bzbarsky]]

OK.  The "problem" here is that the view-source: URL is loaded in the normal
navigator window with all its menus and context menus and whatnot, right?

The options I see are:
1)  Kick off the viewsource window for view-source: urls in navigator (using JS)
2)  Disable the C-u shortcut, View Source context menu option, and View Source
    menuitem when the url is a view-source: one

Neither of these is parser.  Over to XP Apps.

#1 is probably simpler to do, but #2 is the one that seems like the more correct
solution....

Comment 2

[Alexey Chernyak]

Interesting, this is a teaser for bug 74862 :o)

Comment 3

[Skewer]

I thought that bug was the same as this one, but when I looked at it, it's
completely different.

Comment 4

[Skewer]

I'm for opening view-source: URLs in a new window, which would be the same
behavior NS4 and IE users expect. Anyone care to accept this bug?

Comment 5

[Boris Zbarsky [:bzbarsky]]

mpt, this is the bug I was sort of referring to earlier.  Which would be the
more correct UI here?

Comment 6

[Skewer]

If you are directing us to information from another bug, you might want to
provide the bug number...

I think the first behavior you described is the more correct choice, since
that's the way Communicator and IE (well, sort of) does it. The only kind of
browser that should display the view-source: in the same window is a
single-document interface browser, which Mozilla isn't.

Main reason for this behavior? People want to flip between source code and the
HTML page to see what tag creates what effect.

Also, as bug 39389 suggests, we should have a separate context menu for the
source code window. I'll just mention that so we don't start talking about it
here, since that is important enough to have its own bug.

Comment 7

[Boris Zbarsky [:bzbarsky]]

I am not directing anyone anywhere.  I am asking mpt's opinion on the UI we
should have here, seeing as he _is_ the UI design feedback component owner...

I can think of plenty of reasons the NS 4.x behavior is wrong.  eg:  I type
"view-source:http://www.cnn.com" in the URL bar and hit enter.  A view-source
window pops up and nothing changes in the original window.  This is a little
weird, to me.  I am personally inclined toward option #1 myself, but I would
still like mpt to check it out before we start coding.

Comment 8

[Boris Zbarsky [:bzbarsky]]

OK.  I talked to mpt and he says that we should go ahead and do #1.  Patch
coming up.  Reviews?

Comment 9

[Boris Zbarsky [:bzbarsky]]

Attachment: proposed patch

Comment 10

[timeless]

r=timeless, please file or find a bug to reenable this feature when we actually support view-source:view-source:url

Comment 11

[Boris Zbarsky [:bzbarsky]]

bug 79339 filed.

Comment 12

[Boris Zbarsky [:bzbarsky]]

Alec, would you sr?

Comment 13

[Alec Flett]

good code factoring
sr=alecf

Comment 14

[Boris Zbarsky [:bzbarsky]]

Fix checked in by timeless.  Thanks for your time all.  Move along, nothing else
to see here.

Comment 15

[Skewer]

I really like the way the patch works with view-source: type-in URLs, but I
still experience this bug when clicking on a link to a view-source: URL.
Reopening and narrowing scope of title.

Title was: View-source: pages have a view source option

Comment 16

[Boris Zbarsky [:bzbarsky]]

OK.  I don't have the time to do this at the moment.  It's likely to require
some very odd protocol handler hacking....

I will also be gone for about a month starting next week.  So, reassigning to
component owner for further triage.

Comment 17

[rbs]

Something that was forgotten in attachment 33451 [details] [diff] [review] was to reset the 
urlbar -- otherwise it still shows the typed-in "view-source:..." which 
isn't really what is being displayed in the main window.

Comment 18

[Skewer]

Updated URL. This will create a link to a view-source: page.

data:text/html,<A HREF="view-source:http://www.yahoo.com/">Yahoo source</A>

Comment 19

[Skewer]

Message upon trying to view source of linked view-source:

Downloading null

You have chosen to download a file of type: text-html; x-view-type=view-source;
x-view-type=view-source from http://www.yahoo.com/

Still not assigned? ¡Que lastima!

Comment 20

[Peter Henderson]

I don't know if this requires another bug to be filed, but when I click on the
Yahoo source link from the page created by the URL field, the window title shows
"http://www.yahoo.com/" not "Source of http://www.y..." as a regular view-source
window shows. Perhaps this could be addressed while waiting for the patch to
open hyperlinked view-source in a new window?

Comment 21

[sairuh (rarely reading bugmail)]

-> doron, Mr View Source (but reassign if needed :)

Comment 22

[sairuh (rarely reading bugmail)]

mass moving open bugs pertaining to view source to [e-mail] as qa contact.

to find all bugspam pertaining to this, set your search string to
"ItsSharkeysNight".

Comment 23

[Boris Zbarsky [:bzbarsky]]

*** Bug 122778 has been marked as a duplicate of this bug. ***

Comment 24

[Gordon P. Hemsley [:GPHemsley]]

Just as a note, while this isn't an extremely important bug, it's still present
in Mozilla Application Suite 1.7.8.

Comment 25

[Sebastian Moser]

works for me

(firefox 2.0 nightly build 2006061003)

Comment 26

[Skewer]

Testing with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b4) Gecko/2008030714 Firefox/3.0b4

...Still happens.

Comment 27

[Gordon P. Hemsley [:GPHemsley]]

Yup, still happens in Firefox 3.0 final., though clicking on the "View Page Source" menu item opens up an unhighlighted copy of the same source. I don't know if that was present in the issue as originally reported.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9) Gecko/2008052906 Firefox/3.0