789450 - Chat Tab doesn't stay open when re-opening Thunderbird

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[foudfou]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20100101 Firefox/15.0
Build ID: 20120828083304

Steps to reproduce:

1. start  Thunderbird
2. open Chat Tab
3. quit Thunderbird
4. start Thunderbird again


Actual results:

Chat Tab is not (re-)opened


Expected results:

Chat Tab should have been (re-)opened

Comment 1

[foudfou]

Attachment: basic implementation

Since im accounts already have the autoload feature, not sure if we should try to restore (reconnect?) accounts and convs.

Comment 2

[Patrick Cloke [:clokep]]

(In reply to foudfou from comment #1)
> Since im accounts already have the autoload feature, not sure if we should
> try to restore (reconnect?) accounts and convs.
I'm unsure if you mean that accounts auto-connect or that you can "auto-join" chatrooms. My guess is that this would be a separate bug, however.

I think it IS wanted though...at least for the backend (and the Instantbird UI) we've wanted to be able to restore everything about a session when restarting [1].

[1] https://bugzilla.instantbird.org/show_bug.cgi?id=307

Comment 3

[foudfou]

Patrick, I meant account auto-connecting. The patch in comment 1 addresses the restore of the Chat tab, which this bug is about. Do you suggest the whole session restore (to be defined) should be implemented ? Or should this be handled in another bug ?

Comment 4

[Patrick Cloke [:clokep]]

(In reply to foudfou from comment #3)
> Patrick, I meant account auto-connecting. The patch in comment 1 addresses
> the restore of the Chat tab, which this bug is about. Do you suggest the
> whole session restore (to be defined) should be implemented ? Or should this
> be handled in another bug ?

That would be a different bug.

Comment 5

[foudfou]

Hi all, could anyone provide feedback ? Or should I just request for review ?

Comment 6

[foudfou]

Attachment: slightly polished

I'm not dropping on this guys :)

Comment 7

[foudfou]

Attachment: reopen chat tab v3

Probably my last proposal. I thought of implementing tests, but won't probably be able to do it in the short term.

Comment 8

[foudfou]

Attachment: v4 with test

Here's a version with a test inspired from test_folder_pane_persistence_generally_works().
I added a test file in /mail/test/mozmill/im, but it may be better to merge it with test-toolbar-buttons.js, and rename this one to something more general.

Comment 9

[Florian Quèze [:florian]]

The last 2 attachments are identical here, did you mean to attach a test?

Comment 10

[foudfou]

Attachment: v4 with test, really

Oops, here's the one that includes the test.

Comment 11

[Wayne Mery (:wsmwk)]

(In reply to foudfou from comment #10)
> Created attachment 8394061 [details] [diff] [review]
> v4 with test, really
> 
> Oops, here's the one that includes the test.

Comment 13

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/21c7f2e1e706be47acc74af309680a536c694b33
Bug 789450 - Persist Chat tab after Thunderbird restart. r=aleth

Comment 14

[aleth [:aleth]]

Comment on attachment 8394061 [details] [diff] [review]
v4 with test, really

Review of attachment 8394061 [details] [diff] [review]:
-----------------------------------------------------------------

Many thanks for this fix and the test! I've unbitrotted the patch and fixed some minor style nits before checkin. 

Sorry the review was pending for so long!