79862 - Downloading/helper app dialog does not respond to key equivalenets

Status: VERIFIED FIXED

(Core Graveyard :: File Handling, defect, P3)

Description

[Simon Fraser [no longer active]]

I can't confirm or cancel the download dialog with the keyboard; it should 
respond to Esc, Command-. (on Mac), Return and Enter, but does not.

Comment 1

[sairuh (rarely reading bugmail)]

happens on linux, too. nominating for beta1, even tho [sigh] related bug 74012
[for the download progress dialog] was minused.

Comment 2

[sairuh (rarely reading bugmail)]

*** Bug 81896 has been marked as a duplicate of this bug. ***

Comment 3

[Bill Law]

Attachment: Trivial fix

Comment 4

[Bill Law]

Trivial fix attached; Ben had done that as part of another bug but problems 
blocked that one from landing.

Comment 5

[Simon Fraser [no longer active]]

r=sfraser

Comment 6

[Paul Chen]

nav triage team:

Adding alecf to cc list for sr=

Comment 7

[Alec Flett]

awesome.
sr=alecf

Comment 8

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to the trunk.
(on behalf of drivers)

Comment 9

[Bill Law]

Thank you; fix checked in.

Comment 10

[sairuh (rarely reading bugmail)]

nope, still broken, at least on mac and linux [tested using 2001.06.19.08 comm
bits].

works, however, on winnt [2001.06.18.09 comm bits].

reopening, will reassign to blake per conversation.

Comment 11

[sairuh (rarely reading bugmail)]

->blake. thx!

Comment 12

[sairuh (rarely reading bugmail)]

*** Bug 87762 has been marked as a duplicate of this bug. ***

Comment 13

[James Ross]

The keyboard keys don't work on Windows 2000 using build 2001.06.07.03, either.

Comment 14

[sairuh (rarely reading bugmail)]

*** Bug 89290 has been marked as a duplicate of this bug. ***

Comment 15

[saari (gone)]

Is this still a problem? Seems to work for me on win2k

Comment 16

[Aaron Leventhal]

Related:

bug 74012
bug 67803

Comment 17

[Brian Clark]

This is still a problem for me on MacOS 9.1 with 2001092808.  When downloading
something, such as the latest Mozilla build, no key commands work.  For example,
hitting "command-." or "Esc" does not cancel the download, as is customary on
the Mac.  Also, hitting "Return" does not "ok" the download, even though the OK
button is outlined in black.  

Comment 18

[sairuh (rarely reading bugmail)]

yeah, still a problem for me on linux and winnt as well:

* linux [like Mac/modern] suffers from the "no initial focus set" issue, bug
58853. this requires the user to click first before being able to navigate with
the keyboard.

* once i have focus, i can tab around the various widgets...except for the
deselected radiobutton --which makes it tricky to change that choice w/o using
the mouse [afaict].

Comment 19

[Brian Clark]

I just retested this with 2001100210 on MacOS 9.1 (modern theme) and still have
the same problems.  I want to clarify something though: the key commands do not
work regardless of whether I have clicked on the download dialog to bring it
into focus or not.  However, when I do bring it into focus, I can tab around the
different buttons.  I just can't select any of them by hitting the Return key
once they are selected.

Also, in the download dialog it seemed that I could tab to a grayed out button.
  There is no indication that I have tabbed to that button other than no other
button is active and the grayed out button would be the next logical button to
be active, if it wasn't grayed out.  

My suggestion:  make it so you can't tab to a grayed out button in a dialog. 
Should this be a separate bug?  Perhaps it already exists?  I couldn't find one. 

Comment 20

[sairuh (rarely reading bugmail)]

spam: over to File Handling. i have not changed the assigned developer [or the
other fields for that matter], so if anyone realizes that a bug should have a
more appropriate owner, go ahead and change it. :)

Comment 21

[Bill Law]

Esc and enter keys now work.

Comment 22

[sairuh (rarely reading bugmail)]

need to revisit this with more recent builds than what i have --afaik, esc and
enter [return on mac os] work on all platforms...but there might be a
[seperate?] issue with space on mac. will check later on.

Comment 23

[sairuh (rarely reading bugmail)]

okay, this is fixed --except for the issue with Space not working on OS X [bug
108722].

vrfy'd using the following commercial bits:

linux [rh6.2] - 2001.11.06.12
winnt - 2001.11.06.03
mac os 10.1 - 2001.11.06.08