[Email] Need errors thrown when sending emails with no Email addresses

VERIFIED FIXED

Status

Firefox OS
Gaia::E-Mail
P1
normal
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: tchung, Assigned: steveck)

Tracking

unspecified
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(blocking-basecamp:+)

Details

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
No errors are shown when sending an email with no address in To, cc or bcc line.   Instead, it acts like the message was sent and returns user to the inbox.

Environment:
- 10/5 daily otoro build
- gaia: ca1f327d5acc198bb4be62fa51db2c039032c9ce
- gecko: ddc8eeb3f9b9ee04d9f74b4f60522eb4530a4a6f

Repro:
1) launch email and add an account (gmail)
2) hit compose
3) do not enter any email addresses in the To, CC, or bcc line.
4) Hit Send
5) Verify a message does not error out, instead acts like its sent and returns to inbox.

Expected:
- in app messaging throwing errors if no email addresses are included

Actual:
- message seems like its been sent to someone.
(Assignee)

Updated

5 years ago
Assignee: nobody → schung
(Assignee)

Comment 1

5 years ago
Hi Casey, do we need to apply any other error handling for no sender case, or just use 'Sent failed' in toaster like other sent failed scenario?

Updated

5 years ago
blocking-basecamp: ? → +
Priority: -- → P1
(Assignee)

Comment 2

5 years ago
Created attachment 671720 [details]
https://github.com/mozilla-b2g/gaia/pull/5826
Attachment #671720 - Flags: review?(dkuo)
Attachment #671720 - Flags: review?(bugmail)
(Assignee)

Updated

5 years ago
Blocks: 802006

Comment 3

5 years ago
Casey, it looks like we need your help to update the wireframes and see how we should do here. You may refer to https://github.com/mozilla-b2g/gaia/pull/5826.
Assignee: schung → kyee

Updated

5 years ago
Priority: P1 → --

Updated

5 years ago
Priority: -- → P1
(Assignee)

Updated

5 years ago
See Also: → bug 804907
Comment on attachment 671720 [details]
https://github.com/mozilla-b2g/gaia/pull/5826

This pull request got repurposed and landed as part of bug 804916, clearing review requests.

This bug may end up just being entirely covered by bug 804907 since it changes up our sending style to be synchronous.  Steve, I've marked you as the assignee for that bug.
Attachment #671720 - Flags: review?(dkuo)
Attachment #671720 - Flags: review?(bugmail)
(Assignee)

Updated

5 years ago
Assignee: kyee → schung
(Assignee)

Comment 5

5 years ago
Created attachment 677293 [details]
Patch for adding new dialog to notify of send failure
Attachment #677293 - Flags: review?(dkuo)
Attachment #677293 - Flags: review?(bugmail)
(Assignee)

Comment 6

5 years ago
Hi Casey,
Since there is no wireframe for the sent failed flow, please feel free to create the polish issue if this prototype is far from your design, thanks.
Comment on attachment 677293 [details]
Patch for adding new dialog to notify of send failure

Clearing review request since we are taking care of this on Bug 804907.
Attachment #677293 - Flags: review?(dkuo)
Attachment #677293 - Flags: review?(bugmail)
(Assignee)

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Comment 8

5 years ago
On Unagi Build 20121231070201 the button to send is grayed out until the User places an address in one of the fields, thus the e-mail cannot be sent if no recipient is entered in the To, cc, bcc fields.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.