Closed Bug 807758 (b2g-bluetooth-a2dp) Opened 9 years ago Closed 8 years ago

[b2g-bluetooth] [meta] Implement A2DP profile for B2G

Categories

(Core :: DOM: Device Interfaces, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
1.2 FC (16sep)

People

(Reporter: qdot, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fuzzing:?][d-watch][u= c= p=0])

Attachments

(1 obsolete file)

Implement high(er) fidelity audio profile for B2G.
Note: This is just a placeholder for V2+. Not planned for V1.
To enable a2dp/avrcp module for bluez, it is required to make sure "Sink", "Control" module had been enabled.
/system/bluetooth/data/audio.conf
Enable=Sink,Control
Add initial version of A2DP support.
Attachment #730639 - Flags: feedback?(echou)
Comment on attachment 730639 [details] [diff] [review]
Initial version of A2DP implementation

Review of attachment 730639 [details] [diff] [review]:
-----------------------------------------------------------------

This is a HUGE patch. 19 files are modified. If you don't mind, please separate them to several patches by different functions once it's in review process.

I'll take a quick look by next Monday.
Comment on attachment 730639 [details] [diff] [review]
Initial version of A2DP implementation

I will separate different patches. Sorry for confusion.
Attachment #730639 - Flags: feedback?(echou)
I've gone through the initial version. Refactored/Refined code, fixed bugs, and added error handling in the following branch. Some logics are also changed.

https://github.com/ginayeh/mozilla-central/commits/TestA2dpAvrcp13-new




I think we're ready to start reviewing. Shawn, can you help to separate our HUGE patch into several patches? Thanks.
Flags: sec-review?(cdiehl)
Flags: sec-review?(cdiehl)
Whiteboard: [fuzzing:queue:?]
Whiteboard: [fuzzing:queue:?] → [fuzzing:?]
Summary: [b2g-bluetooth] Implement A2DP profile for B2G → [b2g-bluetooth] [meta] Implement A2DP profile for B2G
Depends on: 872907
Depends on: 882551
No longer depends on: 882551
Bug 872907 had been resolved. Now Gecko is A2DP enabled. Right now, it supports HFP/A2DP Bluetooth devices now.
Depends on: 893673
Depends on: 889795
Depends on: 893675
Depends on: 895299
Depends on: 893674
Depends on: 893676
Whiteboard: [fuzzing:?] → [fuzzing:?][d-watch]
No longer blocks: 836180
Depends on: 836180
Depends on: 906279
Depends on: 906288
Depends on: 906291
Depends on: 906294
Depends on: 906305
Whiteboard: [fuzzing:?][d-watch] → [fuzzing:?][d-watch][u= c= p=0]
Depends on: 910140
No longer depends on: 910140
Depends on: 913372
Depends on: 913374
Depends on: 919861
No longer blocks: 919868
Depends on: 919868
Depends on: 919884
Can we just call this done?
No longer depends on: 835226
(In reply to Kyle Machulis [:kmachulis] [:qdot] from comment #9)
> Can we just call this done?

Sure. A2DP has been merged into codebase since FxOS v1.2 FC (about 3 month ago), it's time to close this bug.

Thank you all.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.2 FC (16sep)
You need to log in before you can comment on or make changes to this bug.