81194 - need to clean up Arabic shaping code in nsBidiUtilsImp.cpp

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Frank Tang]

The Arabic shaping code in nsBidiUtilsImp.cpp is currently not working since we 
#ifdef FULL_ARABIC_SHAPING
the issue is we have a lot of array boundary violation in that code. 
simon- can you forward this to the right person (ahmed?) to work on ?
It will be nice if they can explain what they try to do there. I can help them 
to write that routine since I code the origional one in the GFX.

Also, see 80167

Comment 1

[Frank Tang]

make sure we test 75026 before turn FULL_ARABIC_SHAPING on.

Comment 2

[Andreas Becker]

Changing QA contact to [e-mail].

Comment 3

[Frank Tang]

ok, there are different shaping code in nsBidiUtils, some are used for display 
and some are used for copy&paste. I think the priority are differents. Also, 
the quality of the current code quality are different in these routines. Some 
are better than the other, therefore, I break it down into 4 bugs 
82089 nsBidiUtilsImp::ArabicShaping should be turn on 
82093 bidi: arabic: Conv_FE_06 in intl/unicharutil/src/nsBidiUtils 
82096 bidi- arabic- need to turn on nsBidiUtilsImp::Conv_FE_06_WithReverse
82097 bidi- arabic- need to turn on nsBidiUtilsImp::Conv_06_FE_WithReverse

I think 82089 is important than others since it is used for non BIDI system 
Arabic display. The other three are used by copy&paste and form code

change this bug to meta bugs and reassign back to ftang

Comment 4

[Frank Tang]

remove milestone.

Comment 5

[Frank Tang]

reassign to simon

Comment 6

[Maha Abou El-Rous]

depends on 82383 new ICU shaping

Comment 7

[Simon Montagu :smontagu]

This bug has been superseded by bug 97297

Comment 8

[Roozbeh Pournader]

There is no bug 97297. You should mean bug 92797.

Comment 9

[Simon Montagu :smontagu]

Thanks for the correction, Roozbeh. Bug 92797 is what I meant.