82073 - clicking on link in three-pane crashes in docshell [@ nsDocShell::SetFocus]

Status: VERIFIED FIXED

(Core :: DOM: Navigation, defect)

Description

[Chris Waterson]

I'm crashing when clicking on a link in a message in the mailnews three-pane 
window. The problem appears to by with bryner's recent fix for bug 31809 (but 
it might also be the interaction of that change with valeski's recent change to 
nsDocShell).

Anyway, I'll attach a stack trace, but the basic problem is that presShell-
>GetRootFrame() is returning a null frame in nsDocShell::GetMainWidget().

Comment 1

[Chris Waterson]

Attachment: stack trace at the crash.

Comment 2

[Scott MacGregor]

hmmm I have a clean pull from 8pm tonight and I can't reproduce it. I wonder if
something was checked in later tonight which made this go away? Or is your tree
a recent pull too? 

Comment 3

[Scott MacGregor]

I feel stupid. Of course I ran into this crash right after submitting my
comments. Please ignore, I see this. This will be a smoketest blocker tomorrow
morning so putting on the radar now. 

Comment 4

[Oliver Klee]

*** Bug 82128 has been marked as a duplicate of this bug. ***

Comment 5

[Oliver Klee]

Possible dupe of bug 53378?

Comment 6

[Oliver Klee]

*** Bug 82131 has been marked as a duplicate of this bug. ***

Comment 7

[Oliver Klee]

Setting OS=All one of the duplicates is on Linux.

Comment 8

[Kathleen :Brade]

I didn't need to click on any link with my Mac build.  All I did was delete a 
message and I crashed when the next message was loading.  I had read several 
messages and deleted some prior to the crash.  I use IMAP and move-to-trash.

I have the same stack as the attachment.

Comment 9

[Chris Waterson]

Attachment: wallpaper

Comment 10

[Chris Waterson]

I wallpapered over the crash for now, since bryner is not around. Clearing bug
from blocker status, but leaving open for bryner to verify that the fix is right.

Comment 11

[Scott MacGregor]

*** Bug 82147 has been marked as a duplicate of this bug. ***

Comment 12

[Kathleen :Brade]

*** Bug 82155 has been marked as a duplicate of this bug. ***

Comment 13

[Peter Trudelle]

restoring blocker status. We need this visible until workaround/fix is verified
in respin.

Comment 14

[Scott MacGregor]

*** Bug 82291 has been marked as a duplicate of this bug. ***

Comment 15

[Peter Trudelle]

moving to 0.9.2/normal severity since it doesn't crash with Waterson's
wall-papering fix, as tested in today's NS builds on Win98.  Bryner, please
review fix and verify if it can be permanent.

Comment 16

[greer]

Adding [@ nsDocShell::SetFocus] to summary for talkback tracking

Comment 17

[Brian Ryner (not reading)]

This wasn't quite the right fix, but danm came up with the right one in a
different bug, and it's checked in.

Comment 18

[Jan Carpenter]

verified