823840 - AMO is offering wrong add-on version

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

AMO is serving wrong version of addon if Firefox 16 is installed.

STR:

1) Install Firefox 16.0.2 (make sure you disable auto update)
2) Open https://addons.mozilla.org/en-US/firefox/addon/firebug/
3) The page says Firebug 1.11.1 (which is not compatible with Fx16, but let's ignore this)
4) Click "Add to Firefox", click OK in the installation dialog.
5) Firebug 1.7.3 is installed -> BUG

Firebug 1.7.3 is not even compatible with Fx16. It's marked as compatible with 3.6 - 5.*

If you go to about:addons, right click on Firebug and pick "Find updates" Firebug is upgraded to 1.10.6, which is correct.

But 1.10.6 should be installed in the first place.

--

Related Firebug issue report:
http://code.google.com/p/fbug/issues/detail?id=6154

Honza

Comment 1

[Jorge Villalobos [:jorgev] (he/him)]

I can confirm this also happens on Mac OS X.

Additionally, if I look at the All Versions page, version 1.10.6 and others below it are correctly marked as compatible with 16.0.2.

Comment 2

[Kris Maglione [:kmag]]

Hm. The install button actually links to that version specifically:

https://addons.mozilla.org/firefox/downloads/file/123595/firebug-1.7.3-fx.xpi?src=dp-btn-primary

rather than the -latest version that most add-ons link to:

https://addons.mozilla.org/firefox/downloads/latest/9609/addon-9609-latest.xpi?src=dp-btn-primary

Any idea how long this has been going on?

Comment 3

[Rob Hudson [:robhudson]]

I also notice this doesn't list Firebug at all:
https://services.addons.mozilla.org/en-US/firefox/api/1.5/search/firebug/all/30/Darwin/16.0/

But if you remove the /16.0 at the end it does list it.

Something is odd.

Comment 4

[Kris Maglione [:kmag]]

Yeah, that's another known bug. Search results that specify compatibility only take into account the latest version. I can't find the version number, but it's the same bug that prevents Lightning from showing up in the add-on manager search results for anything but the latest Thunderbird.

Comment 5

[Sebastian Zartner [:sebo]]

According to the addon history page all versions since Firebug 1.7X.0b1[1] say that they are compatible "with Firefox X and *later*".
So that seems to be a compatibility issue, because older versions of Firebug don't run on newer browser versions.

@Honza:
Can you change the max. compatibility info for the old versions back to their initial value?

Sebastian

https://addons.mozilla.org/firefox/addon/firebug/versions/1.7X.0b1

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

I can still see the original reported problem. Anyone ready to fix this bug?

(In reply to Sebastian Zartner from comment #5)
> @Honza:
> Can you change the max. compatibility info for the old versions back to
> their initial value?
@Jorge: do you know if I can change the max compatibility info?

When I look at the individual releases (within Status & Versions page),
specifically when I look at "Manage Version 1.7.3" I can see that 1.7.3
is compatible with 3.6 - 5.*

But, this page:
https://addons.mozilla.org/en-US/firefox/addon/firebug/versions/?page=3#version-1.7X.0b1

... says: Works with Firefox 3.6 and later 

I think it's because AMO is automatically increasing the max version.
Is there any way how to stop this?

Honza

Comment 7

[Jorge Villalobos [:jorgev] (he/him)]

(In reply to Jan Honza Odvarko from comment #6) 
> I think it's because AMO is automatically increasing the max version.
> Is there any way how to stop this?

It might work if you reduce the maxVersion to 4.*. I think default to compatible is only activated for 5.0 and above. The only other thing I can do is add it to the compatibility override list, but I don't think that has any effect on AMO or search results. Instead it just makes Firefox tell the user it is incompatible when they try to install it.

Comment 8

[Kris Maglione [:kmag]]

Compat overrides do have a result on what's displayed on AMO. It doesn't show in the compat ranges, but it does disable the install button and show a message if it's incompatible.

Comment 9

[Jorge Villalobos [:jorgev] (he/him)]

Alright, let's give it a try. Honza, which versions of Firebug do you want to appear as incompatible, and with which versions of Firefox?

Comment 10

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Jorge Villalobos [:jorgev] from comment #9)
> Alright, let's give it a try. Honza, which versions of Firebug do you want
> to appear as incompatible, and with which versions of Firefox?

This report has been done for Firebug 1.7.3

This version is somehow causing problems (see comment #0).

When I install Firefox 16-22 (tested with 16, 17, 18 and 22), go to Firebug AMO page, click the install Firebug, Firebug 1.7.3. is always installed. This is because the install button points to: https://addons.mozilla.org/firefox/downloads/file/123595/firebug-1.7.3-fx.xpi?src=dp-btn-primary

If I install Firefox 23, Firebug 1.12.3 is properly installed, since the install button points to: https://addons.mozilla.org/firefox/downloads/latest/1843/addon-1843-latest.xpi?src=dp-btn-primary)

See also comment #2 that mentions the install button link.

See the compatibility table here:
https://addons.mozilla.org/en-US/firefox/addon/firebug/

To summarize, Firebug 1.7.3 is compatible only with 3.6-5.* (as defined in install.rdf), this version should *not* be installed for other Firefox versions.

Honza

Comment 11

[Jorge Villalobos [:jorgev] (he/him)]

I added a compatibility override for Firebug 0 - 1.7.3 in Firefox 6.0a1 - *. Please test in a couple of hours and see if this makes any difference in the install experience.

Comment 12

[Sebastian Zartner [:sebo]]

Regarding the problem related to version 1.7.3 it seems to work for me now.
The Firefox compatibilities and displayed compatibility info for the different Firebug versions still isn't correct, though. But I guess that should be addressed in another issue, right?

Sebastian

Comment 13

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Jorge Villalobos [:jorgev] from comment #11)
> I added a compatibility override for Firebug 0 - 1.7.3 in Firefox 6.0a1 - *.
> Please test in a couple of hours and see if this makes any difference in the
> install experience.
For me the install button is grayed out for Firefox 16-22 and enabled for Firefox 23+, so that's definitely a progress.

Interestingly it's enabled even for Firefox 27, even if install.rdf says max=26, but this isn't a big problem (could be AMO bug though).

(In reply to Sebastian Zartner from comment #12)
> Regarding the problem related to version 1.7.3 it seems to work for me now.
> The Firefox compatibilities and displayed compatibility info for the
> different Firebug versions still isn't correct, though.
Sebastian, not sure if it's clear what you mean, can you provide more detailed info?

Honza

Comment 14

[Sebastian Zartner [:sebo]]

(In reply to Jan Honza Odvarko from comment #13)
> (In reply to Jorge Villalobos [:jorgev] from comment #11)
> (In reply to Sebastian Zartner from comment #12)
> > Regarding the problem related to version 1.7.3 it seems to work for me now.
> > The Firefox compatibilities and displayed compatibility info for the
> > different Firebug versions still isn't correct, though.
> Sebastian, not sure if it's clear what you mean, can you provide more
> detailed info?
The version info on the page still says "Works with Firefox 3.6 and later" for 1.7.3 instead of something like "Works with Firefox 3.6 up to Firefox 5.0" and searching for "firebug" in the Add-ons Manager in Firefox 22.0 doesn't display Firebug at all.
Also accessing the page with a previous version of Firefox should always offer the latest compatible version of the add-on instead of graying out the install button.

Something which would probably help us is bug 896295.

Sebastian

Comment 15

[Jorge Villalobos [:jorgev] (he/him)]

Those are separate bugs, and I believe they are already filed.

Is this fixed, then?

Comment 16

[Sebastian Zartner [:sebo]]

> Those are separate bugs, and I believe they are already filed.
Would be great if you could point me to them, because I could just find the one I mentioned above.

> Is this fixed, then?
If the problem that you can't find Firebug through the integrated add-ons search in an old version of Firefox existed before your change (I honestly can't remember), then yes.
Honza, can you confirm that?

Sebastian

Comment 17

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Sebastian Zartner from comment #16)
> If the problem that you can't find Firebug through the integrated add-ons
> search in an old version of Firefox existed before your change (I honestly
> can't remember), then yes.
> Honza, can you confirm that?
I don't know I didn't test it.

(In reply to Jorge Villalobos [:jorgev] from comment #15)
> Is this fixed, then?
The originally reported problem is fixed, yes.

Honza

Comment 18

[Jorge Villalobos [:jorgev] (he/him)]

(In reply to Sebastian Zartner from comment #16)
> > Those are separate bugs, and I believe they are already filed.
> Would be great if you could point me to them, because I could just find the
> one I mentioned above.

There's bug 705578, bug 525179, and bug 721727.


(In reply to Jan Honza Odvarko from comment #17)
> (In reply to Jorge Villalobos [:jorgev] from comment #15)
> > Is this fixed, then?
> The originally reported problem is fixed, yes.

Okay, let's call this fixed then. Anything else can be filed in follow-ups.