825851 - [Bluetooth][Hfp] Handle AT command: AT+VGM

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Eric Chou [:ericchou] [:echou]]

To support feature "Remote audio volume control", we need to handle AT command AT+VGM.

Please see 4.28 "Remote Audio Volume Control" of HFP 1.5 for more detail.

Comment 1

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: Patch 1(v1): Handle AT command: AT+VGM

Cache the value of vgm in BluetoothHfpManager and reply OK.

Comment 2

[Eric Chou [:ericchou] [:echou]]

Comment on attachment 697318 [details] [diff] [review]
Patch 1(v1): Handle AT command: AT+VGM

Review of attachment 697318 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with nit picked

::: dom/bluetooth/BluetoothHfpManager.cpp
@@ +630,5 @@
> +      NS_WARNING("Failed to extract microphone volume from bluetooth headset!");
> +      goto respond_with_ok;
> +    }
> +
> +#ifdef DEBUG

We don't need to do this ourselves. NS_ASSERTION won't do anything if DEBUG is not defined.

Comment 3

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: Patch 1: Handle AT command: AT+VGM, r=echou

Final patch

Comment 4

[Gina Yeh [:gyeh] [:ginayeh]]

try:

https://tbpl.mozilla.org/?tree=Try&rev=de9fd7991540
https://tbpl.mozilla.org/?tree=Try&rev=0bea8993422d

Comment 5

[Gina Yeh [:gyeh] [:ginayeh]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f99d7beaab4a

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/f99d7beaab4a

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/a52394eaad19

Comment 8

[Gina Yeh [:gyeh] [:ginayeh]]

This bug(and other 12 bugs) block Bluetooth certification. So, these bugs need to be marked as tef+ and landed to v1.0.1 in order to pass Bluetooth certification: 

bug 827255
bug 827212
bug 827266
bug 828175
bug 823346
bug 827230
bug 828798
bug 835740
bug 846647
bug 828160
bug 827204
bug 825861
bug 825851

So, mark these bugs as tef?. These fixes have some dependency and it would be better to have them landed in a specific order. I'll provide the order later.

Comment 9

[Gina Yeh [:gyeh] [:ginayeh]]

I recommend to land these patches in the following order:

01. bug827204
02. bug827255
03. bug823346
04. bug827230
05. bug828798
06. bug827212, patch 1
06. bug827212, patch 2
07. bug827266
08. bug828175
09. bug846647
10. bug825861
11. bug825851
12. bug835740




I'm going to attach patches for b2g18_v1_0_1 for each bug. Please land them in the above order. There should be no conflict and feel free to let me know if I can be any help.

Comment 10

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: b2g18_v1_0_1 patch

Comment 11

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: b2g18_v1_0_1 patch

Comment 12

[Joe Cheng [:jcheng] (please needinfo)]

tef- for now until tef release partner confirms this is blocking BT cert.

Comment 13

[Daniel Coloma:dcoloma]

Seems it is confirmed it blocks BT cer as per bug 868347

Comment 14

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: b2g18_v1_0_1 patch

v1.0.1 patch updated.

Comment 15

[Gina Yeh [:gyeh] [:ginayeh]]

Ryan, I've updated all patches. Please land them in the following order, thanks.

01. bug827204
02. bug827255
(03. bug823346 has been landed on v1.0.1)
04. bug827230
05. bug828798
06. bug827212, patch 1
06. bug827212, patch 2
07. bug827266
08. bug828175
09. bug846647
10. bug825861
11. bug825851
12. bug835740

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/307241419d2f