827282 - [Call Forwarding] Settings app shows out of sync info about CF if this has been set via MMI.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Fernando Jiménez Moreno [:ferjm]]

As mentioned in https://bugzilla.mozilla.org/show_bug.cgi?id=824801#c0 :

"Settings app does not query for call forwarding status every time the user enters the "Call Settings" menu. So, if the call forwarding was enabled through MMI code then the UI settings goes out of sync with the network call forwarding settings."

Comment 1

[Maria Angeles Oteo (:oteo)]

As commented in Bug 827280, we need to align the CF behaviour in settings and with MMI codes as now it's not being properly updated.
This bug, together with Bug 827280, will complete the final solution to this important problem that we need to fix.

Comment 2

[Alex Keybl [:akeybl]]

Same question as https://bugzilla.mozilla.org/show_bug.cgi?id=827280#c5

Comment 3

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Alex Keybl [:akeybl] from comment #2)
> Same question as https://bugzilla.mozilla.org/show_bug.cgi?id=827280#c5

See answer here https://bugzilla.mozilla.org/show_bug.cgi?id=827280#c6 please.

Comment 4

[Maria Angeles Oteo (:oteo)]

Steps to reproduce:
With a Unagi device with a SIM card without CF functionality activated.
1. Open Settings
2. Open the Dialer and enter the digits: **21*<Telephonenumbertobeforwardedto># 
3. Click on the green button. 
4. CF is activated (confirmed through "Message succesfully sent")
5. Go to settings (alreday opened)
6. Go to Call settings menu

Expected Result
----------------
Call forwarded options are retrieved from the network and indicates always forward on the number enetered in step 2.

Current Result
---------------
Call forwarded options are NOT UPADTED

Comment 5

[José Antonio Olivera Ortega [:jaoo]]

Attachment: Pointer to Github WIP branch: https://github.com/jaoo/gaia/tree/827282

Code is ready to review and also ready to land. I'll wait for tracking-b2g18 approval before going ahead and making the PR.

Comment 6

[José Antonio Olivera Ortega [:jaoo]]

Attachment: Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/7703

Comment 7

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 704466 [details]
Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/7703

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 803533 
User impact if declined: If the call forwarding was enabled through MMI code then the UI settings goes out of sync with the network call forwarding settings.
Testing completed: Yes. 
Risk to taking this patch (and alternatives if risky): The settings apps could show wrong information about call forwarding state.

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 704466 [details]
Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/7703

Does nit seems to happens often enough to take the risk to land it in v1.

Comment 9

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 704466 [details]
Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/7703

Vivien, Kaze is PTO. Could you take a look at this PR please?. Thx!.

Comment 10

[José Antonio Olivera Ortega [:jaoo]]

https://github.com/mozilla-b2g/gaia/commit/10e50be43930348496378947fa5698f30bb99d34

Comment 11

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted commit 10e50be43930348496378947fa5698f30bb99d34 as:
v1-train: 78bf0382d2665f779079349a1fe1a4dd43a42417

Comment 12

[José Antonio Olivera Ortega [:jaoo]]

This bug is not really blocking bug 862031. Deleting it.

Comment 13

[José Antonio Olivera Ortega [:jaoo]]

Noming for tef+, it blocks bug 857691.

Comment 14

[James Lal [:lightsofapollo]]

v1-train: d5c25ace466dd56a941846bfd1b778ea8b7c376f

Comment 15

[José Antonio Olivera Ortega [:jaoo]]

(In reply to James Lal [:lightsofapollo] from comment #14)
> v1-train: d5c25ace466dd56a941846bfd1b778ea8b7c376f

v1.0.1: d5c25ace466dd56a941846bfd1b778ea8b7c376f

Comment 16

[rafael.marquez]

Bug Solved with:
build: 20130426093145 
Ril: LINUX_GECKO_ICS_STRAWBERRY_V1.01.00.01.019.085
Device: Inari

Comment 17

[Sarah Parsons]

Verified fixed on Unagi Build ID: 20130430070204

Environmental  Variables:
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/8ca8149ce236
Gaia: b525c25063d33d2e073d9f3e1e1164fadefec998

Also verified fixed on Inari Build ID: 20130430070201

Environmental  Variables:
Kernel Date: Feb 21
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/010498e599a7
Gaia: de0f1fc6c58616b8a33fca482f1f8684d4e74e9e

Call forwarding works correctly.