828146 - Scrollbar Visual Glitch ( regardless of the HWA on/off).

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Adam Frisby]

Attachment: scrollbar.png

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:21.0) Gecko/20130108 Firefox/21.0
Build ID: 20130108033457

Steps to reproduce:

Have HW Acceleration enabled
Have Flash plugin installed and enabled (I'm on version 11.6.602.108)

Open this page in a new tab: https://github.com/ataranto/CefSharp
Open this page in a second tab: https://groups.google.com/forum/#!forum/cefsharp
Scroll down the page in the second tab


Actual results:

Scrollbar visually glitches


Expected results:

Scrollbar does not visually glitch

Comment 1

[Adam Frisby]

Attachment: Test case

Comment 2

[Adam Frisby]

I attached the most simplified html file I could still reproduces the bug.

Revised steps to reproduce:

Have HW Acceleration enabled
Have Flash plugin installed and enabled (I'm on version 11.6.602.108)

Open any page with flash content (e.g. Youtube) in one tab
Open Test Case html file in second tab
Scroll down the Test Case page

Comment 3

[Adam Frisby]

Sorry to keep replying.

With the test case I uploaded the glitch occurs for me both with or without HW acceleration enabled as well as without the flash tab being loaded. I have no idea whats happening.

Revised steps to reproduce:

Open Test Case html file
Scroll down the page

Comment 4

[Adam Frisby]

Also the original test case also works with Silverlight or Java. Load a webpage that has silverlight content (I used netflix) or load a page with a java applet and the visual glitch is present on the google groups page.

Comment 5

[Alice0775 White]

Regression range with comment#1 testcase

The problem happens regardless of the HWA on/off.
And It happens in Windows7 Aero and AeroBasic, but not in Windows7 Classic.

Regression window(m-c)
Good:
http://hg.mozilla.org/mozilla-central/rev/58ebb638a7ea
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:19.0) Gecko/19.0 Firefox/19.0 ID:20121115172150
Bad:
http://hg.mozilla.org/mozilla-central/rev/a7ed19f7d21a
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:19.0) Gecko/19.0 Firefox/19.0 ID:20121116090659
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=58ebb638a7ea&tochange=a7ed19f7d21a


Regression window(m-i)
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/244493403e89
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:19.0) Gecko/19.0 Firefox/19.0 ID:20121115151651
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/2c2c6ddb6fe6
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:19.0) Gecko/19.0 Firefox/19.0 ID:20121115163151
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=244493403e89&tochange=2c2c6ddb6fe6


In local build:
Last Good: a3ea6aa33de6
First Bad: 76e6feedd0d6

Triggered by:
76e6feedd0d6	Robert O'Callahan — Bug 810470. Part 2: Change nsDisplayBackground invalidation to store and compare the background positioning rect. r=mattwoodrow


Regression window(aurora-channel)
Good:
http://hg.mozilla.org/releases/mozilla-aurora/rev/51b78d081436
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/18.0 Firefox/18.0 ID:20121119014404
Bad:
http://hg.mozilla.org/releases/mozilla-aurora/rev/f0833ab13aef
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/18.0 Firefox/18.0 ID:20121119025204
Pushlog:
http://hg.mozilla.org/releases/mozilla-aurora/pushloghtml?fromchange=51b78d081436&tochange=f0833ab13aef

Comment 6

[Alex Keybl [:akeybl]]

roc - if you're able to find a low risk fix here, we'd be happy to uplift. The user impact is not great enough to track for release though.

Comment 9

[mjh563]

Bug 832075 is similar to this, but I'm not sure if it's an exact duplicate.

Comment 11

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: somewhat simpler testcase

Comment 12

[Robert O'Callahan (:roc) (email my personal email if necessary)]

You need to shift-reload to get that testcase to work. Not sure why.

Comment 13

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Comment 14

[Robert O'Callahan (:roc) (email my personal email if necessary)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d7f45e033103

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d7f45e033103

Comment 16

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 708455 [details] [diff] [review]
fix

[Approval Request Comment]
Bug caused by (feature/regressing bug #): DLBI
User impact if declined: Corrupt scrollbar drawing (and possibly corrupt drawing of other native-themed content)
Testing completed (on m-c, etc.): landed
Risk to taking this patch (and alternatives if risky): low risk patch. Just makes us invalidate more for themed content.
String or UUID changes made by this patch: none

Comment 17

[Alex Keybl [:akeybl]]

Comment on attachment 708455 [details] [diff] [review]
fix

Approving for Aurora, but it's too late for non-critical change on Beta at this point.

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0492f5009464

Comment 20

[Maria Grazia Alastra [:mga]]

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:21.0) Gecko/20100101 Firefox/21.0

Verified on Firefox 21.0b5, on Windows 7, 64 bits using the two provided testcases.