832679 - AppMenu: Menu checkmarks indicating if {Folder pane} or {Message Pane} are shown or hidden work the wrong way round (Options > Layout)

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, defect)

Description

[Mihovil Stanic [:Mikeyy - L10n HR]]

TB 17.0.2, Win7 64bit, croatian locale

Make sure you have "CLASSIC VIEW" and folder and message panes showing on you TB.

Click:
APP MENU BUTTON / OPTIONS / LAYOUT

Take a look at 2 last options:
Folder Pane
Message Pane

You will not see any marks that those 2 are turned on (if you have them visible, which is default for TB).

If you press ALT to show old menu, then go VIEW / LAYOUT, you will see that those same 2 last options have been marked as turned ON, which wasn't case in APP BUTTON menu.

Comment 1

[Thomas D. (:thomas8)]

confirming on winxp/tb17.02, exactly as described.

The inital state of the checkmarks is wrong, hence the get toggled the wrong way round:

- no checkmarks when Panes are shown (wrong)
- checkmarks when Panes are hidden (wrong)

:Paenglab, this should be a simple fix, suppose you could just copy the logic from the traditional menu where respective checkmarks work correctly.

Comment 2

[Thomas D. (:thomas8)]

(In reply to Thomas D. from comment #1)
> confirming on winxp/tb17.02, exactly as described.
> 
> The inital state of the checkmarks is wrong, hence the get toggled the wrong
> way round:
> 
> - no checkmarks when Panes are shown (wrong)
> - checkmarks when Panes are hidden (wrong)
> 
> :Paenglab, this should be a simple fix, suppose you could just copy the
> logic from the traditional menu where respective checkmarks work correctly.

^^

Comment 3

[Richard Marti (:Paenglab)]

Attachment: patch

Adding the main menu logic to the menuitems in AppMenu.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 704303 [details] [diff] [review]
patch

Review of attachment 704303 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delay - looks good!

Comment 5

[Richard Marti (:Paenglab)]

Comment on attachment 704303 [details] [diff] [review]
patch

[Approval Request Comment]
This would make the checkmark behavior of this menuitems correct in AppMenu. The patch is only a code copy from main menu to the new items and shouldn't add new issues.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/d747857f2d0d

Comment 7

[Mark Banner (:standard8)]

Comment on attachment 704303 [details] [diff] [review]
patch

Already in 21, so a=me for beta & esr17.

Comment 8

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/comm-beta/rev/50baa2d11e83

Comment 9

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/comm-esr17/rev/07c9411e48ef