New app menu doesn't list keyboard shortcuts next to menu items

RESOLVED FIXED in Thunderbird 20.0

Status

defect
--
major
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Mikeyy, Assigned: Paenglab)

Tracking

(Blocks 2 bugs)

17 Branch
Thunderbird 20.0
Dependency tree / graph

Thunderbird Tracking Flags

(thunderbird17 wontfix, thunderbird18 fixed, thunderbird19 fixed, thunderbird20 fixed, thunderbird-esr17 fixed)

Details

Attachments

(1 attachment)

New menu doesn't list access key next to menu item.
They are only listed in old menu which is now hidden.

New users will have hard time finding out which access key is for what if he/she doesn't discover old menu.
Blocks: 789883
Changed importance to minor, was set to major by mistake.
Severity: major → minor

Comment 2

7 years ago
I'm not a big fan of app menu, but surely we should continue to mention the keyboard shortcuts for individual commands in that menu, especially if app menu is meant to become default UI. We really can't expect users to dig into the old menu for finding out about the keyboard shortcuts, and notwithstanding the goodness of existing keyboard shortcuts documentation, having in-product, contextual reference of keyboard shortcuts is far superior to that.

Firefox also lists keyboard shortcuts in their current app menu.

If there are any aesthetical concerns, we could move keyboard shortcuts into tooltips.
Severity: minor → normal
Summary: New menu doesn't list access key next to menu item → New app menu doesn't list keyboard shortcuts next to menu items

Comment 3

7 years ago
This might have been done on purpose for the two-column main app menu to not overcrowd it, but most of its items open submenus anyway and thus don't have a shortcut. However, the appearances of those secondary submenus are identical to any other menu, and hence at least those should have the related keyboard shortcuts listed.
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows 7 → All
Hardware: x86_64 → All

Comment 4

7 years ago
To be more specific, the "Edit" and "Save As" submenus already list keyboard shortcuts, others like "Message" don't.

Comment 5

7 years ago
Richard, any reason why keyboard shortcuts did not survive in your new AppMenu (Bug 650170)?

Imho, removing virtually all in-product documentation of keyboard shortcuts (with default settings, i.e. no traditional menu bar), is a major issue.
More so because keyboard shortcuts can be expected to become *more* relevant now that the traditional menu is gone by default.

This should be a straightforward fix, and please let's have this sooner rather than later - we can even lose new customers if they assume from looking at our default AppMenu that there is almost no keyboard shortcuts support in TB.
Severity: normal → major

Comment 6

7 years ago
Worse, new users not knowing the shortcut keys but hitting them accidentally will be very confused and have a hard time to find out what's going on - like hitting A with a message selected (see also bug 511741).
Assignee

Comment 7

7 years ago
Posted patch proposed fixSplinter Review
This patch adds all available shortcuts in AppMenu submenus.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #684960 - Flags: review?(mconley)

Comment 8

7 years ago
Richard, thanks a lot for the rapid patch, that's great! :)
Comment on attachment 684960 [details] [diff] [review]
proposed fix

Review of attachment 684960 [details] [diff] [review]:
-----------------------------------------------------------------

I'm happy with this - thanks Richard!
Attachment #684960 - Flags: review?(mconley) → review+
Assignee

Updated

7 years ago
Keywords: checkin-needed
Assignee

Comment 10

7 years ago
Comment on attachment 684960 [details] [diff] [review]
proposed fix

[Approval Request Comment]
I'm not sure if this should land on TB 17. But this could help for the acceptance of the AppMenu.
I think this is low risk as it only adds key shortcuts and changes no program logic.
Attachment #684960 - Flags: approval-comm-esr17?
Attachment #684960 - Flags: approval-comm-beta?
Attachment #684960 - Flags: approval-comm-aurora?

Comment 11

7 years ago
(In reply to Richard Marti [:Paenglab] from comment #10)
> Comment on attachment 684960 [details] [diff] [review]
> proposed fix
> 
> [Approval Request Comment]
> I'm not sure if this should land on TB 17. But this could help for the
> acceptance of the AppMenu.
> I think this is low risk as it only adds key shortcuts and changes no
> program logic.

+1, absolutely, to both: It should land on TB17 because
* it is vital for the acceptance of AppMenu (we can only tuck things away insofar it's easy to reach them in other ways)
* it's absolutely no-risk because it just adds existing strings to some menus
https://hg.mozilla.org/comm-central/rev/b439022b1aa1
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 20.0
Attachment #684960 - Flags: approval-comm-esr17?
Attachment #684960 - Flags: approval-comm-esr17+
Attachment #684960 - Flags: approval-comm-beta?
Attachment #684960 - Flags: approval-comm-beta+
Attachment #684960 - Flags: approval-comm-aurora?
Attachment #684960 - Flags: approval-comm-aurora+

Comment 13

7 years ago
If I understand comment 12 correctly, this has only been checked into comm-central (Daily/Trunk) so far. So 3 further checkins are needed given we now have
approval-comm-esr17+
approval-comm-beta+
approval-comm-aurora+
Keywords: checkin-needed
Depends on: 832679
No longer depends on: 832679
You need to log in before you can comment on or make changes to this bug.