If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

[B2G][SMS] The SIM PIN prompt is not displayed when going into SMS app, after canceled on the unlock screen.

VERIFIED FIXED

Status

Firefox OS
Gaia::SMS
VERIFIED FIXED
5 years ago
3 years ago

People

(Reporter: Darren, Assigned: mihai)

Tracking

unspecified
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(blocking-b2g:tef+, b2g18+ verified, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 verified)

Details

(Whiteboard: testrun 5.1 [TD-10275], leorun1)

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Repro Steps:
1. Load the Unagi build 20130125070201.
2. Go to the settings app.
3. Select SIM security and turn on the SIM PIN.
4. Restart the device.
5. When unlocking the device cancel the SIM PIN with the "X" button in the top left.
6. Open the SMS app.

Actual Results:
The SIM PIN prompt does not display.

Expected Results:
When the SIM PIN prompt is canceled on the unlock screen the prompt will display again when entering the SMS app.

Notes:
Build ID: 20130125070201
Kernel: Dec 5
Gecko:  http://hg.mozilla.org/releases/mozilla-b2g18/rev/94a2d6fcdfde
Gaia:   6369dbf33b622faf4b4d176fed30b77c5c319dfc

Repro rate-
4/4 on one device
(Reporter)

Comment 1

5 years ago
UCID: set-207
Test Case: #4530
https://moztrap.mozilla.org/runtests/run/702/env/296/?pagenumber=1&pagesize=20&sortfield=order&sortdirection=asc&filter-tag=450
bug 835972 , bug 835970 , bug 835968, bug 835967 I believe are all the same underlying issue where if you cancel the sim pin the prompt doesn't come up any more.

I am only going to nom this one.  It's bad.  We should show a prompt if we try to dial or do sms...  else you have to reboot your phone each time you cancel.
blocking-b2g: --- → tef?
status-b2g18-v1.0.0: --- → affected
tracking-b2g18: --- → ?
Daren what happens after that ? Does SMS is usable ? Does SMS prompts a message "SIM locked" ?
Flags: needinfo?(dwatson)
(Reporter)

Comment 4

5 years ago
There is no SIM PIN screen while in the SMS and you are not able to send one.
Flags: needinfo?(dwatson)
Since this is not a certification blocker, we would ship with this unfortunate experience but it does have a workaround (reboot).
blocking-b2g: tef? → -
status-b2g18: --- → affected
tracking-b2g18: ? → +
Batch edit: Bugs marked status-b2g18: affected after 2/13 branching of v1.0.1 are now also status-b2g18-v1.0.1: affected
status-b2g18-v1.0.1: --- → affected
Repros in Unagi version 20130225070200.
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/3a5a27992a75
Gaia: 5691a16fff8e1403c75ed9d6f3a443b7e58198c6
Kernel Date: Dec 5
Test Suite: SIM Security
UCID: Set-207
https://moztrap.mozilla.org/runtests/run/859/env/305/?pagenumber=1&pagesize=50&sortfield=order&sortdirection=asc&filter-id=4530&filter-suite=157
Whiteboard: testrun 3 → testrun 5.1

Comment 8

5 years ago
in reference to Comment 7

Test Case # 4530
Test Suite: SIM Security
UCID: Set-207

https://moztrap.mozilla.org/manage/cases/?pagenumber=1&pagesize=20&sortfield=created_on&sortdirection=desc&filter-id=4530
(Assignee)

Updated

5 years ago
Assignee: nobody → mihai
Created attachment 732801 [details]
Pull Request #8967 - Display SIM PIN dialog for apps that require a mobile connection

This patch also fixes Bug 835967 (Dialer), Bug 846563 (Contacts), Bug 846574 (Settings).
Attachment #732801 - Flags: review?(etienne)
(Assignee)

Updated

5 years ago
Attachment #732801 - Attachment filename: file_835972.txt → file_835972.html
Attachment #732801 - Attachment mime type: text/plain → text/html
Comment on attachment 732801 [details]
Pull Request #8967 - Display SIM PIN dialog for apps that require a mobile connection

This looks like a regression, let's try to understand why it regressed.

It looks like since the 'appwillopen' custom event is dispatch from the the app "frame container" and not the app iframe, evt.target is not what we want here.

Actually dispatching the event from |app.iframe| instead of |app.frame| (a one character patch ;)) apparently fixes the issue.
Attachment #732801 - Flags: review?(etienne) → review-
Comment on attachment 732801 [details]
Pull Request #8967 - Display SIM PIN dialog for apps that require a mobile connection

Updated the patch! Thanks for pointing out the regression, Etienne :) it was very weird that the manifestURL was not defined in the event.target.
Attachment #732801 - Flags: review- → review?(etienne)
Attachment #732801 - Flags: review?(etienne) → review+
https://github.com/mozilla-b2g/gaia/commit/b126eeb39ed9bfa1e5662386f74611d5d6527b18
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Comment on attachment 732801 [details]
Pull Request #8967 - Display SIM PIN dialog for apps that require a mobile connection

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Window Manager (regression)
User impact if declined: Medium
Testing completed: Yes
Risk to taking this patch (and alternatives if risky): Low/None
String or UUID changes made by this patch: No
Attachment #732801 - Flags: approval-gaia-v1?
Attachment #732801 - Flags: approval-gaia-v1? → approval-gaia-v1+
Keywords: verifyme
I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 b126eeb39ed9bfa1e5662386f74611d5d6527b18
  <RESOLVE MERGE CONFLICTS>
  git commit
(In reply to Mihai Cirlanaru [:mcirlanaru] from comment #11)
> Comment on attachment 732801 [details]
> Pull Request #8967 - Display SIM PIN dialog for apps that require a mobile
> connection
> 
> Updated the patch! Thanks for pointing out the regression, Etienne :) it was
> very weird that the manifestURL was not defined in the event.target.

I think another way is using |evt.detail.origin| because it's the same as |evt.target.dataset.frameOrigin| here.
Using manifestURL isn't just the solution because we have entry-point apps(commnucations) which shares the same manifestURL.
Duplicate of this bug: 859583
(In reply to John Ford [:jhford] -- If you expect a reply from me, use needsinfo? instead of CC from comment #14)
> I was not able to uplift this bug to v1-train.  If this bug has dependencies
> which are not marked in this bug, please comment on this bug.  If this bug
> depends on patches that aren't approved for v1-train, we need to re-evaluate
> the approval.  

Hi John, apparently the merge conflict comes from apps/system/js/sim_lock.js which differs from master in checking if the FTU is running. The changes my patch adds to sim_lock.js are simply comment style related and not necessarily relevant to the fix (i.e. window_manager.js is where the fix is).

> Otherwise, if this is just a merge conflict, you might be
> able to resolve it with:
> 
>   git checkout v1-train
>   git cherry-pick -x -m1 b126eeb39ed9bfa1e5662386f74611d5d6527b18
>   <RESOLVE MERGE CONFLICTS>
>   git commit

Should I simply 'git push' after fixing the merge conflict on v1-train?
Flags: needinfo?(jhford)
(In reply to Alive Kuo [:alive] from comment #15)
> (In reply to Mihai Cirlanaru [:mcirlanaru] from comment #11)
> > Comment on attachment 732801 [details]
> > Pull Request #8967 - Display SIM PIN dialog for apps that require a mobile
> > connection
> > 
> > Updated the patch! Thanks for pointing out the regression, Etienne :) it was
> > very weird that the manifestURL was not defined in the event.target.
> 
> I think another way is using |evt.detail.origin| because it's the same as
> |evt.target.dataset.frameOrigin| here.
> Using manifestURL isn't just the solution because we have entry-point
> apps(commnucations) which shares the same manifestURL.

Thanks for pointing this out, Alive. In my initial commit I was using 'evt.detail.origin', but since the fix proved to be in window_manager.js, I reverted the changes to sim_lock.js (left only some comment style updates).
(In reply to Mihai Cirlanaru [:mcirlanaru] from comment #17)
> (In reply to John Ford [:jhford] -- If you expect a reply from me, use
> needsinfo? instead of CC from comment #14)
> > I was not able to uplift this bug to v1-train.  If this bug has dependencies
> > which are not marked in this bug, please comment on this bug.  If this bug
> > depends on patches that aren't approved for v1-train, we need to re-evaluate
> > the approval.  
> 
> Hi John, apparently the merge conflict comes from apps/system/js/sim_lock.js
> which differs from master in checking if the FTU is running. The changes my
> patch adds to sim_lock.js are simply comment style related and not
> necessarily relevant to the fix (i.e. window_manager.js is where the fix is).
> 
> > Otherwise, if this is just a merge conflict, you might be
> > able to resolve it with:
> > 
> >   git checkout v1-train
> >   git cherry-pick -x -m1 b126eeb39ed9bfa1e5662386f74611d5d6527b18
> >   <RESOLVE MERGE CONFLICTS>
> >   git commit
> 
> Should I simply 'git push' after fixing the merge conflict on v1-train?

Be careful when you directly push anything!
If it's me, I will use another pull request for a patch over another branch.
PROS:
1. It would run travis again on the pull request if you modify sth.
2. Safer than directly push.

Maybe John has other thought.
John, I submitted another pull request with the corrected merge conflict:
https://github.com/mozilla-b2g/gaia/pull/9149

Feel free to merge it to v1-train. Thanks!
v1-train: 30620a3a7aff89b603a73a0265b668479955aa50
status-b2g18: affected → fixed
Flags: needinfo?(jhford)
Duplicate of this bug: 859583

Updated

5 years ago
Whiteboard: testrun 5.1 → testrun 5.1 [TD-10275]

Updated

5 years ago
Whiteboard: testrun 5.1 [TD-10275] → testrun 5.1 [TD-10275], leorun1
Blocks: 853769

Updated

5 years ago
blocking-b2g: - → tef+

Updated

5 years ago
Duplicate of this bug: 853769
v1.0.1: ba7ea5e3171486a80e964ad6e3af2e76caef0b97
status-b2g18-v1.0.0: affected → wontfix
status-b2g18-v1.0.1: affected → fixed

Comment 25

4 years ago
Verified fixed on 

Inari Build ID: 20130503070205
Kernel Date: Feb 21
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/3f3489356bbc
Gaia: 3e232bce289c9e156d92553e752616cba284bc8f

and on 

Unagi Build ID: 20130503070204
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/8becaf2a0bc7
Gaia: b0aca0dd1e2955e11190ede725e1fb9ee596438b

There is now a request for the sim pin number when going into SMS if you have not already verified the pin.
Status: RESOLVED → VERIFIED
status-b2g18: fixed → verified
status-b2g18-v1.0.1: fixed → verified
Keywords: verifyme
Per comment 25,I clear "Verifyme".
You need to log in before you can comment on or make changes to this bug.