Closed Bug 83968 Opened 20 years ago Closed 16 years ago

Ability to specify whether to search online or offline

Categories

(SeaMonkey :: MailNews: Message Display, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey1.0alpha

People

(Reporter: bugzilla, Assigned: neil)

References

Details

Attachments

(1 file, 2 obsolete files)

A newsserver like msnews.microsoft.com doesn't support search. In cases like 
this it could be nice to be able to specify if you like search online (sending 
XPAT) or search offline (searching in mork data)

Currently the only way to search in offline data, is to switch to offline mode 
before searching. Now a very easy way...:)
mass re-assign.
Assignee: naving → sspitzer
This is a dup of Bug 210784
No, it's not, it isn't even dependent.
The XPAT search bug just made this bug visible. ;-)
Severity: normal → enhancement
Summary: Ability to specify wheather to search online or offline → Ability to specify whether to search online or offline
*** Bug 92746 has been marked as a duplicate of this bug. ***
Attached patch Proposed patch (obsolete) — Splinter Review
Assignee: sspitzer → neil.parkwaycc.co.uk
Status: NEW → ASSIGNED
Attachment #163616 - Flags: superreview?(mscott)
Attachment #163616 - Flags: review?(bienvenu)
Comment on attachment 163616 [details] [diff] [review]
Proposed patch

great, thx!
Attachment #163616 - Flags: review?(bienvenu) → review+
Product: Browser → Seamonkey
There is a patch... any chances to see it checked in?
Flags: blocking1.8a6?
Attachment #163616 - Flags: superreview?(mscott) → superreview?(dmose)
Flags: blocking1.8a6? → blocking1.8a6-
Comment on attachment 163616 [details] [diff] [review]
Proposed patch

I don't know where the checkbox belongs in TB as it has no help button.
Attachment #163616 - Flags: superreview?(dmose) → superreview?(mscott)
(This bug is a followup to bug 47857.)

This bug can be useful for IMAP too: see bug 299229.
Attached patch Non-TB-breaking-patch (I hope) (obsolete) — Splinter Review
Attachment #163616 - Attachment is obsolete: true
Attachment #187886 - Flags: superreview?(bienvenu)
Attachment #187886 - Flags: review?(mnyromyr)
Comment on attachment 187886 [details] [diff] [review]
Non-TB-breaking-patch (I hope)

those files are all forked for thunderbird, so we should be OK there. 

You might want to disable the checkbox if the network state is offline, since,
in that case, we're going to search offline anyway.
Attachment #187886 - Flags: superreview?(bienvenu) → superreview+
Attachment #163616 - Flags: superreview?(mscott)
Comment on attachment 187886 [details] [diff] [review]
Non-TB-breaking-patch (I hope)

It's somewhat surprising to see the checkmark unmarked in the case when the
network is off and you actually _can_ only search your local system, but that's
owned to the checkbox' persistence. So the question is whether it is useful at
all to persist the checkmark state _globally_.
Attachment #187886 - Flags: review?(mnyromyr) → review+
Attachment #187886 - Attachment is obsolete: true
Attachment #188069 - Flags: superreview?(bienvenu)
Attachment #188069 - Flags: review+
Comment on attachment 188069 [details] [diff] [review]
Really-non-TB-breaking-patch (I hope)
[Checked in: Comment 15]

that works much better.
Attachment #188069 - Flags: superreview?(bienvenu) → superreview+
Attachment #188069 - Flags: approval1.8b3?
Attachment #188069 - Flags: approval1.8b3? → approval1.8b3+
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Attachment #188069 - Attachment description: Really-non-TB-breaking-patch (I hope) → Really-non-TB-breaking-patch (I hope) [Checked in: Comment 15]
(In reply to comment #12)
> (From update of attachment 187886 [details] [diff] [review] [edit])
> It's somewhat surprising to see the checkmark unmarked in the case when the
> network is off and you actually _can_ only search your local system, but that's
> owned to the checkbox' persistence. So the question is whether it is useful at
> all to persist the checkmark state _globally_. 

1) Same feeling here;
2) and the fact that the check box does not respond to going online/offline
while the Search window is opened

3) UI-wise, I wonder if the two checkboxes could be on the same line !?
Target Milestone: --- → Seamonkey1.0alpha
Blocks: 314966
Component: MailNews: Search → MailNews: Message Display
QA Contact: laurel → search
You need to log in before you can comment on or make changes to this bug.