842462 - B2G RIL: Support Facility Lock for Fixed Dialling

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

See TS 27.007, clause 7.4 for "Facility Lock"

"FD" SIM card or active application in the UICC (GSM or USIM) fixed dialling memory feature (if PIN2 authentication has not been done during the current session, PIN2 is required as <passwd>)"

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 1: Update IDL comments.

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 2: Facility Lock for FDN implementations.

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Currently emulator doesn't support Facility Lock, once it's supported the marionette test should be covered in Bug 756375

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 3: xpcshell for Facility Lock of FDN.

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 3: xpcshell for Facility Lock of FDN. v2.

add comments.

Comment 6

[Hsin-Yi Tsai (she/her) | away [:hsinyi]]

Comment on attachment 715431 [details] [diff] [review]
Part 1: Update IDL comments.

Review of attachment 715431 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/network/interfaces/nsIDOMMobileConnection.idl
@@ +151,5 @@
>     * (1) Unlocking failed:
>     *
>     *     {
>     *       lockType:   "pin",
> +   *       success     false,

nit: A colon was missing after 'success'

Comment 7

[Hsin-Yi Tsai (she/her) | away [:hsinyi]]

Comment on attachment 715895 [details] [diff] [review]
Part 3: xpcshell for Facility Lock of FDN. v2.

Review of attachment 715895 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/tests/test_ril_worker_icc.js
@@ +523,5 @@
> +
> +    // String Array Length.
> +    do_check_eq(this.readUint32(), 4);
> +
> +    // facility.

nit: s/f/F

@@ +526,5 @@
> +
> +    // facility.
> +    do_check_eq(this.readString(), ICC_CB_FACILITY_FDN);
> +
> +    // password.

nit: s/p/P

@@ +529,5 @@
> +
> +    // password.
> +    do_check_eq(this.readString(), "");
> +
> +    // service class.

nit: s/s/S

@@ +534,5 @@
> +    do_check_eq(this.readString(), (ICC_SERVICE_CLASS_VOICE |
> +                                    ICC_SERVICE_CLASS_DATA  |
> +                                    ICC_SERVICE_CLASS_FAX).toString());
> +
> +    // aid. Ignore because it's from modem.

nit: s/aid/AID value

Comment 8

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 1: Update IDL comments. v2

addressed nits.

Comment 9

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 3: xpcshell for Facility Lock of FDN. v3

nits addressed.

Comment 10

[Mozilla RelEng Bot]

Try run for ca0f1075bb4c is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=ca0f1075bb4c
Results (out of 5 total builds):
    success: 5
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-ca0f1075bb4c

Comment 11

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cfd2d5547cd6
https://hg.mozilla.org/integration/mozilla-inbound/rev/0c35665323e9
https://hg.mozilla.org/integration/mozilla-inbound/rev/de2bb5efa079

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cfd2d5547cd6
https://hg.mozilla.org/mozilla-central/rev/0c35665323e9
https://hg.mozilla.org/mozilla-central/rev/de2bb5efa079

Comment 14

[Joe Cheng [:jcheng] (please needinfo)]

listed as must have in v1.2 for COMM team. koi+