844471 - In landscape orientation, menu not appearing when clicked yet accepts touches

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Paul [pwd]]

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:21.0) Gecko/20130219 Firefox/21.0
Build ID: 20130219031055

Steps to reproduce:

So occasionally, I'm getting this. I'll go to a site, and attempt to open the menu. Nothing will happen, so I'll attempt again, only to be told "Bookmark Added". I'll grab a logcat next time I see it.

Comment 1

[Aaron Train [:aaronmt]]

I just hit this after rotating my device and accessing the menu; the menu did not appear and when I hit the menu button again, I got "Bookmark Added".

Comment 2

[Aaron Train [:aaronmt]]

Showed this to Lucas he thinks it might be a visibility thing + an offset issue; you can tap anywhere below where the menu should be in content after invoking the menu and have any item selected. In any case, he thinks it's a Sriram issue :)

Comment 3

[Aaron Train [:aaronmt]]

Catalin, can you get a regression range from either late Jan or early Feb?

Comment 4

[Catalin Suciu [:csuciu]]

good build: 20.01.2013
bad build: 21.01.2013

pushlog:http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=01a8559f5560&tochange=01c964705be7

Comment 5

[Aaron Train [:aaronmt]]

My money is on bug 831402 with that custom-menu patch in there even though there are over 250 change-sets in the above pushlog.

Comment 6

[Aaron Train [:aaronmt]]

Also bug 832433 is there too

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Sriram - This is a bug on Beta (Fx20). Can we get some movement on it?

Comment 11

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch: Nightly+

We wanted to position the MenuPopup over an anchor. In that calcuation, I had missed checking if there is enough space above the anchor. Which caused the problem in landscape mode. (Basically I checked "if there is no enough space at the bottom without shrinking, show above the anchor").

This patch fixes it (and won't affect the menu in beta).

Comment 12

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch: Nightly only

This patch cleanups the code for Nightly only. We kills the tabs-ui menu on nightly, and can cleanup the code by restricting it to show only "below" the anchor.

Comment 13

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/078256713f76
https://hg.mozilla.org/integration/mozilla-inbound/rev/6f57d1e1a4ee

Comment 14

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 723614 [details] [diff] [review]
Patch: Nightly+

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Tabs-UI Menu.
User impact if declined: Menu won't be shown in landscape mode.
Testing completed (on m-c, etc.): Landed in m-i yesterday.
Risk to taking this patch (and alternatives if risky): Very less. This adds a proper check.
String or UUID changes made by this patch: None.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/078256713f76
https://hg.mozilla.org/mozilla-central/rev/6f57d1e1a4ee

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/75bc2bcaee98
https://hg.mozilla.org/releases/mozilla-aurora/rev/c5f2ea8ec949

https://hg.mozilla.org/releases/mozilla-beta/rev/0d664ccc7cd7
https://hg.mozilla.org/releases/mozilla-beta/rev/2fd169e0ceed

Comment 17

[Adrian Tamas (:AdrianT)]

Verified on Aurora 21.0a2 2013-03-14 and Firefox Mobile 20 beta 5 on LG Nexus 4 (Android 4.2.2)