856823 - Turn off --enable-metro on Aurora after uplift to Aurora

Status: VERIFIED FIXED

(Firefox Build System :: General, defect)

Description

[bhavana bajaj [:bajaj]]

+++ This bug was initially created as a clone of Bug #841919 +++

Metro Firefox is currently enabled on the Nightly channel but is not yet ready for the Aurora audience.  We want to remove --enable-metro from the win32 mozconfigs on mozilla-aurora before Firefox 21 updates are published to the Aurora channel.

Comment 1

[bhavana bajaj [:bajaj]]

This has been taken care during the merge today on win32/64 builds, check changeset below for more details .

http://hg.mozilla.org/releases/mozilla-aurora/rev/bc8a6b8e0280

Adding qawanted here to get similar verification as done earlier in : https://bugzilla.mozilla.org/show_bug.cgi?id=841919#c10

Comment 2

[u279076]

I'll check this as soon as we have Firefox Aurora 22 builds.

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Should these files have been modified too ?
 browser/config/mozconfigs/win32/nightly
 browser/config/mozconfigs/win64/nightly

Comment 4

[bhavana bajaj [:bajaj]]

(In reply to Nick Thomas [:nthomas] from comment #3)
> Should these files have been modified too ?
>  browser/config/mozconfigs/win32/nightly
>  browser/config/mozconfigs/win64/nightly

nope. We are supporting metro builds on nightly, but not on aurora yet.So these should be available for nightly audience hence no modifications needed

Comment 5

[bhavana bajaj [:bajaj]]

(In reply to bhavana bajaj [:bajaj] from comment #4)
> (In reply to Nick Thomas [:nthomas] from comment #3)
> > Should these files have been modified too ?
> >  browser/config/mozconfigs/win32/nightly
> >  browser/config/mozconfigs/win64/nightly
> 
> nope. We are supporting metro builds on nightly, but not on aurora yet.So
> these should be available for nightly audience hence no modifications needed

Ignore this comment, I just realized you meant "browser/config/mozconfigs/win64/nightly" these files for aurora, got tricked into the name here..I am checking now

Comment 6

[bhavana bajaj [:bajaj]]

(In reply to Nick Thomas [:nthomas] from comment #3)
> Should these files have been modified too ?
>  browser/config/mozconfigs/win32/nightly
>  browser/config/mozconfigs/win64/nightly

Have this covered now, thanks for catching this :nthomas :)

https://hg.mozilla.org/releases/mozilla-aurora/rev/6f40920a3968

looks good now ?

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

Yes indeed.

Comment 8

[u279076]

Confirmed that Aurora 22.0a2 2013-04-03 starts with the desktop UI and not the metro UI when passed --enable-metro.

Comment 9

[Lukas Blakk [:lsblakk] use ?needinfo]

Landed on mozilla-aurora, post merge: https://hg.mozilla.org/releases/mozilla-aurora/rev/a681822e4a1c

Comment 10

[Alex Keybl [:akeybl]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/822bc5cbc8f4

Comment 11

[Simona Badau, Desktop QA]

Verified as fixed on Firefox 23 beta 7 (it starts with the desktop UI and not the metro UI).
Mozilla/5.0 (Windows NT 6.2; WOW64; rv:23.0) Gecko/20100101 Firefox/23.0
Build ID: 20130718163513

Comment 12

[Lukas Blakk [:lsblakk] use ?needinfo]

Bhavana will be doing this merge of FF25 -> Aurora so she can confirm if this will be carried forward another release or not.

Comment 13

[bhavana bajaj [:bajaj]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ede8780a15bc

This is resolved for Fx25.

Requesting QA verification here.

Comment 14

[u279076]

(In reply to bhavana bajaj [:bajaj] from comment #13)
> Requesting QA verification here.

Simona, please verify this with the Aurora 25 builds (first builds should show up tomorrow morning).

Comment 15

[Gregory Szorc [:gps]]

We have a NIGHTLY_BUILD variable that is only defined when building on the Nightly channel (or on local developer builds of central) (see bug 878291). If you have to make changes to configure flags after tree uplifts to enable/disable features, that feature didn't land properly as far as build config configuration integration is concerned. Please file bugs.

Comment 16

[Gregory Szorc [:gps]]

Someone corrected me: Metro landed before bug 878291 so it didn't land improperly. But, it is suboptimal and should be fixed. I'll clone this bug...

Comment 17

[Simona Badau, Desktop QA]

Mozilla/5.0 (Windows NT 6.2; WOW64; rv:25.0) Gecko/20100101 Firefox/25.0
Build ID: 20130806004002

Verified as fixed on the latest Aurora 25.0a2: it starts with the desktop UI and not the metro UI.

Comment 18

[Bogdan Maris, Desktop Test Engineering]

Mozilla/5.0 (Windows NT 6.2; rv:24.0) Gecko/20100101 Firefox/24.0
Mozilla/5.0 (Windows NT 6.2; rv:26.0) Gecko/20100101 Firefox/26.0

Verified as fixed on Firefox 24 beta 1 (buildID: 20130806170643) and latest Nightly (buildID: 20130806104538), both builds start with desktop UI.

Comment 19

[Lukas Blakk [:lsblakk] use ?needinfo]

Relnote (don't say "metro") and point to https://support.mozilla.org/en-US/kb/good-news-firefox-now-touch-friendly for FF26

Comment 20

[Lukas Blakk [:lsblakk] use ?needinfo]

Moving this out of FF26 tracking since we kept --enable-metro on FF26 for Aurora testing & usage (as with FF27 which is now on Aurora).