858704 - provider manifests

Status: VERIFIED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[Shane Caraveo (:mixedpuppy)]

Attachment: fx23 providers

I'll be attaching patches for the new manifests in 21/22 and 23 here.  Once I'm able to test a bit I think we'll be ready to land 22 and 23 (unfortunatly hit clobber on my build so further delayed).  Patch for 21 to follow in a while.

I'm intending to only land in the whitelist for 23, we may change that later to a full builtin manifest.  I'm doing this because I want to migrate away from builtin manifests.

Comment 1

[Shane Caraveo (:mixedpuppy)]

Attachment: fx22 providers

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 733991 [details] [diff] [review]
fx23 providers

So from 23 on, we're requiring that partners provide manifests in the activation event?

Comment 3

[Shane Caraveo (:mixedpuppy)]

(In reply to :Gavin Sharp (use [e-mail] for email) from comment #2)
> Comment on attachment 733991 [details] [diff] [review]
> fx23 providers
> 
> So from 23 on, we're requiring that partners provide manifests in the
> activation event?

Hopefully.  I want to migrate away from having to build anything provider-specific into firefox.  The first move is to get manifests from the provider or directory at activation.  That lets us move to only having the whitelist pref.  I have to coordinate that change with Facebook, which is why their full manifest is still there.

Then, we should get the whitelist dynamically from AMO/Marketplace/Something (similar to blocklist).  I dont see time to even think about that till fx24 or so.

Comment 4

[Shane Caraveo (:mixedpuppy)]

whitelist patch for fx23 landed
https://hg.mozilla.org/integration/mozilla-inbound/rev/0d93ae35f8b5

Comment 5

[Shane Caraveo (:mixedpuppy)]

I've done manual testing on Beta, Aurora and Nightly (which unfortunately found another test bug, since fixed and waiting review, bug 858868).  

Activation and use are working with the simple whitelist in Aurora and Nightly, so I've landed the whitelist on inbound.

Aurora will need the full manifest since it will be a migration version from built-in manifests to only the whitelist.  I can land the manifests right after landing the patch in bug 851936 (waiting a+).

With Beta, I've tested with the manifests built in.  Cliqz needs to update their activation page, which currently attempts to install an addon if Fx version < 22.  MSN has a different bug in their activation page which they will push the fix for on Monday (I've already gone through that with them earlier today, it is fixed and waiting deployment).  Facebook activation is working fine.

Mixi does not have their activation page available outside of Japan at this point, we will work to get access to verify activation early next week.

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/0d93ae35f8b5

Comment 7

[Shane Caraveo (:mixedpuppy)]

Attachment: fx22 providers

Comment 8

[Shane Caraveo (:mixedpuppy)]

Attachment: fx21 providers

Comment 9

[Shane Caraveo (:mixedpuppy)]

(In reply to Shane Caraveo (:mixedpuppy) from comment #8)
> Created attachment 734486 [details] [diff] [review]
> fx21 providers

https://hg.mozilla.org/releases/mozilla-beta/rev/4b40143af7b5

Comment 10

[Shane Caraveo (:mixedpuppy)]

(In reply to Shane Caraveo (:mixedpuppy) from comment #7)
> Created attachment 734484 [details] [diff] [review]
> fx22 providers

https://hg.mozilla.org/releases/mozilla-aurora/rev/431e6881926b

Comment 11

[u279076]

Firefox Nightly 23.0a1 2013-04-09
* Facebook activation works as expected
* Mixi activation not testable due to no activation page outside of Japan
* Cliqz activation works as expected
* MSN Now activation works as expected

Firefox Aurora 22.0a2 2013-04-09
* Facebook activiation works as expected
* Mixi activation not testable due to no activation page outside of Japan
* Cliqz activation works as expected
* MSN Now activation does not work, returns an error in EC about "remote install disabled"

Firefox Beta 21.0b2
* Facebook activation works as expected
* Mixi activation not testable due to no activation page outside of Japan
* Cliqz activation works as expected
* MSN Now activation works as expected

Marking this verified fixed for 21 and 23 based on above. Shane, is the MSN Now results expected on Aurora?

Comment 12

[Shane Caraveo (:mixedpuppy)]

(In reply to Anthony Hughes, Mozilla QA (:ashughes) from comment #11)

> Firefox Aurora 22.0a2 2013-04-09
> * Facebook activiation works as expected
> * Mixi activation not testable due to no activation page outside of Japan
> * Cliqz activation works as expected
> * MSN Now activation does not work, returns an error in EC about "remote
> install disabled"

sigh.  I missed fixing http->https for the msn manifest on aurora.  Activation should work if you activate from http.  I'm starting a conversation with security about using http for social providers, for now we should be using https.  I'll have to do a fix in 22 for that.

Comment 13

[u279076]

(In reply to Shane Caraveo (:mixedpuppy) from comment #12)
> (In reply to Anthony Hughes, Mozilla QA (:ashughes) from comment #11)
> 
> > Firefox Aurora 22.0a2 2013-04-09
> > * Facebook activiation works as expected
> > * Mixi activation not testable due to no activation page outside of Japan
> > * Cliqz activation works as expected
> > * MSN Now activation does not work, returns an error in EC about "remote
> > install disabled"
> 
> sigh.  I missed fixing http->https for the msn manifest on aurora. 
> Activation should work if you activate from http.

Yup, activation via HTTP works fine, activation via HTTPS does not.

Comment 14

[Shane Caraveo (:mixedpuppy)]

(In reply to Anthony Hughes, Mozilla QA (:ashughes) from comment #13)
> (In reply to Shane Caraveo (:mixedpuppy) from comment #12)

> > sigh.  I missed fixing http->https for the msn manifest on aurora. 
> > Activation should work if you activate from http.
> 
> Yup, activation via HTTP works fine, activation via HTTPS does not.

Bug 859988 to address this.

Comment 15

[u279076]

The outlier for Firefox 22 here was MSN Now. Whenever I go to http://now.msn.com/now-for-firefox I get automatically redirected to https://. It appears as though they are only allowing https activation from their site now. Activation from this site works as expected though so I'm marking this verified fixed.