Work - disable pdf.js in metro Firefox

RESOLVED FIXED in Firefox 27

Status

Firefox for Metro
Components
RESOLVED FIXED
5 years ago
3 years ago

People

(Reporter: jimm, Assigned: rsilveira)

Tracking

Trunk
Firefox 27
x86_64
Windows 8.1
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [leave closed])

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
str:
- open a multipage pdf
- try to scroll the document

result: document doesn't scroll

Comment 1

5 years ago
We should drop PDF.js support on Metro until they're a better experience than the Reader app.  I'll get a story for removing it.
Summary: pdf.sj documents can't be scrolled via touch → pdf.js documents can't be scrolled via touch

Updated

5 years ago
Summary: pdf.js documents can't be scrolled via touch → Work - disable pdf.js in metro Firefox

Updated

5 years ago
Blocks: 891594
(Reporter)

Comment 2

4 years ago
This is still broken for touch. The work here should be pretty simple.
Whiteboard: [preview]

Comment 3

4 years ago
It should be disabled for all platforms. Just a short time on the web
show that it uses too much memory
https://bugzilla.mozilla.org/show_bug.cgi?id=878397

It prints incorrectly
https://bugzilla.mozilla.org/show_bug.cgi?id=880181

and fails to render many documents on the web
https://bugzilla.mozilla.org/show_bug.cgi?id=844472

In a university setting, with many users on medium power computers
the result of trying to view pdf files is a disaster on about 10%
of all files that need to be accessed which teaching a class using technical
documents

It is a way to generate a disastrous reputation for users of firefox
I should be turned on when it works for all but a tiny proportion of documents
(Reporter)

Updated

4 years ago
Duplicate of this bug: 922323
Created attachment 813201 [details] [diff] [review]
Patch v1

Disabling pdfjs.
Assignee: nobody → rsilveira
Status: NEW → ASSIGNED
Attachment #813201 - Flags: review?(mbrubeck)
Attachment #813201 - Flags: review?(mbrubeck) → review+
https://hg.mozilla.org/integration/fx-team/rev/ca5b3cc4e7c6
https://hg.mozilla.org/mozilla-central/rev/ca5b3cc4e7c6
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 27

Updated

4 years ago
Whiteboard: [preview]
Depends on: 923594
(In reply to Asa Dotzler [:asa] from comment #1)
> We should drop PDF.js support on Metro until they're a better experience
> than the Reader app.  I'll get a story for removing it.

Hi Asa,

Can I ask that in future we more of an effort to inform the PDF.js team about issues like this? This isn't filed against our PDF Viewer component, nor was mentioned in #pdf.js IRC or in our mailing list.

Our telemetry data for other platforms suggests that PDF.js is working well for the vast majority of documents, and we're having pretty good luck with touch devices on Firefox OS, so we'd like to work with the right people to get this reenabled.

thanks,
-Bill
(Reporter)

Comment 9

4 years ago
(In reply to Bill Walker [:bwalker] [@wfwalker] from comment #8)
> (In reply to Asa Dotzler [:asa] from comment #1)
> > We should drop PDF.js support on Metro until they're a better experience
> > than the Reader app.  I'll get a story for removing it.
> 
> Hi Asa,
> 
> Can I ask that in future we more of an effort to inform the PDF.js team
> about issues like this? This isn't filed against our PDF Viewer component,
> nor was mentioned in #pdf.js IRC or in our mailing list.
> 
> Our telemetry data for other platforms suggests that PDF.js is working well
> for the vast majority of documents, and we're having pretty good luck with
> touch devices on Firefox OS, so we'd like to work with the right people to
> get this reenabled.
> 
> thanks,
> -Bill

We can reopen bug 922323 and move it to the right component so we have something to keep track of.
(In reply to Jim Mathies [:jimm] from comment #9)

> We can reopen bug 922323 and move it to the right component so we have
> something to keep track of.

Awesome, thanks Jim!

Comment 11

4 years ago
(In reply to Bill Walker [:bwalker] [@wfwalker] from comment #8)
> (In reply to Asa Dotzler [:asa] from comment #1)
> > We should drop PDF.js support on Metro until they're a better experience
> > than the Reader app.  I'll get a story for removing it.
> 
> Hi Asa,
> 
> Can I ask that in future we more of an effort to inform the PDF.js team
> about issues like this? This isn't filed against our PDF Viewer component,
> nor was mentioned in #pdf.js IRC or in our mailing list.
> 
> Our telemetry data for other platforms suggests that PDF.js is working well
> for the vast majority of documents, and we're having pretty good luck with
> touch devices on Firefox OS, so we'd like to work with the right people to
> get this reenabled.
> 
> thanks,
> -Bill

Bill, back when I was still managing this product, I made the call that we should prefer the system viewer to  our own built-in player. While I appreciate that PDF.js is making things a lot better for Firefox users, I'm not sure it's the right experience for Metro.  Metro is a tablet experience where "apps" dominate, like on phones. People don't need or want a "everything including the kitchen sink" browser on Metro. They have apps that handle so much and in a way that's very user-choice friendly.

Having said that, this is Karen's baby now and I defer to her judgement on this.
I backed out the code removal parts of this patch but left the preference change in place:
https://hg.mozilla.org/integration/fx-team/rev/c8c8831321da

This means that PDF.js is still disabled in Metro by default, but developers and testers can now easily test it in nightly Metro builds by setting "pdfjs.disabled" to "false" in about:config.
Whiteboard: [leave closed]
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.