Is it possible that you used to have the Additional Chat Protocols for Thunderbird add-on in this profile?
yes, it's disabled, but I used the Additional Chat Protocols for Thunderbird add-on with a previous version of Thunderbird in this profile.
chat should not be so fragile that an extension can leave not only chat, but all following folder account processing in a broken state.
(In reply to alta88 from comment #4) > chat should not be so fragile that an extension can leave not only chat, but > all following folder account processing in a broken state. Unfortunately given that add-ons can pretty much do anything, it is entirely possible that an add-on can break our startup & folder account display. However, in this situation, it does seem that we should be checking that value before hitting it.
(In reply to Mark Banner (:standard8) from comment #5) > Unfortunately given that add-ons can pretty much do anything, it is entirely > possible that an add-on can break our startup & folder account display. Mark, this is not really the add-on breaking startup; things work fine when the add-on is there. The problem here is that things are broken once the add-on is uninstalled. > However, in this situation, it does seem that we should be checking that > value before hitting it. We likely just need a null check or a try/catch somewhere. I'm sure I tested and fixed this specific case last year, so this seems to me like a regression.
Can we add a test for this fix so we won't regress anymore ?
Another effect which may be related: Troubleshooting Information is empty.
(In reply to Florian Quèze [:florian] [:flo] from comment #6) > I'm sure I tested and fixed this specific case last year I was referring to bug 736437.
Dagger looked into this yesterday in #maildev. The regression seems to be caused by http://hg.mozilla.org/comm-central/diff/ed456f650deb/chat/components/src/imAccounts.js from bug 842183 / https://bugzilla.instantbird.org/show_bug.cgi?id=1855 The likely fix is to move the gAccountsService._keepAccount(this); line to right after this.numericId = parseInt(... as the only dependency _keepAccount has is that aAccount.numericId is set.
Created attachment 759157 [details] [diff] [review] Patch Patch as described in comment 10.
Comment on attachment 759157 [details] [diff] [review] Patch I forgot to mention: I haven't tested this at all! (yet)
Comment on attachment 759157 [details] [diff] [review] Patch This change looks OK, please test it before committing it!
Created attachment 766357 [details] [diff] [review] Patch with test Same patch, now with an xpcshell test. I pushed this changeset to try and the new test passes: https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=1f8da1e733d9 (the rest isn't more broken than on the current Thunderbird-Trunk tree).