869156 - Cannot reshow dynamic toolbar on zoom out after hiding it when zoomed in

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

STR

1) Go to google.com
2) Zoom in
3) Scroll down to hide the dynamic toolbar
4) Zoom out

ER

Scroll down to reshow the dynamic toolbar

AR

Cannot scroll/reshow the toolbar without zooming in again

Comment 1

[Aaron Train [:aaronmt]]

Dupe of bug 865872?

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

(In reply to Aaron Train [:aaronmt] from comment #1)
> Dupe of bug 865872?

From the comments, that one seems to be WFM in the latest Nightlies?

This bug I can reproduce in the latest Nightly.

Comment 3

[Kevin Brosnan [Ex-Mozilla]]

Similar to bug 866772

Comment 4

[Chris Lord [:cwiiis]]

Attachment: Show dynamic toolbar when page shrinks

Comment 5

[Chris Lord [:cwiiis]]

Attachment: Show dynamic toolbar when page shrinks v2

Sorry, the last one wasn't quite enough - that works when the page shrinks itself while you aren't scrolling, but doesn't work while you are because animations are cancelled on every scrollBy call.

This makes sure the toolbar also gets shown when pan/zoom has stopped.

Comment 6

[Chris Lord [:cwiiis]]

Pushed to inbound:

https://hg.mozilla.org/integration/mozilla-inbound/rev/3e715c8a5c38

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/3e715c8a5c38

Comment 8

[Adrian Tamas (:AdrianT)]

I am still able to reproduce the issue on Firefox Mobile 23 beta 1 on the Acer Iconia Tab A500 (Android 3.0) and the Samsung Galaxy Tab (Android 4.0) using the scenario from Comment 0, the scenario from bug 873016 or by opening about: and just scrolling to hide the URL bar. Shouldn't this be uplifted since 23 is now on Beta?

Comment 9

[Chris Lord [:cwiiis]]

Comment on attachment 753841 [details] [diff] [review]
Show dynamic toolbar when page shrinks v2

Argh, I didn't realise this didn't land on 23 :/

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: If a page resizes itself smaller than the screen while the toolbar is hidden, the toolbar cannot be shown
Testing completed (on m-c, etc.): Been on m-c and aurora for a while, no complaint
Risk to taking this patch (and alternatives if risky): Risk of showing the toolbar when it's inappropriate to do so, but given how long this has been on m-c, I think it's low.
String or IDL/UUID changes made by this patch: None

Comment 10

[Ryan VanderMeulen [:RyanVM][PTO June 24-28]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5380c7fa29d6

Comment 11

[Teodora Vermesan (:TeoVermesan)]

Verified fixed on:
Build: Firefox for Android 23.0b8(2013-07-23)
Device: Samsung Galaxy Tab
Android: 4.0.4