870941 - Weird scrollbar artifacts with Lion scrollbars enabled and USB mouse plugged in

Status: VERIFIED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

Attachment: Highlighting the problem in the palette

STR:

1) Get a UX build after the patch in bug 870574 lands (you can get a UX Nightly from http://people.mozilla.org/~jwein/ux-nightly/)
2) Make the window relatively small
3) Enter Customization Mode by clicking on the menu button (far right on the nav bar) and choose "Customize"

At least for me, I get these scrollbar artifacts in the customization palette. And the scrollbar doesn't appear to let me scroll through the overflowing palette.

I'm on OS X 10.8.3. I have graphics acceleration enabled, and a second monitor. I also have a USB mouse plugged in (I think that's relevant because I believe OSX shows the scrollbar all the time if it detects a mouse).

Comment 1

[Robert Strong (they/them - no direct email)]

Does this also happen with nightly builds?

Comment 2

[Mike Conley (:mconley) (:⚙️)]

I should note that the problem goes away when I go into System Preferences > General, and choose to always have scrollbars.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

(In reply to Robert Strong [:rstrong] (do not email) from comment #1)
> Does this also happen with nightly builds?

I'll give a Nightly a try and report back.

Comment 4

[Stephen A Pohl [:spohl]]

(In reply to Mike Conley (:mconley) from comment #0)
> 
> I'm on OS X 10.8.3. I have graphics acceleration enabled, and a second
> monitor. I also have a USB mouse plugged in (I think that's relevant because
> I believe OSX shows the scrollbar all the time if it detects a mouse).

The fact that you have an external mouse connected might indicate that this is a duplicate of bug 868498. Changes to the system preferences don't immediately propagate to the browser's scrollbars yet and can cause unexpected behavior.

If the problem only occurs in the UX branch, maybe the latest patches for the lion-style scrollbars didn't land there yet (bug 636564)?

Comment 5

[Mike Conley (:mconley) (:⚙️)]

I'm unable to reproduce this using a Nightly, but this is because Nightly's not using our new fancy customization palette yet. :) I tried a few other windows and dialogs, and forced scrollbars on an overflowable via DOM Inspector, but no dice.

Bug 636564 exists in the UX builds - it's pretty up to date.

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Ah, my USB mouse appears to be the trigger. Removing it causes the artifact to disappear in UX Nightly.

Comment 7

[Benoit Girard (:BenWa)]

I can reproduce this on nightly and have been seeing this between a few days to just under a week now (don't recall exactly).

Comment 8

[Matthew N. [:MattN]]

Attachment: Screencast of disconnecting and connecting a mouse

Running Nightly on a new profile.

STR (from video):
0) System Preferences > General > Show scroll bars set to Auto
1) Plug in mouse
2) Load http://www.youtube.com. Scrollbars are shown (as expected).
3) Unplug mouse. The scrollbars disappear from the sides of the document but a space appears above the content (presumably with the hidden scrollbars). The scrollbars do not appear upon scrolling with the trackpad as they should.
4) Plug a mouse back in. You can see that the area that appeared above the content now contains artifacts from the gutter. The scrollbars do not appear on the side of the document.

Expected result:
Scrollbars should appear and disappear depending on whether a trackpad or mouse is used. When scrollbars appear, they should be positioned at the right and/or bottom of the document.

Reproducible: Always

Not reproducible on Aurora for me.

Comment 9

[Robert Strong (they/them - no direct email)]

Matt, this likely also affects Firefox 23. Can you verify that it can be reproduced there?

Comment 10

[Matthew N. [:MattN]]

I did check that I can't reproduce the artifacts on 23:

(Quoting Matthew N. [:MattN] from comment #8)
> Not reproducible on Aurora for me.

The scrollbar doesn't auto-hide without a mouse on Aurora. I'm not sure what bug implemented that but it could be the cause.

Perhaps a follow-up not on 23 or some other bug caused this to regress?

Comment 11

[Robert Strong (they/them - no direct email)]

Interesting and thanks for the info!

Comment 12

[Stephen A Pohl [:spohl]]

I'm able to consistently reproduce the scrollbar artifacts by following these steps:
1. Select "Show scroll bars: Automatically..." in system preferences.
2. Open Firefox.
3. Switch system preference to "Show scroll bars: Always".
4. Resize browser window.

The artifacts will appear in the top left corner of the page.

I'm concerned about the fact that we keep hitting one particular assertion twice (probably once for each scrollbar) when resizing. The assertion is:
WARNING: Someone passed native anonymous content directly into frame construction.  Stop doing that!
http://mxr.mozilla.org/mozilla-central/source/layout/base/nsCSSFrameConstructor.cpp#6049

After hitting these assertions the scrollbars don't display correctly anymore, even when switching system preferences again.

Markus, does this assertion seem familiar to you at all? Any idea what might be happening here?

Comment 14

[Stephen A Pohl [:spohl]]

(In reply to Stephen Pohl [:spohl] from comment #12)
> Markus, does this assertion seem familiar to you at all? Any idea what might
> be happening here?

I figured out what is causing this. In nativescrollbars.css, this section applies to overlay scrollbars only:
@media all and (-moz-overlay-scrollbars) {
  scrollbar {
    position: relative;
    z-index: 2147483647;
  }
}
http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/osx/global/nativescrollbars.css#20

When we switch between scrollbars these properties are still set on the scrollbar's content. This appears to be causing the assertions.

I'm finishing up a patch for bug 868498 that should fix this as well.

Comment 15

[Stephen A Pohl [:spohl]]

I was able to reproduce this problem in FF23 with the latest beta:
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:23.0) Gecko/20100101 Firefox/23.0

This will be fixed by the patch for bug 868498 which is already tracking for FF23.

Comment 17

[Stephen A Pohl [:spohl]]

Now that bug 868498 has landed on m-c, this is fixed.

Comment 18

[Stephen A Pohl [:spohl]]

The assertion fix from bug 868498 is being backed out due to regressions (bug 894931), so this bug will arise again. I'll use this bug to track progress on the assertion fix.

Comment 19

[Stephen A Pohl [:spohl]]

Attachment: Workaround for assertions by :roc

Attaching roc's patch from bug 868498 comment 51. This patch works great for me, risk is limited to overlay scrollbars and therefore doesn't risk injections like the previous assertion fix (see bug 894931).

Comment 20

[Stephen A Pohl [:spohl]]

Attachment: Remove CSS rules

Removes position:relative and z-index from nativescrollbars.css

Comment 21

[Stephen A Pohl [:spohl]]

XUL trees will need a similar fix as the one in comment 19 before we can call this bug fixed. The page info dialog is a good example (cmd+i and select Media tab).

Comment 22

[Robert O'Callahan (:roc) (email my personal email if necessary)]

(In reply to Stephen Pohl [:spohl] from comment #21)
> XUL trees will need a similar fix as the one in comment 19 before we can
> call this bug fixed. The page info dialog is a good example (cmd+i and
> select Media tab).

Can you just set position:relative on the scrollbars in tree.xml? That should be quite safe and hoist them above the tree body content.

Comment 23

[Stephen A Pohl [:spohl]]

Attachment: XUL tree fix (not working)

Unless I'm doing this wrong, this doesn't display the scrollbars on top of content. They are visible for a split second while fading, but they aren't visible when the content is actively being scrolled (unexpected) or when the scrollbars are inactive (expected)...

Comment 24

[Robert O'Callahan (:roc) (email my personal email if necessary)]

You need to use style="position:relative; z-index:..."

Comment 25

[Stephen A Pohl [:spohl]]

Attachment: XUL tree fix

Indeed!

Comment 26

[Stephen A Pohl [:spohl]]

Comment on attachment 777547 [details] [diff] [review]
Workaround for assertions by :roc

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 636564
User impact if declined: When connecting a mouse or external monitor, the scrollbars on OSX may no longer display correctly until the page is refreshed or the browser restarted.
Testing completed (on m-c, etc.): Tested locally.
Risk to taking this patch (and alternatives if risky): low (limited to overlay scrollbars)
String or IDL/UUID changes made by this patch: none

Comment 27

[Stephen A Pohl [:spohl]]

Comment on attachment 777548 [details] [diff] [review]
Remove CSS rules

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 636564
User impact if declined: When connecting a mouse or external monitor, the scrollbars on OSX may no longer display correctly until the page is refreshed or the browser restarted.
Testing completed (on m-c, etc.): Tested locally.
Risk to taking this patch (and alternatives if risky): low (limited to overlay scrollbars)
String or IDL/UUID changes made by this patch: none

Comment 28

[Stephen A Pohl [:spohl]]

Comment on attachment 777569 [details] [diff] [review]
XUL tree fix

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 636564
User impact if declined: When connecting a mouse or external monitor, the scrollbars on OSX may no longer display correctly until the page is refreshed or the browser restarted.
Testing completed (on m-c, etc.): Tested locally.
Risk to taking this patch (and alternatives if risky): low
String or IDL/UUID changes made by this patch: none

Comment 29

[Stephen A Pohl [:spohl]]

https://hg.mozilla.org/mozilla-central/rev/ad419a65b8dc
https://hg.mozilla.org/mozilla-central/rev/a6e8633e304f
https://hg.mozilla.org/mozilla-central/rev/16375716cc69

Comment 30

[Jim Mathies [:jimm]]

Presumably this can go too?

http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/windows/global/xulscrollbars.css#27

Comment 31

[Stephen A Pohl [:spohl]]

Closing this bug here per comment 29, since comment 30 isn't in beta and we may want to uplift the patches here to beta.

Comment 32

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 777547 [details] [diff] [review]
Workaround for assertions by :roc

We're not taking these on beta because of disabling the overlay scrollbars but let's get this on Aurora.

Comment 33

[Stephen A Pohl [:spohl]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/3ae78d8e2321
https://hg.mozilla.org/releases/mozilla-aurora/rev/8328e4fa124f
https://hg.mozilla.org/releases/mozilla-aurora/rev/2daf2dee9d60

Comment 34

[Stefan Wrobel]

This should be fixed in 24 beta, right? Because I still have this issue...

Comment 35

[Stephen A Pohl [:spohl]]

(In reply to swrobel from comment #34)
> This should be fixed in 24 beta, right? Because I still have this issue...

Please make sure that you're running the latest beta [1]. If that doesn't fix the problem, please do this:
1. Close browser.
2. Disconnect USB mouse.
3. Open browser and navigate to page that reproduced this problem.
4. Connect USB mouse.
5. Resize browser window.

If these steps cause the artifacts, then we're looking at the same problem. Please tell us what OS you're on and if all pages (or only specific ones) reproduce this problem. If you're unable to reproduce the problem with the steps given above, please file a new bug and give precise STR for how to reproduce the issue. Thanks!

[1] http://www.mozilla.org/en-US/firefox/beta/

Comment 36

[Stefan Wrobel]

I have the same experience as Matthew N reported and screencasted here: https://bug870941.bugzilla.mozilla.org/attachment.cgi?id=754970

It doesn't require resizing the browser window to make the artifacts appear...

(In reply to Stephen Pohl [:spohl] from comment #35)
> (In reply to swrobel from comment #34)
> > This should be fixed in 24 beta, right? Because I still have this issue...
> 
> Please make sure that you're running the latest beta [1]. If that doesn't
> fix the problem, please do this:
> 1. Close browser.
> 2. Disconnect USB mouse.
> 3. Open browser and navigate to page that reproduced this problem.
> 4. Connect USB mouse.
> 5. Resize browser window.
> 
> If these steps cause the artifacts, then we're looking at the same problem.
> Please tell us what OS you're on and if all pages (or only specific ones)
> reproduce this problem. If you're unable to reproduce the problem with the
> steps given above, please file a new bug and give precise STR for how to
> reproduce the issue. Thanks!
> 
> [1] http://www.mozilla.org/en-US/firefox/beta/

Comment 37

[Stephen A Pohl [:spohl]]

(In reply to Stefan Wrobel from comment #36)
> I have the same experience as Matthew N reported

Stefan, could you please provide more detail? In particular, I'm interested in your OS and version, the specific URL you're seeing this problem on and what steps you're going through to make the problem appear. Thanks!

Comment 38

[Stefan Wrobel]

Interesting, on a hunch, I tested this with the stock theme and the issue doesn't occur. It only seems to happen with 3rd-party themes ... I would hope that this fix doesn't need to be integrated into every 3rd-party theme, though.

For reference, the theme I was using is mx4 development channel: https://addons.mozilla.org/en-US/firefox/addon/mx4/

System information:
Firefox 24.0beta7
MacOS 10.8.4
Retina Macbook Pro 13"

Comment 39

[Stephen A Pohl [:spohl]]

Thanks Stefan! I can reproduce the issue now. I'll investigate tomorrow and file a new bug as appropriate.

Comment 40

[Simona Badau, Desktop QA]

I could not reproduce the initial issue on a mini Mac 10.8. Could anyone who reproduced the initial issue confirm this is fixed on Firefox 24 RC?

Comment 41

[Simona Badau, Desktop QA]

Mike, if you have any time to spear, could you please verify this is fixed on Firefox 25 beta?

Thanks.

Comment 42

[Mike Conley (:mconley) (:⚙️)]

Yep, I can't seem to reproduce this issue on the latest beta. Thanks!

Comment 43

[Simona Badau, Desktop QA]

Thanks Mike!

Based on Comment 42, I'm setting the status for Firefox 25 to verified.