Closed
Bug 877864
Opened 12 years ago
Closed 12 years ago
disable mozprocess test until they can get some love
Categories
(Testing :: Mozbase, defect)
Testing
Mozbase
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: k0scist, Assigned: k0scist)
References
Details
Attachments
(1 file)
354 bytes,
patch
|
jgriffin
:
review+
|
Details | Diff | Splinter Review |
We already have our one mozprocess test disabled on windows:
https://github.com/mozilla/mozbase/blob/master/mozprocess/tests/manifest.ini#L5
Now there is another issue regarding these tests on at least OS X at
least intermittently: bug 877823 . These tests have always been
tempermental; while they have been consistently reliable in mine and
others' environments, they are environment sensitive, don't work on
clang (I think?), etc. They have blocked deployment of bug 790765 and
have required more work towards that end than any other test.
In short, they should be disabled. Once we have time to trouble shoot
and we are reliably running mozbase tests on e.g. `make check` despite
hostility towards corruption of this target, we can revisit this issue
and turn them back on. It would be nice to have some of the issues
track by bug 778267 fixed, if not the entire thing rewritten in python
(to be filed).
Assignee | ||
Comment 1•12 years ago
|
||
In the future, we may also want to keep the ability to run as developers vs in automation. See bug 877885
Assignee | ||
Comment 2•12 years ago
|
||
Assignee | ||
Comment 3•12 years ago
|
||
this will, of course, have to be mirrored to m-c, conceivably with bug 790765
Comment 4•12 years ago
|
||
Comment on attachment 756248 [details] [diff] [review]
disable this test
Review of attachment 756248 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks Jeff.
Attachment #756248 -
Flags: review?(jgriffin) → review+
Assignee | ||
Comment 5•12 years ago
|
||
pushed: https://github.com/mozilla/mozbase/commit/0e621fbc77e94417d660512065485bd657004ddd
Added to bug 877733 to mirror -> m-c
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 6•10 years ago
|
||
This test is still disabled according to testing/mozbase/mozprocess/tests/manifest.ini.
There's not noticeable difference running the tests on clang vs. gcc for me. The only subtest that fails is test_process_kill on test_mozprocess.py:282.
You need to log in
before you can comment on or make changes to this bug.
Description
•