Closed
Bug 877733
Opened 11 years ago
Closed 11 years ago
bump mozinfo, mozprocess, mozdevice, mozinstall version and mirror to m-c
Categories
(Testing :: Mozbase, defect)
Testing
Mozbase
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla24
People
(Reporter: k0scist, Assigned: k0scist)
References
Details
Attachments
(3 files, 3 obsolete files)
285 bytes,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
34.94 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
33.35 KB,
patch
|
k0scist
:
review+
|
Details | Diff | Splinter Review |
bug 871746 introduces the ability to load a JSON file directly. mozinfo should be version bumped and mirrored to m-c for this as it is wanted by e.g. bug 868158
Assignee | ||
Comment 1•11 years ago
|
||
Likewise for mozprocess, bug 877864
Assignee | ||
Comment 2•11 years ago
|
||
Likewise for mozdevice, bug 877811
Depends on: 877811
Summary: bump mozinfo, mozprocess version and mirror to m-c → bump mozinfo, mozprocess, mozdevice version and mirror to m-c
Assignee | ||
Updated•11 years ago
|
Assignee | ||
Comment 3•11 years ago
|
||
Will push to try and put up for review (with patch for bug 790765)
Assignee | ||
Comment 4•11 years ago
|
||
pushed to try, build only: https://tbpl.mozilla.org/?tree=Try&rev=6231beb7543b ; not sure if that suffices for checkin (thoughts?)
Comment 5•11 years ago
|
||
Given that the in-tree harnesses aren't using anything but mozcrash it's probably okay.
Comment 6•11 years ago
|
||
(Once we start moving harnesses to using more mozbase modules it'd be prudent to do a full test run to sanity check.)
Assignee | ||
Comment 7•11 years ago
|
||
Looks like mozInstall needs to be destrictified too: (mozbase)│./versionbump.py mozinfo=0.5 mozcrash=0.7 mozprocess=0.11 -m 'Bug 877733 - bump mozinfo, mozprocess, mozdevice version and mirror to m-c' --dry-run --strict Checking for pypirc: /home/jhammel/.pypirc Usage: versionbump.py [options] packageA=0.1.2 <packageB=1.2> <...> versionbump.py: error: Bumping {'mozprocess': '0.11', 'mozcrash': '0.7', 'mozinfo': '0.5'}, but you also need to bump {'mozInstall 1.5': ['mozinfo == 0.4']}
Comment 8•11 years ago
|
||
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #5) > Given that the in-tree harnesses aren't using anything but mozcrash it's > probably okay. This will very soon not be true; ahal is working on some changes to B2G unit tests that mean they will start pulling in-tree mozbase packages. But, it's not in place quite yet.
Assignee | ||
Comment 9•11 years ago
|
||
Attachment #757480 -
Flags: review?(jmaher)
Comment 10•11 years ago
|
||
Comment on attachment 757480 [details] [diff] [review] make mozinstall requirement less strict Review of attachment 757480 [details] [diff] [review]: ----------------------------------------------------------------- holy smokes batman!
Attachment #757480 -
Flags: review?(jmaher) → review+
Assignee | ||
Comment 11•11 years ago
|
||
(In reply to Joel Maher (:jmaher) from comment #10) > Comment on attachment 757480 [details] [diff] [review] > make mozinstall requirement less strict > > Review of attachment 757480 [details] [diff] [review]: > ----------------------------------------------------------------- > > holy smokes batman! pushed: https://github.com/mozilla/mozbase/commit/8655349d606f8d85fef471d1ddcb75f3d37fce23
Assignee | ||
Comment 12•11 years ago
|
||
of course the mozinstall version should probably be bumped too (but it does not need mirroring, afaik)
Summary: bump mozinfo, mozprocess, mozdevice version and mirror to m-c → bump mozinfo, mozprocess, mozdevice, mozinstall version and mirror to m-c
Assignee | ||
Comment 13•11 years ago
|
||
bumped, tagged, mirrored: https://github.com/mozilla/mozbase/commit/76e3c19411d4115d4491aca9f3543bc3ca32be07 (mozbase)│./versionbump.py mozinfo=0.5 mozcrash=0.7 mozprocess=0.11 mozinstall=1.6 -m 'Bug 877733 - bump mozinfo, mozprocess, mozdevice version and mirror to m-c' --dry-run --strict Checking for pypirc: /home/jhammel/.pypirc Usage: versionbump.py [options] packageA=0.1.2 <packageB=1.2> <...> versionbump.py: error: Not a package: mozinstall (mozbase)│./versionbump.py mozinfo=0.5 mozcrash=0.7 mozprocess=0.11 mozInstall=1.6 -m 'Bug 877733 - bump mozinfo, mozprocess, mozdevice version and mirror to m-c' --dry-run --strict Checking for pypirc: /home/jhammel/.pypirc Pulling from git://github.com/mozilla/mozbase.git master Running ['git', 'pull', 'git://github.com/mozilla/mozbase.git', 'master'], {'cwd': '/home/jhammel/mozbase/src/mozbase', 'stderr': None, 'stdout': None} Bumping mozprocess == 0.10 => 0.11 Bumping mozcrash == 0.6 => 0.7 Bumping mozinfo == 0.4 => 0.5 Bumping mozInstall == 1.5 => 1.6 Commit changes to git@github.com:mozilla/mozbase.git: Bug 877733 - bump mozinfo, mozprocess, mozdevice version and mirror to m-c Running ['git', 'commit', '-a', '-m', 'Bug 877733 - bump mozinfo, mozprocess, mozdevice version and mirror to m-c'], {'cwd': '/home/jhammel/mozbase/src/mozbase'} Running ['git', 'push', 'git@github.com:mozilla/mozbase.git', 'master'], {'cwd': '/home/jhammel/mozbase/src/mozbase', 'stderr': None, 'stdout': None} Updating tags for git@github.com:mozilla/mozbase.git: mozprocess-0.11, mozcrash-0.7, mozinfo-0.5, mozInstall-1.6 Running ['git', 'pull', '--tags', 'git@github.com:mozilla/mozbase.git', 'master'], {'cwd': '/home/jhammel/mozbase/src/mozbase', 'stderr': None, 'stdout': None} Running ['git', 'tag', 'mozprocess-0.11'], {'cwd': '/home/jhammel/mozbase/src/mozbase'} Running ['git', 'tag', 'mozcrash-0.7'], {'cwd': '/home/jhammel/mozbase/src/mozbase'} Running ['git', 'tag', 'mozinfo-0.5'], {'cwd': '/home/jhammel/mozbase/src/mozbase'} Running ['git', 'tag', 'mozInstall-1.6'], {'cwd': '/home/jhammel/mozbase/src/mozbase'} Running ['git', 'push', '--tags', 'git@github.com:mozilla/mozbase.git', 'master'], {'cwd': '/home/jhammel/mozbase/src/mozbase', 'stderr': None, 'stdout': None} Uploading to pypi: mozprocess-0.11, mozinfo-0.5, mozcrash-0.7, mozInstall-1.6 Running ['/home/jhammel/mozbase/bin/python', 'setup.py', 'egg_info', '-RDb', '', 'sdist', 'upload'], {'cwd': '/home/jhammel/mozbase/src/mozbase/mozprocess'} Running ['/home/jhammel/mozbase/bin/python', 'setup.py', 'egg_info', '-RDb', '', 'sdist', 'upload'], {'cwd': '/home/jhammel/mozbase/src/mozbase/mozinfo'} Running ['/home/jhammel/mozbase/bin/python', 'setup.py', 'egg_info', '-RDb', '', 'sdist', 'upload'], {'cwd': '/home/jhammel/mozbase/src/mozbase/mozcrash'} Running ['/home/jhammel/mozbase/bin/python', 'setup.py', 'egg_info', '-RDb', '', 'sdist', 'upload'], {'cwd': '/home/jhammel/mozbase/src/mozbase/mozinstall'} (mozbase)│./versionbump.py mozinfo=0.5 mozcrash=0.7 mozprocess=0.11 mozInstall=1.6 -m 'Bug 877733 - bump mozinfo, mozprocess, mozdevice version and mirror to m-c' --strict Checking for pypirc: /home/jhammel/.pypirc Pulling from git://github.com/mozilla/mozbase.git master Running ['git', 'pull', 'git://github.com/mozilla/mozbase.git', 'master'], {'cwd': '/home/jhammel/mozbase/src/mozbase', 'stderr': None, 'stdout': None} From git://github.com/mozilla/mozbase * branch master -> FETCH_HEAD Already up-to-date. Bumping mozprocess == 0.10 => 0.11 Bumping mozcrash == 0.6 => 0.7 Bumping mozinfo == 0.4 => 0.5 Bumping mozInstall == 1.5 => 1.6 Commit changes to git@github.com:mozilla/mozbase.git: Bug 877733 - bump mozinfo, mozprocess, mozdevice version and mirror to m-c Running ['git', 'commit', '-a', '-m', 'Bug 877733 - bump mozinfo, mozprocess, mozdevice version and mirror to m-c'], {'cwd': '/home/jhammel/mozbase/src/mozbase'} Running ['git', 'push', 'git@github.com:mozilla/mozbase.git', 'master'], {'cwd': '/home/jhammel/mozbase/src/mozbase', 'stderr': None, 'stdout': None} Counting objects: 19, done. Delta compression using up to 8 threads. Compressing objects: 100% (10/10), done. Writing objects: 100% (10/10), 934 bytes, done. Total 10 (delta 5), reused 0 (delta 0) To git@github.com:mozilla/mozbase.git 8655349..76e3c19 master -> master Updating tags for git@github.com:mozilla/mozbase.git: mozprocess-0.11, mozcrash-0.7, mozinfo-0.5, mozInstall-1.6 Running ['git', 'pull', '--tags', 'git@github.com:mozilla/mozbase.git', 'master'], {'cwd': '/home/jhammel/mozbase/src/mozbase', 'stderr': None, 'stdout': None} From github.com:mozilla/mozbase * branch master -> FETCH_HEAD Already up-to-date. Running ['git', 'tag', 'mozprocess-0.11'], {'cwd': '/home/jhammel/mozbase/src/mozbase'} Running ['git', 'tag', 'mozcrash-0.7'], {'cwd': '/home/jhammel/mozbase/src/mozbase'} Running ['git', 'tag', 'mozinfo-0.5'], {'cwd': '/home/jhammel/mozbase/src/mozbase'} Running ['git', 'tag', 'mozInstall-1.6'], {'cwd': '/home/jhammel/mozbase/src/mozbase'} Running ['git', 'push', '--tags', 'git@github.com:mozilla/mozbase.git', 'master'], {'cwd': '/home/jhammel/mozbase/src/mozbase', 'stderr': None, 'stdout': None} Total 0 (delta 0), reused 0 (delta 0) To git@github.com:mozilla/mozbase.git * [new tag] mozInstall-1.6 -> mozInstall-1.6 * [new tag] mozcrash-0.7 -> mozcrash-0.7 * [new tag] mozinfo-0.5 -> mozinfo-0.5 * [new tag] mozprocess-0.11 -> mozprocess-0.11 Uploading to pypi: mozprocess-0.11, mozinfo-0.5, mozcrash-0.7, mozInstall-1.6 Running ['/home/jhammel/mozbase/bin/python', 'setup.py', 'egg_info', '-RDb', '', 'sdist', 'upload'], {'cwd': '/home/jhammel/mozbase/src/mozbase/mozprocess'} Running ['/home/jhammel/mozbase/bin/python', 'setup.py', 'egg_info', '-RDb', '', 'sdist', 'upload'], {'cwd': '/home/jhammel/mozbase/src/mozbase/mozinfo'} Running ['/home/jhammel/mozbase/bin/python', 'setup.py', 'egg_info', '-RDb', '', 'sdist', 'upload'], {'cwd': '/home/jhammel/mozbase/src/mozbase/mozcrash'} Running ['/home/jhammel/mozbase/bin/python', 'setup.py', 'egg_info', '-RDb', '', 'sdist', 'upload'], {'cwd': '/home/jhammel/mozbase/src/mozbase/mozinstall'}
Assignee | ||
Comment 14•11 years ago
|
||
(In reply to Jeff Hammel [:jhammel] from comment #12) > of course the mozinstall version should probably be bumped too (but it does > not need mirroring, afaik) I'm glad I made the disclaimer...it actually does: │./generate_diff.py mozcrash=0.7 mozinfo=0.5 mozprocess=0.11 --no-check <snip/> Traceback (most recent call last): File "./generate_diff.py", line 386, in <module> main() File "./generate_diff.py", line 346, in main check_consistency(*current_package_info.values()) File "./generate_diff.py", line 208, in check_consistency raise Exception('\n'.join(errors)) Exception: Dependency for package 'mozInstall' failed: mozinfo-0.5 not == 0.4
Assignee | ||
Comment 15•11 years ago
|
||
Sadly, like anything blocking bug 790765, this ain't as easy as 3.14: │./generate_diff.py mozcrash=0.7 mozinfo=0.5 mozprocess=0.11 mozInstall=1.6 --no-check Cloning into 'mozbase'... remote: Counting objects: 4721, done. remote: Compressing objects: 100% (2834/2834), done. remote: Total 4721 (delta 2057), reused 4469 (delta 1851) Receiving objects: 100% (4721/4721), 1.55 MiB | 486 KiB/s, done. Resolving deltas: 100% (2057/2057), done. Traceback (most recent call last): File "./generate_diff.py", line 386, in <module> main() File "./generate_diff.py", line 301, in main assert os.path.exists(setup_py), "'%s' not found" % setup_py AssertionError: '/tmp/tmpbb0Qk6/mozbase/mozInstall/setup.py' not found
Assignee | ||
Comment 16•11 years ago
|
||
The packages.txt change may/will overlap with https://bugzilla.mozilla.org/show_bug.cgi?id=876761 depending on landing coordination.
Attachment #757607 -
Flags: review?(jmaher)
Assignee | ||
Comment 17•11 years ago
|
||
Please let me know (anyone) if I should resubmit to try.
Comment 18•11 years ago
|
||
Comment on attachment 757607 [details] [diff] [review] mirror changes + generate_diff.py improvements Review of attachment 757607 [details] [diff] [review]: ----------------------------------------------------------------- no red flags here, just a lot of little details.
Attachment #757607 -
Flags: review?(jmaher) → review+
Assignee | ||
Comment 19•11 years ago
|
||
pushed to inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/0fbef2fd43e0 the packages.txt change was dropped
Comment 20•11 years ago
|
||
OSX 10.8 didn't like this apparently. Backed out. https://hg.mozilla.org/integration/mozilla-inbound/rev/4479ef04c5ea https://tbpl.mozilla.org/php/getParsedLog.php?id=23772264&tree=Mozilla-Inbound
Assignee | ||
Comment 21•11 years ago
|
||
beh, wish i could say i was surprised :(
Assignee | ||
Comment 22•11 years ago
|
||
From the log: 11:16:49 INFO - 'virtualenv_modules': ['simplejson', 11:16:49 INFO - {'mozlog': 'tests/mozbase/mozlog'}, 11:16:49 INFO - {'mozinfo': 'tests/mozbase/mozinfo'}, 11:16:49 INFO - {'mozhttpd': 'tests/mozbase/mozhttpd'}, 11:16:49 INFO - {'mozfile': 'tests/mozbase/mozfile'}, 11:16:49 INFO - {'mozinstall': 'tests/mozbase/mozinstall'}, 11:16:49 INFO - {'manifestdestiny': 'tests/mozbase/manifestdestiny'}, 11:16:49 INFO - {'mozprofile': 'tests/mozbase/mozprofile'}, 11:16:49 INFO - {'mozprocess': 'tests/mozbase/mozprocess'}, 11:16:49 INFO - {'mozrunner': 'tests/mozbase/mozrunner'}], ... 11:17:59 INFO - Installing mozlog into virtualenv /builds/slave/talos-slave/test/build/venv 11:17:59 INFO - Running command: ['/builds/slave/talos-slave/test/build/venv/bin/pip', 'install', 'tests/mozbase/mozlog'] in /builds/slave/talos-slave/test/build 11:17:59 INFO - Copy/paste: /builds/slave/talos-slave/test/build/venv/bin/pip install tests/mozbase/mozlog 11:17:59 INFO - Ignoring indexes: http://pypi.python.org/simple/ 11:17:59 INFO - Unpacking ./tests/mozbase/mozlog 11:17:59 INFO - Running setup.py egg_info for package from file:///builds/slave/talos-slave/test/build/tests/mozbase/mozlog 11:17:59 INFO - Installing collected packages: mozlog 11:17:59 INFO - Running setup.py install for mozlog 11:17:59 INFO - Successfully installed mozlog 11:17:59 INFO - Cleaning up... 11:17:59 INFO - Return code: 0 11:17:59 INFO - Installing mozinfo into virtualenv /builds/slave/talos-slave/test/build/venv 11:17:59 INFO - Running command: ['/builds/slave/talos-slave/test/build/venv/bin/pip', 'install', 'tests/mozbase/mozinfo'] in /builds/slave/talos-slave/test/build 11:17:59 INFO - Copy/paste: /builds/slave/talos-slave/test/build/venv/bin/pip install tests/mozbase/mozinfo 11:18:00 INFO - Ignoring indexes: http://pypi.python.org/simple/ 11:18:00 INFO - Unpacking ./tests/mozbase/mozinfo 11:18:00 INFO - Running setup.py egg_info for package from file:///builds/slave/talos-slave/test/build/tests/mozbase/mozinfo 11:18:00 INFO - Downloading/unpacking mozfile>=0.6 (from mozinfo) 11:18:00 INFO - Could not find a version that satisfies the requirement mozfile>=0.6 (from mozinfo) (from versions: ) 11:18:00 INFO - No distributions matching the version for mozfile>=0.6 (from mozinfo) 11:18:00 INFO - Storing complete log in /Users/cltbld/.pip/pip.log 11:18:00 ERROR - Return code: 1 11:18:00 FATAL - Unable to install tests/mozbase/mozinfo! 11:18:00 FATAL - Exiting -1 program finished with exit code 255 So mozfile is installed after mozinfo. The reverse should be true. It looks like the config can just be changed to install mozfile before mozinfo
Assignee | ||
Comment 23•11 years ago
|
||
Filed bug 879560 for the mozharness issue. FWIW, though probably not much, I am a strong believer in not hand-rolling dependency order just for this reason. Depending on timing, I may land the non-mozinfo parts of the patch before the blocker is fixed.
Assignee | ||
Comment 24•11 years ago
|
||
hmmm....I just realized....I bumped mozcrash instead of mozdevice :( My mistake. I'll bump mozdevice -> 0.26 and redo the patch
Assignee | ||
Comment 25•11 years ago
|
||
(In reply to Jeff Hammel [:jhammel] from comment #24) > hmmm....I just realized....I bumped mozcrash instead of mozdevice :( My > mistake. I'll bump mozdevice -> 0.26 and redo the patch bumped, tagged, pypi: https://github.com/mozilla/mozbase/commit/f49085f0169d589e09f696beba885b3a3bfd71fd will redo the patch
Comment 26•11 years ago
|
||
can we mirror to puppetagain?
Assignee | ||
Comment 27•11 years ago
|
||
Attachment #759399 -
Flags: review?(jmaher)
Comment 28•11 years ago
|
||
Comment on attachment 759399 [details] [diff] [review] the same -mozcrash +mozdevice Review of attachment 759399 [details] [diff] [review]: ----------------------------------------------------------------- ::: testing/xpcshell/runxpcshelltests.py @@ +39,5 @@ > + module_path = os.path.join(mozbase, dep) > + if module_path not in sys.path: > + sys.path.append(module_path) > + globals()[module] = __import__(module) > + there is a high chance we will append the same paths to the sys path if we allow the modules to grow. Is there a need for this vs the original method? Right now we have the original code in automation.py.in as well, it would be nice to keep the hack uniform across all instances. I am fine fixing that in a separate bug though.
Attachment #759399 -
Flags: review?(jmaher) → review+
Assignee | ||
Comment 29•11 years ago
|
||
(In reply to Joel Maher (:jmaher) from comment #28) > Comment on attachment 759399 [details] [diff] [review] > the same -mozcrash +mozdevice > > Review of attachment 759399 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: testing/xpcshell/runxpcshelltests.py > @@ +39,5 @@ > > + module_path = os.path.join(mozbase, dep) > > + if module_path not in sys.path: > > + sys.path.append(module_path) > > + globals()[module] = __import__(module) > > + > > there is a high chance we will append the same paths to the sys path if we > allow the modules to grow. Is there a need for this vs the original method? > Right now we have the original code in automation.py.in as well, it would be > nice to keep the hack uniform across all instances. I am fine fixing that > in a separate bug though. Beh, wrong attachment. This was meant for bug 707976
Assignee | ||
Comment 30•11 years ago
|
||
(In reply to Jeff Hammel [:jhammel] from comment #29) > (In reply to Joel Maher (:jmaher) from comment #28) > > Comment on attachment 759399 [details] [diff] [review] > > the same -mozcrash +mozdevice > > > > Review of attachment 759399 [details] [diff] [review]: > > ----------------------------------------------------------------- > > > > ::: testing/xpcshell/runxpcshelltests.py > > @@ +39,5 @@ > > > + module_path = os.path.join(mozbase, dep) > > > + if module_path not in sys.path: > > > + sys.path.append(module_path) > > > + globals()[module] = __import__(module) > > > + > > > > there is a high chance we will append the same paths to the sys path if we > > allow the modules to grow. Is there a need for this vs the original method? > > Right now we have the original code in automation.py.in as well, it would be > > nice to keep the hack uniform across all instances. I am fine fixing that > > in a separate bug though. > > Beh, wrong attachment. This was meant for bug 707976 I moved this discussion to bug 707976 . See follow up at https://bugzilla.mozilla.org/show_bug.cgi?id=707976#c34 . I'll attach the patch I meant to attach
Assignee | ||
Comment 31•11 years ago
|
||
Attachment #756881 -
Attachment is obsolete: true
Attachment #757607 -
Attachment is obsolete: true
Attachment #759399 -
Attachment is obsolete: true
Attachment #759886 -
Flags: review?(jmaher)
Comment 32•11 years ago
|
||
Comment on attachment 759886 [details] [diff] [review] trying this again Review of attachment 759886 [details] [diff] [review]: ----------------------------------------------------------------- looks good. I don't know if we need to update these to puppetagain at all, it is unclear if we still want to do that.
Attachment #759886 -
Flags: review?(jmaher) → review+
Assignee | ||
Comment 33•11 years ago
|
||
(In reply to Joel Maher (:jmaher) from comment #32) > Comment on attachment 759886 [details] [diff] [review] > trying this again > > Review of attachment 759886 [details] [diff] [review]: > ----------------------------------------------------------------- > > looks good. I don't know if we need to update these to puppetagain at all, > it is unclear if we still want to do that. I believe that is necessary: I've filed bug 880806 to that effect which ABICT blocks this. Not sure how to find an owner for it
Comment 34•11 years ago
|
||
Heh, bug 855893 landed not a moment too soon
Comment 35•11 years ago
|
||
(In reply to Andrew Halberstadt [:ahal] from comment #34) > Heh, bug 855893 landed not a moment too soon Oop, meant for a different bug, apologies for bugspam.
Comment 36•11 years ago
|
||
(In reply to Jeff Hammel [:jhammel] from comment #33) > I believe that is necessary: I've filed bug 880806 to that effect which > ABICT blocks this. Not sure how to find an owner for it Bug 880806 looks finished, anything else I can help out with to get this landed?
Assignee | ||
Comment 37•11 years ago
|
||
Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=a3d4e30d86bc ; Will land to inbound on presumed success.
Assignee | ||
Comment 38•11 years ago
|
||
Hmmmmm :( Outside of the usual orange intermittent splatter, a few things. First, the likely dead herring, OSX 10.6 M(bc): """ 17:29:41 WARNING - TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/social/browser_blocklist.js | sub-test testBlockingExistingProvider failed: Error: SocialProvider: provider with origin [https://test1.example.com] is blocklisted """ ABICT, this is unrelated. There is then the OSX 10.6 b2g issue which I'm not sure post-retriggering if it is related or not: """ cppunittests INFO | Running test TestSTSParser cppunittests TEST-UNEXPECTED-FAIL | TestSTSParser | test failed with return code 65280 cppunittests INFO | Running test TestUDPServerSocket Running STS Parser Tests tests... TEST-UNEXPECTED-FAIL | Couldn't get the profile directory. Finished running STS Parser Tests tests. """ It seems unrelated....but I have not yet investigated the test itself. Any clue bats? Then there is the absolutely related xpcshell test on Android 2.2 Armv6 opt and Android 2.2 opt. In both cases: """ Traceback (most recent call last): File "xpcshell/remotexpcshelltests.py", line 9, in <module> import runxpcshelltests as xpcshell File "/builds/tegra-269/test/build/tests/xpcshell/runxpcshelltests.py", line 14, in <module> import mozinfo File "/builds/tegra-269/test/build/tests/xpcshell/mozinfo.py", line 21, in <module> import mozfile ImportError: No module named mozfile """ Hot damn. Well, that does make sense since the new mozinfo requires mozfile and mozinfo is imported first.
Comment 39•11 years ago
|
||
I have seen the TestSPSParser error on unrelated try runs, so at a guess, I'd say it's unrelated.
Assignee | ||
Comment 40•11 years ago
|
||
After talking with :ahal and :ted, the hack we've picked from amongst the possible pre- bug 849900 (see http://mxr.mozilla.org/mozilla-central/source/testing/xpcshell/runxpcshelltests.py#25 ) hacks is to hack up the runxpcshell.py harness for the imports. We're going to redo the current insanity to replace with all the mozbase modules: 10:58 <@ted> for d in os.listdir(mozbase): sys.path.append(os.path.join(mozbase, d))
Assignee | ||
Comment 41•11 years ago
|
||
the droid.py change has already been landed: https://bugzilla.mozilla.org/show_bug.cgi?id=876456#c13 removing from diff
Assignee | ||
Comment 42•11 years ago
|
||
see also http://hg.mozilla.org/mozilla-central/rev/8374bf2b5e63
Assignee | ||
Comment 44•11 years ago
|
||
pushed to try with changes from bug 882461 ( https://bug882461.bugzilla.mozilla.org/attachment.cgi?id=762275 )
Assignee | ||
Comment 45•11 years ago
|
||
looks good; pushed with https://bugzilla.mozilla.org/show_bug.cgi?id=882461#c8 to inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/1fae83d70978
Comment 46•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1fae83d70978
Assignee: nobody → jhammel
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in
before you can comment on or make changes to this bug.
Description
•