Closed
Bug 878657
Opened 13 years ago
Closed 13 years ago
Add UA overrides for Hungary, Mexico, Montenegro, and Serbia
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(b2g18 fixed)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| b2g18 | --- | fixed |
People
(Reporter: lmandel, Assigned: lmandel)
Details
Attachments
(1 file, 1 obsolete file)
|
5.44 KB,
patch
|
lmandel
:
review+
akeybl
:
approval-mozilla-b2g18+
|
Details | Diff | Splinter Review |
This bug adds UA overrides for the sites in the Alexa 100 for Hungary, Mexico, Montenegro, and Serbia that have been demonstrated to be functional on a Firefox OS device. This patch rounds out the UA overrides for the locales listed in the following post:
https://blog.mozilla.org/blog/2013/02/24/mozilla-unlocks-the-power-of-the-web-on-mobile-with-firefox-os/
Note: These overrides are specified slightly differently than the existing overrides ('\\' instead of '\') to avoid creating additional overrides that add warnings. See bug 843437.
Attachment #757196 -
Flags: review?(fabrice)
Comment 1•13 years ago
|
||
Comment on attachment 757196 [details] [diff] [review]
UA overrides for HU, ME, MX, and RS
Review of attachment 757196 [details] [diff] [review]:
-----------------------------------------------------------------
sigh...
::: build/ua-override-prefs.js
@@ +166,5 @@
> +pref("general.useragent.override.eluniversal.com.mx", "\\(Mobile#(Android; Mobile"); // bug 878637
> +pref("general.useragent.override.flickr.com", "\\(Mobile#(Android; Mobile"); // bug 878638
> +pref("general.useragent.override.hootsuite.com", "\\(Mobile#(Android; Mobile"); // bug 878640
> +pref("general.useragent.override.mercadolibre.com.mx", "\\(Mobile#(Android; Mobile"); // bug 878642
> +pref("general.useragent.override.netflix.com", "Mozilla/5.0 (Linux; Android 4.0.4; Galaxy Nexus Build/IMM76B) AppleWebKit/535.19 (KHTML, like Gecko) Chrome/18.0.1025.133 Mobile Safari/535.19"); // bug 878643
netflix.com ? is that usable at all on device?
Attachment #757196 -
Flags: review?(fabrice) → review+
| Assignee | ||
Comment 2•13 years ago
|
||
The Netflix.com mobile allows you to sign up for Netflix. At the end of the sign up you are then prompted to install the Android app. As the site is really only good at this point for sign up, I have removed it from the patch.
Carrying forward the r+ from fabrice.
Attachment #757196 -
Attachment is obsolete: true
Attachment #757427 -
Flags: review+
| Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
| Assignee | ||
Comment 3•13 years ago
|
||
Comment on attachment 757427 [details] [diff] [review]
Updated patch removing netflix
[Approval Request Comment]
Bug caused by (feature/regressing bug #): N/A
User impact if declined: Desktop instead of mobile content for top sites in the four locales
Testing completed: QA has completed functional testing on device for each site on the override list.
Risk to taking this patch (and alternatives if risky): Low risk as this patch adds a number of preferences. The alternative is desktop content for these sites.
String or UUID changes made by this patch: None
Attachment #757427 -
Flags: approval-mozilla-b2g18?
Comment 5•13 years ago
|
||
master: 5b01f824e0d8ff6b09be85de7366aa9394888f50
Flags: needinfo?(jhford)
Keywords: checkin-needed
Updated•13 years ago
|
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•13 years ago
|
Attachment #757427 -
Flags: approval-mozilla-b2g18? → approval-mozilla-b2g18+
Updated•12 years ago
|
Assignee: nobody → lmandel
You need to log in
before you can comment on or make changes to this bug.
Description
•