"Select all" on Error Console

RESOLVED WORKSFORME

Status

Toolkit Graveyard
Error Console
P3
enhancement
RESOLVED WORKSFORME
16 years ago
11 months ago

People

(Reporter: Lythande, Unassigned)

Tracking

Dependency tree / graph

Details

Attachments

(2 attachments)

(Reporter)

Description

16 years ago
You should be able to select the entire content of the javascript console for
copying rather than having to select and copy each error separately.  :-)

Comment 1

16 years ago
jsdebugger != jsconsole, over to hewitt.
Assignee: rginda → hewitt
Component: JavaScript Debugger → XP Apps
QA Contact: rginda → sairuh

Comment 2

16 years ago
rfe, confirming
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Reporter)

Comment 3

16 years ago
Oops, sorry.  Thanks for re-directing.  As an additional comment, any sort of
multiple-selecting would be good.  (Shift-click, Ctrl-click, etc)

Updated

16 years ago
Status: NEW → ASSIGNED
Summary: RFE: "Select all" on javascript console → [RFE] "Select all" on javascript console

Updated

16 years ago
OS: Windows 95 → All
Priority: -- → P3
Hardware: PC → All
Target Milestone: --- → Future
Component: XP Apps → JavaScript Console
QA Contact: sairuh → jrgm

Comment 4

15 years ago
Multiple selection in the javascript console is bug 67603.
Depends on: 67603

Updated

15 years ago
Summary: [RFE] "Select all" on javascript console → "Select all" on javascript console

Comment 5

13 years ago
Would it be possible to add some ability to let javascript access the console
messages from Javascript?  The issue here is that when users want to file bug
reports against a site, relying on them to copy and paste the relevant messages
is not possible.

For security it is probably necessary to store the source domain with the
messages (and filtering those not relevant to the current page).

Comment 6

12 years ago
*** Bug 315896 has been marked as a duplicate of this bug. ***

Comment 7

12 years ago
It seems this bug is more about 'copy all' than 'select all' (see dupe).
Assignee: hewitt → js-console
Status: ASSIGNED → NEW

Updated

11 years ago
Summary: "Select all" on javascript console → "Select all" on Error Console
(Assignee)

Updated

9 years ago
Product: Core → SeaMonkey

Updated

8 years ago
Duplicate of this bug: 481255
Going to take a stab at this...
Assignee: error-console → highmind63
QA Contact: jrgmorrison → error-console
Created attachment 365388 [details] [diff] [review]
wip .1

Throwing this up, this is what I got to so far, still have a ways to go to get the string copying working and keyboard stuff (which fyi doesn't work).

More to come later this/next week.
Assignee: highmind63 → nobody
Status: NEW → ASSIGNED
Component: Error Console → Error Console
Product: SeaMonkey → Toolkit
QA Contact: error-console → error.console
Target Milestone: Future → ---

Comment 11

8 years ago
The Console┬▓ console binding inherits from richlistbox which inherits from listbox so we can just do:

function selectAllItems()
{
	gConsole.selectAll();
}

(See http://www.mozdev.org/source/browse/console2/src/console2/chrome/content/console2/console2.xml)

Perhaps instead of trying to reinvent the wheel why not explore making the console box inherit from richlistbox? Then you get all the multiselect and copy functionality for free.

     <command id="cmd_close" oncommand="closeWindow(true)"/>
+    <command id="select_all" oncommand="selectAll()"/>

For consistency you should use "cmd_select_all".

+      <menuitem label="&selectAll.label;" accesskey="&selectAll.accesskey;"
+                id="menu_select_all" command="select_all"/>

Both Firefox and SeaMonkey use "menu_selectAll". In addition for the context menu item the Suite uses "menu_selectAll_cm". The latter fits in with the existing context menu item in the Error Console:

  "menu_copy_cm" command="cmd_copy"
Thanks for the reference and tips, I'll be including those in the next patch!
Assignee: nobody → highmind63
I'm making some good progress on revamping the error console entirely, I'll attach a wip patch hopefully this week. Part of the refresh will include this bug, among others.
Depends on: 489736
Depends on: 490886
No longer depends on: 489736
No longer depends on: 67603

Updated

8 years ago
Blocks: 490886
No longer depends on: 490886
Pushing out old bugs that I won't have time to actually get to. Feel free to use/extend any patches attached...
Assignee: highmind63 → nobody
Status: ASSIGNED → NEW
Created attachment 569758 [details] [diff] [review]
Patch v0.2

I took Nochum's patch and reworked it a fair amount. I took out the keypress stuff he had since I don't think it was working anyway (I may have just broken it in the process of changing). Honestly I don't think we should have that anyway. Multiselect is inconsistent enough.
Assignee: nobody → paul

Comment 16

6 years ago
Comment on attachment 569758 [details] [diff] [review]
Patch v0.2

> -        <xul:vbox class="console-rows" role="console-rows" xbl:inherits="dir=sortOrder"/>
> +        <xul:vbox anonid="console-rows-vbox" class="console-rows" role="console-rows" xbl:inherits="dir=sortOrder"/>

I think this change to the anonid is unnecessary.
Attachment #569758 - Flags: review?(dolske)
Blocks: 67603
Comment on attachment 569758 [details] [diff] [review]
Patch v0.2

Review of attachment 569758 [details] [diff] [review]:
-----------------------------------------------------------------

I didn't look too closely at this, but still a few comments. R+ assuming you have/will ponder them and fix if worthy.

::: toolkit/components/console/content/console.xul
@@ +91,5 @@
>                  oncommand="changeSortOrder('reverse');"/>
>        <menuseparator/>
>        <menuitem id="menu_copy_cm" command="cmd_copy"
>                  label="&copyCmd.label;" accesskey="&copyCmd.accesskey;"/>
> +      <menuseparator/>

I probably wouldn't bother with the extra menusep here, since it's a short menu.

::: toolkit/components/console/content/consoleBindings.xml
@@ +232,5 @@
> +              // First we need to sort selectedItems since selectedItems[0] is
> +              // always the first selected, but not necessarily the first in the list.
> +              // Then we'll separate each item with 2 newlines, otherwise it will be
> +              // hard to distinguish messages.
> +              function sortFn(a, b) a.getBoundingClientRect().top - b.getBoundingClientRect().top;

That's a little weird. No better way to get their index? Or add an index property instead?

Or drop selectedItems, and construct it on-demand by filtering all items for the ones selected?

@@ +310,5 @@
> +          // We're going to be lazy here and just push the new node in. We use
> +          // selectedItem[0] to determine the first selected (for shift click)
> +          // so we need to maintain that.
> +          var selectedItems = this.selectedItems.slice();
> +          selectedItems.push(aNode);

What happens when you select items, but further console spam causes them to scroll out of the console?

Also, presumably selectedItems gets nuked when closing the console?
Attachment #569758 - Flags: review?(dolske) → review+
What happened here?  It looks like this patch fell through the cracks, despite the r+.
(In reply to Colby Russell :crussell from comment #18)
> What happened here?  It looks like this patch fell through the cracks,
> despite the r+.

(probably) short answer is zpao no longer works on mozilla. 

Plus, web console (ctrl+shift+K in nightlies) is just around the corner. Making this request near obsolete
Yeah, I think this is probably WONTFIX, but maybe someone else is interested in working on it.
Assignee: paul → nobody
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → WONTFIX
Sorry, didn't mean to resolve this.
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---

Updated

4 years ago
Status: REOPENED → NEW

Comment 22

4 years ago
Selecting all entries is now possible with the new console.

Comment 23

4 years ago
Re comment #22:  Starting with which version?

Comment 24

4 years ago
It should be the version with the new browser console. In this console you can now select all of the text.

Comment 25

4 years ago
(In reply to sworddragon2 from comment #24)
> It should be the version with the new browser console. In this console you
> can now select all of the text.

This bug is about the Toolkit Error Console. The Firefox browser console is not available in anything that isn't called "Firefox".

Comment 26

4 years ago
Possibly I have found this bug some time ago while searching for duplicates. At least this issue is fixed on Firefox so I haven't to create now another ticket.
The Error Console has been removed in favor of the Browser Console (see Bug 1278368), and the component is going to be removed.  If this bug is also relevant in the Browser Console, please reopen and move this into Firefox -> Developer Tools: Console.
Status: NEW → RESOLVED
Last Resolved: 4 years ago11 months ago
Resolution: --- → WONTFIX

Comment 28

11 months ago
I am mass-reopening and re-componenting every single one of the Toolkit:Error Console bugs that appear to have been closed without anyone even *glancing* at whether they were relevant to the Browser Console.

If you want to close a whole bunch of old bugs -- FOR ANY REASON -- it is YOUR RESPONSIBILITY to check EVERY SINGLE ONE OF THEM and make sure they are no longer valid.  Do not push that work onto the bug reporters.

(It's okay to close bugs that haven't been touched in years when they don't have enough information for you to figure out whether the problem is still relevant to the current software - the reporter probably isn't coming back to clarify.  But that is the ONLY situation where it is okay.)

(I'm going to have to do this in two steps because of the way the "change several bugs at once" form works.  Apologies for the extra bugspam.)
Status: RESOLVED → REOPENED
Component: Error Console → Developer Tools: Console
Product: Toolkit → Firefox
Resolution: WONTFIX → ---
This WFM in the new browser console.
Status: REOPENED → RESOLVED
Last Resolved: 11 months ago11 months ago
Component: Developer Tools: Console → Error Console
Product: Firefox → Toolkit
Resolution: --- → WORKSFORME
(Assignee)

Updated

11 months ago
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.