Closed Bug 880704 Opened 11 years ago Closed 11 years ago

Intermittent browser_selection_frame_content.js | selection test - Got then, expected started, | runTests: Task failed - Error: Timed out waiting for condition to be true, | selection test - Got after it, expected moment

Categories

(Firefox for Metro Graveyard :: Tests, defect, P3)

Product:
Firefox for Metro Graveyard
Component:
Tests
Platform:
x86
Windows 8.1
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 24

People

(Reporter: philor, Assigned: jimm)

References

Details

(Keywords: intermittent-failure, Whiteboard: feature=defect c=testing u=developer p=0)

Attachments

(1 file, 1 obsolete file)

fix
1.99 KB, patch
rsilveira
: review+
Details | Diff | Splinter Review 
https://tbpl.mozilla.org/php/getParsedLog.php?id=23903156&tree=Mozilla-Central#error2
WINNT 6.2 mozilla-central opt test metro-immersive on 2013-06-07 08:24:09 PDT for push 27545860a3fc
slave: t-w864-ix-110

08:28:21  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/metro/browser/metro/base/tests/mochitest/browser_selection_frame_content.js | selection test - Got then, expected started
08:28:21     INFO -  Stack trace:
08:28:21     INFO -      JS frame :: chrome://mochikit/content/browser-test.js :: test_is :: line 536
08:28:21     INFO -      JS frame :: chrome://mochitests/content/metro/browser/metro/base/tests/mochitest/browser_selection_frame_content.js :: test :: line 134
08:28:21     INFO -      JS frame :: resource://gre/modules/Task.jsm :: TaskImpl_run :: line 192
08:28:21     INFO -      JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: resolve :: line 120
08:28:24     INFO -      JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: then :: line 45
08:28:24     INFO -      JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: resolve :: line 187
08:28:24     INFO -      JS frame :: chrome://mochitests/content/metro/browser/metro/base/tests/mochitest/head.js :: testCondition :: line 352
08:28:24     INFO -      native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0
08:28:24     INFO -  contentTypes: copy,selected-text
08:28:24     INFO -  TEST-PASS | chrome://mochitests/content/metro/browser/metro/base/tests/mochitest/browser_selection_frame_content.js | promise error
08:28:24     INFO -  TEST-PASS | chrome://mochitests/content/metro/browser/metro/base/tests/mochitest/browser_selection_frame_content.js | is visible
08:28:24     INFO -  TEST-PASS | chrome://mochitests/content/metro/browser/metro/base/tests/mochitest/browser_selection_frame_content.js | menu item exists
08:28:24     INFO -  TEST-PASS | chrome://mochitests/content/metro/browser/metro/base/tests/mochitest/browser_selection_frame_content.js | menu item visible
08:28:24     INFO -  TEST-PASS | chrome://mochitests/content/metro/browser/metro/base/tests/mochitest/browser_selection_frame_content.js | promise error
08:28:24     INFO -  TEST-INFO | chrome://mochitests/content/metro/browser/metro/base/tests/mochitest/browser_selection_frame_content.js | TEARDOWN scrolled iframe selection
08:28:24  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/metro/browser/metro/base/tests/mochitest/browser_selection_frame_content.js | runTests: Task failed - Error: Timed out waiting for condition to be true at testCondition@chrome://mochitests/content/metro/browser/metro/base/tests/mochitest/head.js:339
08:28:24     INFO -  Stack trace:
08:28:24     INFO -      JS frame :: chrome://mochitests/content/metro/browser/metro/base/tests/mochitest/head.js :: <TOP_LEVEL> :: line 697
08:28:24     INFO -      JS frame :: resource://gre/modules/Task.jsm :: TaskImpl_run :: line 192
08:28:24     INFO -      JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: resolve :: line 120
08:28:24     INFO -      JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: then :: line 45
08:28:24     INFO -      JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: resolve :: line 187
08:28:24     INFO -      JS frame :: resource://gre/modules/Task.jsm :: TaskImpl_run :: line 220
08:28:24     INFO -      JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: resolve :: line 120
08:28:24     INFO -      JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: then :: line 45
08:28:24     INFO -      JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: then :: line 155
08:28:24     INFO -      JS frame :: resource://gre/modules/Task.jsm :: TaskImpl_run :: line 207
08:28:24     INFO -      JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: resolve :: line 120
08:28:24     INFO -      JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: then :: line 45
08:28:24     INFO -      JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: resolve :: line 187
08:28:24     INFO -      JS frame :: chrome://mochitests/content/metro/browser/metro/base/tests/mochitest/head.js :: testCondition :: line 352
08:28:24     INFO -      native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0
08:28:24     INFO -  TEST-INFO | chrome://mochitests/content/metro/browser/metro/base/tests/mochitest/browser_selection_frame_content.js | END scrolled iframe selection
08:28:24     INFO -  TEST-INFO | chrome://mochitests/content/metro/browser/metro/base/tests/mochitest/browser_selection_frame_content.js | SETUP iframe within scrolled page selection
08:28:24     INFO -  TEST-INFO | chrome://mochitests/content/metro/browser/metro/base/tests/mochitest/browser_selection_frame_content.js | RUN iframe within scrolled page selection
08:28:24     INFO -  TEST-PASS | chrome://mochitests/content/metro/browser/metro/base/tests/mochitest/browser_selection_frame_content.js | selection active
08:28:24  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/metro/browser/metro/base/tests/mochitest/browser_selection_frame_content.js | selection test - Got after it, expected moment
08:28:24     INFO -  Stack trace:
08:28:24     INFO -      JS frame :: chrome://mochikit/content/browser-test.js :: test_is :: line 536
08:28:24     INFO -      JS frame :: chrome://mochitests/content/metro/browser/metro/base/tests/mochitest/browser_selection_frame_content.js :: test :: line 196
08:28:24     INFO -      JS frame :: resource://gre/modules/Task.jsm :: TaskImpl_run :: line 192
08:28:24     INFO -      JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: resolve :: line 120
08:28:24     INFO -      JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: then :: line 45
08:28:24     INFO -      JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: resolve :: line 187
08:28:24     INFO -      JS frame :: chrome://mochitests/content/metro/browser/metro/base/tests/mochitest/head.js :: testCondition :: line 352
08:28:24     INFO -      native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0
Component: General → Tests
Version: unspecified → Trunk
Blocks: 880298
Actually, looks like this is probably fallout from bug 880703, I haven't yet seen one that did one but not the other.
Looks like this is similar to bug 880703. Test fix pushed to try.
Assignee: nobody → jmathies
(In reply to Jim Mathies [:jimm] from comment #60)
> Looks like this is similar to bug 880703. Test fix pushed to try.

Not the case, another push for some screenshots - 

https://tbpl.mozilla.org/?tree=Try&showall=1&rev=1cdaf163c699
Odd, slaves are displaying a scrollbar in the text area, which throws off text placement. On my surface the text area doesn't have them.
Attached patch work around (obsolete) — — Splinter Review 
This works around the problem. For odd scrollbar display behavior we currently have bug 881067 filed.

https://tbpl.mozilla.org/?tree=Try&rev=6de7adf7565f&showall=1
(In reply to Jim Mathies [:jimm] from comment #76)
> Created attachment 760328 [details] [diff] [review]
> work around
> 
> This works around the problem. For odd scrollbar display behavior we
> currently have bug 881067 filed.
> 
> https://tbpl.mozilla.org/?tree=Try&rev=6de7adf7565f&showall=1

There was a new follow up failure after the initial failure passed - 

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/metro/browser/metro/base/tests/mochitest/browser_selection_frame_content.js | selection test - Got was, expected moment
Attached patch fix — — Splinter Review 
This fixed them both up. Removes the scrollbars from the iframe and adds some scroll space to the page.
Attachment #760328 - Attachment is obsolete: true
Attachment #760389 - Flags: review?(rsilveira)
(In reply to Jim Mathies [:jimm] from comment #78)
> Created attachment 760389 [details] [diff] [review]
> fix
> 
> This fixed them both up. Removes the scrollbars from the iframe and adds
> some scroll space to the page.

I'll remove the snapshat code from my local copy.
Comment on attachment 760389 [details] [diff] [review]
fix

Review of attachment 760389 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good and simple! r+ without the snap code.
Attachment #760389 - Flags: review?(rsilveira) → review+
https://hg.mozilla.org/mozilla-central/rev/18b7504e921f
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 24
Blocks: metro-testing, 865451, metrov1defect&change
No longer blocks: 880298
Priority: -- → P3
Whiteboard: feature=defect c=testing u=developer p=0
Blocks: 880298
No longer blocks: metro-testing
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: