883577 - Last page visited should not include private browsing windows

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[[e-mail]]

Steps to reproduce problem:
1. Configure a new browser window (or tab) to open the last page visited
2. Open a private window
3. Visit a page
4. Open a new browser window (or tab)

Actual result: page visited in private window opens

Comment 1

[[e-mail]]

Attachment: Proposed patch

Note: Patch includes relevant change from bug 883532.

Comment 2

[Philip Chee]

Comment on attachment 763172 [details] [diff] [review]
Proposed patch

Tested with the STR in Comment 0. f=me.

>    // nsIWebProgressListener partial implementation
>    onLocationChange: function(aWebProgress, aRequest, aLocation, aFlags)
>    {
>      if (aWebProgress.DOMWindow.top == aWebProgress.DOMWindow &&
I think we can use aWebProgress.isTopLevel here thanks to Bug 666801.
[spotted a few other places where we could use .isTopLevel]

Comment 3

[Ian Neal]

(In reply to Philip Chee from comment #2)
> >      if (aWebProgress.DOMWindow.top == aWebProgress.DOMWindow &&
> I think we can use aWebProgress.isTopLevel here thanks to Bug 666801.
> [spotted a few other places where we could use .isTopLevel]

Logged bug 884132 to cover that.

Comment 4

[[e-mail]]

Pushed comm-central changeset c676fc4b9ae0.

Comment 5

[[e-mail]]

Attachment: Branch patch

[Approval Request Comment]
User impact if declined: Privacy leak
Risk to taking this patch (and alternatives if risky): Low

Comment 6

[[e-mail]]

Forgot the bug#. Oops.

https://hg.mozilla.org/releases/comm-aurora/rev/0be1bcbc416c
http://hg.mozilla.org/releases/comm-beta/rev/049349753f15