The default bug view has changed. See this FAQ.

Last page visited should not include private browsing windows

RESOLVED FIXED in seamonkey2.21

Status

SeaMonkey
UI Design
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: neil@parkwaycc.co.uk, Assigned: neil@parkwaycc.co.uk)

Tracking

(Blocks: 1 bug)

unspecified
seamonkey2.21
Dependency tree / graph

SeaMonkey Tracking Flags

(seamonkey2.19 fixed, seamonkey2.20 fixed, seamonkey2.21 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

4 years ago
Steps to reproduce problem:
1. Configure a new browser window (or tab) to open the last page visited
2. Open a private window
3. Visit a page
4. Open a new browser window (or tab)

Actual result: page visited in private window opens
(Assignee)

Updated

4 years ago
No longer blocks: 837519
(Assignee)

Updated

4 years ago
Blocks: 837510
(Assignee)

Comment 1

4 years ago
Created attachment 763172 [details] [diff] [review]
Proposed patch

Note: Patch includes relevant change from bug 883532.
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #763172 - Flags: review?(iann_bugzilla)
Attachment #763172 - Flags: feedback?(philip.chee)

Comment 2

4 years ago
Comment on attachment 763172 [details] [diff] [review]
Proposed patch

Tested with the STR in Comment 0. f=me.

>    // nsIWebProgressListener partial implementation
>    onLocationChange: function(aWebProgress, aRequest, aLocation, aFlags)
>    {
>      if (aWebProgress.DOMWindow.top == aWebProgress.DOMWindow &&
I think we can use aWebProgress.isTopLevel here thanks to Bug 666801.
[spotted a few other places where we could use .isTopLevel]
Attachment #763172 - Flags: feedback?(philip.chee) → feedback+

Updated

4 years ago
Attachment #763172 - Flags: review?(iann_bugzilla) → review+

Comment 3

4 years ago
(In reply to Philip Chee from comment #2)
> >      if (aWebProgress.DOMWindow.top == aWebProgress.DOMWindow &&
> I think we can use aWebProgress.isTopLevel here thanks to Bug 666801.
> [spotted a few other places where we could use .isTopLevel]

Logged bug 884132 to cover that.
(Assignee)

Comment 4

4 years ago
Pushed comm-central changeset c676fc4b9ae0.
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.21
(Assignee)

Comment 5

4 years ago
Created attachment 765650 [details] [diff] [review]
Branch patch

[Approval Request Comment]
User impact if declined: Privacy leak
Risk to taking this patch (and alternatives if risky): Low
Attachment #765650 - Flags: approval-comm-beta?
Attachment #765650 - Flags: approval-comm-aurora?

Updated

4 years ago
Attachment #765650 - Flags: approval-comm-beta?
Attachment #765650 - Flags: approval-comm-beta+
Attachment #765650 - Flags: approval-comm-aurora?
Attachment #765650 - Flags: approval-comm-aurora+
(Assignee)

Comment 6

4 years ago
Forgot the bug#. Oops.

https://hg.mozilla.org/releases/comm-aurora/rev/0be1bcbc416c
http://hg.mozilla.org/releases/comm-beta/rev/049349753f15
status-seamonkey2.19: --- → fixed
status-seamonkey2.20: --- → fixed
status-seamonkey2.21: --- → fixed
You need to log in before you can comment on or make changes to this bug.