Closed
Bug 899822
Opened 11 years ago
Closed 11 years ago
Stop trying to sync LDAP sessions
Categories
(MailNews Core :: LDAP Integration, defect)
MailNews Core
LDAP Integration
Tracking
(thunderbird25 fixed, seamonkey2.22 fixed)
RESOLVED
FIXED
Thunderbird 26.0
People
(Reporter: neil, Assigned: neil)
References
Details
Attachments
(1 file)
3.48 KB,
patch
|
standard8
:
review+
standard8
:
approval-comm-aurora+
|
Details | Diff | Splinter Review |
We're still trying to sync sessions between elements in the addressing widget, but this is unnecessary now that LDAP is using toolkit interfaces. I want to remove the API in bug 896123, so we should stop calling it!
Assignee | ||
Comment 1•11 years ago
|
||
I also removed the comment column cloning because it's stored on an attribute so it gets cloned anyway.
Comment 2•11 years ago
|
||
Comment on attachment 783416 [details] [diff] [review] Proposed patch Could you also tidy the lightning instance around http://mxr.mozilla.org/comm-central/source/calendar/base/content/dialogs/calendar-event-dialog-attendees.xml#426 ?
Assignee | ||
Comment 3•11 years ago
|
||
(In reply to Mark Banner from comment #2) > Could you also tidy the lightning instance around > > http://mxr.mozilla.org/comm-central/source/calendar/base/content/dialogs/ > calendar-event-dialog-attendees.xml#426 > > ? Ideally Lightning would ditch all of their old LDAP code in bug 899958.
Updated•11 years ago
|
Attachment #783416 -
Flags: review?(mbanner) → review+
Comment 4•11 years ago
|
||
neil, can confirm that this will make the parts of the current patch for bug 61491 (which I am currently debitrotting) concerned with LDAP sessions obsolete?
Comment 5•11 years ago
|
||
T(In reply to Jens Müller (:tessarakt) from comment #4) > neil, can confirm that this will make the parts of the current patch for bug > 61491 (which I am currently debitrotting) concerned with LDAP sessions > obsolete? In fact, the patch here is required to make the current patch for bug 61491 work.
Assignee | ||
Comment 6•11 years ago
|
||
Pushed comm-central changeset 657dea66cbd9.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 26.0
Assignee | ||
Comment 7•11 years ago
|
||
Comment on attachment 783416 [details] [diff] [review] Proposed patch [Approval Request Comment] This should have been done as part of bug 452232 which landed on TB25 so I sort of feel that this should too.
Attachment #783416 -
Flags: approval-comm-aurora?
Comment 8•11 years ago
|
||
Comment on attachment 783416 [details] [diff] [review] Proposed patch Yep, good idea. a=Standard8
Attachment #783416 -
Flags: approval-comm-aurora? → approval-comm-aurora+
Assignee | ||
Comment 9•11 years ago
|
||
http://hg.mozilla.org/releases/comm-aurora/rev/1ec37735e818
status-seamonkey2.22:
--- → fixed
status-thunderbird25:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•