899958 - Lightning should stop using the LDAP interfaces in XPFE autocomplete now that they are going away

Status: RESOLVED FIXED

(Calendar :: Lightning Only, defect)

Description

[Philip Chee]

This is unnecessary now that LDAP is using toolkit interfaces.

See Bug 899822 Comment 0
> We're still trying to sync sessions between elements in the addressing
> widget, but this is unnecessary now that LDAP is using toolkit interfaces.
> I want to remove the API in bug 896123, so we should stop calling it!

http://mxr.mozilla.org/comm-central/search?string=syncSessions
http://mxr.mozilla.org/comm-central/search?string=addSession
http://mxr.mozilla.org/comm-central/search?string=removeSession

syncSessions/addSession/removeSession should all go.

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1

This should take care. Looking at attachment 777047 [details] [diff] [review], all that needed to be done is remove all that xpfe code (yay!) and add "ldap" to the textbox's autocompletesearch attribute, which we already had.

I've tested this with a global ldap directory defined.

Comment 2

[Matthew Mecca [:mmecca]]

Comment on attachment 785195 [details] [diff] [review]
Fix - v1

Review of attachment 785195 [details] [diff] [review]:
-----------------------------------------------------------------

Untested, looks good. r=mmecca

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v2

Since I have no idea how RyanVM pushed the other patches without adding CLOSED TREE, I'm just going to upload this one and set checkin-needed.

Comment 4

[[e-mail]]

(In reply to Philipp Kewisch from comment #3)
> Since I have no idea how RyanVM pushed the other patches without adding
> CLOSED TREE, I'm just going to upload this one and set checkin-needed.

I don't know either, but I cheated.

http://hg.mozilla.org/comm-central/rev/7ab5532fd624