897559 - Use |repo manifest| to parse manifest in gonk-misc/add-revision.py

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Diego Wilson [:diego]]

This is easier to maintain and parses some elements that were being ignored like "remove-project".

Comment 1

[Diego Wilson [:diego]]

gonk-misc PR coming up

Comment 2

[Diego Wilson [:diego]]

Attachment: Pull request

Comment 3

[Michael Wu [:mwu]]

Comment on attachment 780554 [details]
Pull request

jhford, what do you think? I don't know our build infra well enough to know if this would risk breaking things.

Comment 4

[John Ford [:jhford] CET/CEST Berlin Time]

Comment on attachment 780554 [details]
Pull request

This looks great!

R- because this will break local developer builds.

You are hardcoding to use a copy of repo available in the path.  This might be okay for releng machines but almost all developers are using the copy of repo that we install to the b2g_root, outside the path.  The exception that a developer gets is pretty cryptic because python's subprocess module doesn't like to say which file could not be found when it fails to start the program.

I tested with a simple patch to make sure that the everything works locally.
https://github.com/jhford/gonk-misc/commit/b346d235f48d57c8b512c20987be400b41f6d9ff

You're welcome to use that commit or come up with something better, but please squash the commits.

Comment 5

[John Ford [:jhford] CET/CEST Berlin Time]

(squash the related commits)

Comment 6

[Diego Wilson [:diego]]

Comment on attachment 780554 [details]
Pull request

Hi jhford,

Thanks for your help! I squashed your patch into my PR. Please take another look.

Comment 7

[Diego Wilson [:diego]]

Oh, did you mean I should squash the revert of bug 890065 as well? If so, I think it's clearer as an individual revert commit.

Comment 8

[John Ford [:jhford] CET/CEST Berlin Time]

(In reply to Diego Wilson [:diego] from comment #7)
> Oh, did you mean I should squash the revert of bug 890065 as well? If so, I
> think it's clearer as an individual revert commit.

nope, just the fix.  Merging now.

Comment 9

[John Ford [:jhford] CET/CEST Berlin Time]

Comment on attachment 780554 [details]
Pull request

https://github.com/mozilla-b2g/gonk-misc/commit/e63605f15c660783e046d27d385390f17828349f

Comment 10

[Diego Wilson [:diego]]

Awesome possum, thanks!

Comment 11

[Ryan VanderMeulen [:RyanVM]]

This broke B2G builds. Please backout.
https://tbpl.mozilla.org/php/getParsedLog.php?id=26246254&tree=B2g-Inbound

Comment 12

[Dave Hylands [:dhylands]]

Backed out this changeset due to bustage (requested by RyanVM)

Bustage:
https://tbpl.mozilla.org/php/getParsedLog.php?id=26246254&tree=B2g-Inbound

Backout:
https://github.com/mozilla-b2g/gonk-misc/pull/106

https://github.com/dhylands/gonk-misc/commit/1f93c0c8eb5da8d92656ce3e6ad2e45a229ee9bc
https://github.com/dhylands/gonk-misc/commit/4b3b13dc724e79c0ae2f84ed32fc0d6fe83599d2

Comment 13

[Diego Wilson [:diego]]

jhford,

This works fine for me locally. Any idea what's the source of the bustage?

Comment 14

[Ryan VanderMeulen [:RyanVM]]

My apologies. The bustage turned out to be a different cause than this bug. My apologies for the churn :(

Comment 15

[Diego Wilson [:diego]]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #14)
> My apologies. The bustage turned out to be a different cause than this bug.
> My apologies for the churn :(

No worries. What's the best way to un-revert?

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Re-land?

Comment 17

[Diego Wilson [:diego]]

Attachment: Reland pull request

Carry forward r=jhford from PR

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://github.com/mozilla-b2g/gonk-misc/commit/17c9658cb4b1081352b802c51e26f73b8157b4d9

Sorry again for the mix-up.