904922 - [meta]WPS header is truncated across multiple locales

Status: VERIFIED INVALID

(Firefox OS Graveyard :: General, defect)

Description

[Delphine Lebédel [:delphine - Use needinfo]]

Filed this bug to track other instances in v1.1, since it very often happens that the WPS header is truncated across multiple locales

We have asked localizers to find workarounds when possible for this, however this is not a long term solution

Comment 1

[Delphine Lebédel [:delphine - Use needinfo]]

Happens in German, Croatian, Hungarian, Russian, Slovak, Serbian Cyrillic

Comment 2

[Vlado Valastiak [:wladow]]

The root cause here is that a string is shared across several UI elements. In this case it's the wpsMessage and it's being used for both button and header in https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/elements/wifi.html#L28 and https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/elements/wifi_wps.html#L9. In order to fix the issue in Slovak, we need to use two separate strings here, for example:

wpsMessage=Connect with WPS
wpsMessageButton=Connect with WPS

This way we are able to shorten the WPS header while keeping meaningful translation for the button.

Comment 3

[Théo Chevalier]

This bug has been fixed on master (and will probably be on 1.3 soon) -- we now have two separate strings for all buttons/headers in Settings. See Bug 944749 .

I'm not sure if we should close this bug now or wait for the localizers to update their translations.

Comment 4

[Peter Bylenga [:PBylenga]]

This issue also occurs with the Polish Language.

Comment 5

[Francesco Lodolo [:flod]]

(In reply to Peter Bylenga from comment #4)
> This issue also occurs with the Polish Language.

As Théo said, with bug 944749 we have separate strings for button and headers in Settings. 

If a locale still has this problem, I suggest to file a new bug in the localization component for that specific language. Since the button say "Connect with WPS", the next header can just say "Connect", or "WPS settings", etc.

Personally I would close this as fixed, but I'll let :delphine decide.

Comment 6

[Delphine Lebédel [:delphine - Use needinfo]]

I agree with flod. Closing this bug as resolved-invalid for now.
Let's open up specific locale bugs if this continues in some languages
Feel free to reopen later if needed

Comment 7

[Delphine Lebédel [:delphine - Use needinfo]]

Please note: I've checked in all v1.3 supported locales and have found no truncations in this case anymore