905065 - [FlatFish][BuildingBlocks] Shared style modification for Tablet

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia, defect)

Description

[[e-mail]]

To support large device we have some style modifications in shared/style.

Since building block is also in refactor mode, we'd like to collect all shared style modifications for reference and help building block team collect large device related changes.

Comment 1

[Francis Lee [:frlee]]

It's a must for flatfish. Marked as koi+ according to triage result.

Comment 2

[[e-mail]]

--- Since the basic layout works and 1.2 is target for minimum tablet support

Comment 3

[Juwei Huang[:juwei]]

Attachment: [Flatfish] AppFramework1021.pdf

Hi all, spec uploaded.

Comment 4

[[e-mail]]

We'd start from header styles. 
Due to time bound, we'd try to commit style changes to each app, then try to distill them to building block.

We agreed to put building block related change in the bottom of each @media-query section

Comment 5

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

This patch has modified the header of tablet.

Comment 6

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 826634 [details]
PR to master

Hi Arnau,

could you kindly help me to review it? Thanks.

Comment 7

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: System_20131025.pdf

Attach header and toolbar spec. 
The left button on header should be 5px-width as discussed with our visual team.

Hi Helen,
could you confirm on that? Thanks.

Comment 8

[(Inactive after June) George Duan [:gduan] [:喬智]]

Hi Arnau,
I just updated what you suggested, please kindly check it again.
Thanks.

Comment 9

[(Inactive after June) George Duan [:gduan] [:喬智]]

Correct myself, 5rem-width
(In reply to George Duan [:gduan] from comment #7)
> Created attachment 830175 [details]
> System_20131025.pdf
> 
> Attach header and toolbar spec. 
> The left button on header should be 5px-width as discussed with our visual
> team.
> 
> Hi Helen,
> could you confirm on that? Thanks.

Comment 10

[Helen Huang [:HHuang]]

Attachment: System_20131031.pdf

Visual spec has been updated. The left button on header is 5rem-width.

Comment 11

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

I'm cancelling all old Flatfish ni and reviews till we have final specs.
Feel free to ping me again.

Comment 12

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Comment on attachment 826634 [details]
PR to master

I'm cancelling all old Flatfish ni and reviews till we have final specs.
Feel free to ping me again.

Comment 14

[(Inactive after June) George Duan [:gduan] [:喬智]]

Close this bug based on comment 11 .