910188 - [CONTACTS] In export contacts option, if we tap on 'x' button, we come back to Settings screen.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[b.paloma]

Repro:

1. Open Contacts app
2. Go to Contacts -> Settings -> Export contacts
3. Tap on 'to SIM' option
4. Once the list of contacts is shown, tap on 'x' button (ER1)


Expected:

ER1. User is taken back to 'Export Contacts' screen, without any contact exported


Actual: 

ER1. User is taken back to 'Settings' screen.

Notes:
This bug has been checked on:
branch: master
Gaia:43cf923
Gecko:7dc9265

Comment 1

[Joe Cheng [:jcheng] (please needinfo)]

this is not a blocker for release. please land it when a fix is available. master is open now. thanks

Comment 2

[rafael.marquez]

We have the same problem in the "export to memory card". We maintain this bug for two screens, but if necessary we can open a new bug.

Comment 3

[Salvador de la Puente González [:salva]]

I think is all the same issue but I'll let you know if it is not.

Comment 4

[Germán Toro del Valle (:gtorodelvalle)]

Well, to start with just noticing that the first time the Contacts app is run it works as expected. It is in subsequent clicks on the closing "X" button when the user is shown the "Settings" screen and not the "Export Contacts" one. Closing and restarting the Contacts app makes the first execution of this transition to work fine again ;-) I'll keep digging into it.

Comment 5

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: 12269.html

Comment 6

[Jose Manuel Cantera]

Comment on attachment 806044 [details] [diff] [review]
12269.html

working perfectly.

thanks German.

Comment 7

[Germán Toro del Valle (:gtorodelvalle)]

Merged in master: https://github.com/mozilla-b2g/gaia/commit/30f92b6b041db172c34059d9e7878d8730b5b4ca

Comment 8

[rafael.marquez]

Bug verified:

Gecko-> bf4520a
Gaia-> 53f63e4
Branch-> Master
Device-> unagi

Comment 9

[Joe Cheng [:jcheng] (please needinfo)]

triage: not a blocker for v1.2. please ask for approval to land in v1.2

Comment 10

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 806044 [details] [diff] [review]
12269.html

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Simple solution for a bug that could be anoying
[Bug caused by] (feature/regressing bug #):
Feaute, when we created the new export feature we added this bug
[User impact] if declined:
Bad user experience, returning to a screen not expected
[Testing completed]:
Bug has been verified by QA already
[Risk to taking this patch] (and alternatives if risky):
Risk is low, changes are not that big
[String changes made]:

Comment 11

[Germán Toro del Valle (:gtorodelvalle)]

Thanks Francisco! ;-)

Comment 12

[Noemí Freire (:noemi)]

Assigning to Francisco for the approval review

Comment 13

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 806044 [details] [diff] [review]
12269.html

Low risk bug that fix a huge navigation issue.

Issue has been also verified by qa.

a=me

Comment 14

[Francisco Jordano [:arcturus] [:francisco]]

Hi John!

Should we done something special for uploding this to 1.2?

Thanks!
F.

Comment 15

[John Ford [:jhford] CET/CEST Berlin Time]

Nope, but I'm not sure why this isn't showing up in the uplift queue.

Comment 16

[John Ford [:jhford] CET/CEST Berlin Time]

There is conflict 

++<<<<<<< HEAD
 +      // Dictionary by contact id with the rows on screen
 +      rowsOnScreen = {},
 +      selectedContacts = {};
++=======
+       boundSelectAction4Select = null,
+       boundSelectAction4Close = null;
++>>>>>>> 30f92b6... Merge pull request #12269 from gtorodelvalle/dialer-bug-910

Comment 17

[Francisco Jordano [:arcturus] [:francisco]]

Uplift done to v1.2 here:

https://github.com/mozilla-b2g/gaia/commit/a12a8bf3b4f24c29a16e7180c276b1fc2e605dcb