Closed Bug 910479 Opened 7 years ago Closed 7 years ago
Store user credentials after Firefox Account creation/log in
We'll need to call the FxAccounts service to save the user's credentials once we complete the sign-in/create account flows.
Save them where? (had to ask) local storage on the client? server-side?
(In reply to James Bonacci [:jbonacci] from comment #1) > Save them where? > (had to ask) > local storage on the client? > server-side? Save them to the user's profile on disk. We'll need to access these credentials from chrome to auth with the Sync 2.0 token server.
Some choices here with historical pointers: * Password manager: kinda sucks. Some users wipe on shutdown (Bug 553400), you need hacks to unlock it with MP enabled (Bug 671422), even with Master Password it's weak, and it doesn't extend well to sign-in-to-browser. * Use the system keychain. Bug 638966. * Flat files. Need to consider if these are encrypted, and whether they live inside a profile directory or outside it (again, for SITB). * ??? N.B., credentials will be stored in an entirely different manner on Android, so this only applies to desktop, Metro, and perhaps FxOS.
OS: Mac OS X → All
Hardware: x86 → All
Note: The FxAccounts module currently stores everything to a file in the user's profile directory. See Bug #909967
Attachment #800282 - Flags: feedback?(rnewman)
Attachment #800282 - Flags: feedback?(rnewman) → feedback+
Now uses the XPCOM service to obtain an instance.
Style and documentation updates.
Updates the wrapper to use the FxAccounts.jsm module instead of the service. Stylistic changes to the communication channel between jelly and wrapper that Gavin brought up in #910844 will be addressed in that bug.
Attachment #807959 - Flags: review?(gavin.sharp) → review+
r=gavin in person.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Adding to my stack of Resolved bugs to review... I expect the build will be on the ELM site by tomorrow morning...
Component: Firefox Sync: UI → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.