Closed Bug 911053 (activity-window) Opened 9 years ago Closed 9 years ago

[fugu][Window Management] Implement Activity Window

Categories

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:fugu+)

RESOLVED FIXED
blocking-b2g fugu+

People

(Reporter: alive, Assigned: alive)

References

Details

Attachments

(2 files, 1 obsolete file)

Currently Activity is managed in Window Manager.
We would like to implement an OO class "Activity Window",
which inherits from AppWindow class.
And then remove the startInlineActivity and stopInlineActivity from WindowManager.
Depends on: 927310
I found getIconSplash is broken in activity(current), file another bug to track.
Also current orientation strategy of activity is not perfect, file another bug to refine.
Attached file ActivityWindow (obsolete) —
Implement ActivityWindow
Implement ActivityWindowFactory
New VisibilityManager
New OrientationManager
Unit Tests
Attachment #821019 - Flags: review?(timdream)
Attachment #821019 - Flags: review?(timdream) → review+
Attached file ActivityWindow v2
Part.2
https://github.com/alivedise/gaia/commit/b289bded15764013f8c54ac31653cab7b84f61b1

Implement AppModalDialog + BaseUI
Refine logging
Remove invalid tests

Travis is green except test_bookmark.
https://travis-ci.org/mozilla-b2g/gaia/builds/13080095
Attachment #821019 - Attachment is obsolete: true
Attachment #822750 - Flags: review?(timdream)
Component: Gaia::System → Gaia::System::Window Mgmt
Attachment #822750 - Flags: review?(timdream) → review+
Sent an email to qa-b2g@mozilla.com, if no response today I will land this. (Still trying to find out significant issues)
(In reply to Alive Kuo [:alive] from comment #9)
> Sent an email to qa-b2g@mozilla.com, if no response today I will land this.
> (Still trying to find out significant issues)

Sorry for the lack of response - let me ping the tw-qa guys to help out.
Thanks!

(In reply to Jason Smith [:jsmith] from comment #10)
> (In reply to Alive Kuo [:alive] from comment #9)
> > Sent an email to qa-b2g@mozilla.com, if no response today I will land this.
> > (Still trying to find out significant issues)
> 
> Sorry for the lack of response - let me ping the tw-qa guys to help out.
https://github.com/mozilla-b2g/gaia/commit/fd1c66eaef2c206801f1502dc3b40e16df5f9cfb
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You inverted the aria-hide attribute. It should be the other way around, when we unlock, aria-hidden should be false.
Depends on: 934653
No longer blocks: task-manager
Alias: activity-window
blocking-b2g: --- → fugu?
Summary: [Window Management] Implement Activity Window → [fugu][Window Management] Implement Activity Window
What is this change for?
James,
The bugs(such as 937508 ,938090) related to activity window are already fixed in V1.3. Do still you want such fixes included in fugu (v1.2f)?
Flags: needinfo?(james.zhang)
(In reply to pcheng from comment #16)
> James,
> The bugs(such as 937508 ,938090) related to activity window are already
> fixed in V1.3. Do still you want such fixes included in fugu (v1.2f)?

v1.3 is ok. Thanks!
Flags: needinfo?(james.zhang)
(In reply to pcheng from comment #16)
> James,
> The bugs(such as 937508 ,938090) related to activity window are already
> fixed in V1.3. Do still you want such fixes included in fugu (v1.2f)?

Oh, sorry, we should merge it back to v1.2. It cause several major bugs in our bugzilla.
Flags: needinfo?(styang)
blocking-b2g: fugu? → fugu+
Flags: needinfo?(styang)
Whiteboard: [Fugu need]
Whiteboard: [Fugu need] → [Fugu needs]
Alive,

Why is this needed in fugu?

Can it wait till 1.4?
Flags: needinfo?(alive)
It's not me setting fugu stuff. I have the same question and I tend to modify the title back.
Flags: needinfo?(alive)
Attachment #8346440 - Flags: review?(ehung)
Need v1.2f patch.
Flags: needinfo?(styang)
Comment on attachment 8346440 [details] [diff] [review]
911053.patch

I have no idea why you submit a patch for a refactoring issue which has been resolved. Please note this bug isn't for a specific bug but a piece of window manager refactoring stuff. I know this work indirectly resolves some issues happen on fugu, but we can't uplift (because a bunch of dependency) nor accept workaround patch here. 

For those issues (indirectly resolved by this bug) on v1.2, we decided to resolve them separately. They are tracking in bug 949854 and bug 949860. Please check them out.
Attachment #8346440 - Flags: review?(ehung) → review-
To confirm, this commit does not uplift cleanly to v1.2f.  As stated in comment 22, someone will need to adapt the patch for this branch.
Flags: needinfo?(styang)
Whiteboard: [Fugu needs]
You need to log in before you can comment on or make changes to this bug.