911260 - Remove UA override for domains starting 2013-08-30

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Karl Dubost💡 :karlcow]

New list of removal of domains

Comment 1

[Karl Dubost💡 :karlcow]

Bug 802981 to remove maps.google.com

Comment 2

[Karl Dubost💡 :karlcow]

Bug 843134 to remove news.google.com

Comment 3

[Karl Dubost💡 :karlcow]

Bug 829478  to remove mail.google.com

Comment 4

[Karl Dubost💡 :karlcow]

to remove plotek.pl Bug 828376

Comment 5

[Karl Dubost💡 :karlcow]

to remove nytimes.com Bug 843137

Comment 6

[Karl Dubost💡 :karlcow]

to remove icanhas.cheezburger.com Bug 843197

Comment 7

[Karl Dubost💡 :karlcow]

to remove cnn.com Bug 878635

Comment 8

[Karl Dubost💡 :karlcow]

to remove ofeminin.pl Bug 887739

Comment 9

[Karl Dubost💡 :karlcow]

to remove enfemenino.com Bug 843109

Comment 10

[Karl Dubost💡 :karlcow]

Fixing also the file according to 
https://groups.google.com/forum/#!topic/mozilla.compatibility/7rDkuiNaGWk

There discrepancies in the file. 

+bancobrasil.com.br
should be removed it is a duplicate of
https://bugzilla.mozilla.org/show_bug.cgi?id=826711

+bet365.com
was fixed a while ago
https://bugzilla.mozilla.org/show_bug.cgi?id=878226


+live.com
Bug 826332 was closed as a duplicate of Bug 759111 which has now been closed too. Removing it.
https://bugzilla.mozilla.org/show_bug.cgi?id=826332

Comment 11

[Karl Dubost💡 :karlcow]

Attachment: patch-911260-ua-override.patch

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined:
[Testing completed]:
[Risk to taking this patch] (and alternatives if risky):
[String changes made]:

Comment 12

[Lawrence Mandel [:lmandel] (use needinfo)]

I removed bug 887739 from the dependency list as there was no override for the associated domain.

Comment 13

[Lawrence Mandel [:lmandel] (use needinfo)]

Karl, when requesting approval, please fill in the questionnaire.

[Approval Request Comment] Request to uplift UA override changes.
[Bug caused by] (feature/regressing bug #): N/A
[User impact] if declined: Certain sites on the list will continue to display Android app ads. This impacts user experience.
[Testing completed]: All override removals have been tested on device.
[Risk to taking this patch] (and alternatives if risky): Very low risk. As the patch shows, this change removes prefs.
[String changes made]: None.

Comment 14

[Karl Dubost💡 :karlcow]

Added the pull request https://github.com/mozilla-b2g/gaia/pull/12398(In reply to Lawrence Mandel [:lmandel] from comment #12)
> I removed bug 887739 ☐ from the dependency list as there was no override for
> the associated domain.

Ah good catch. Oversight from me.

Comment 15

[Karl Dubost💡 :karlcow]

(In reply to Lawrence Mandel [:lmandel] from comment #13)
> Karl, when requesting approval, please fill in the questionnaire.
> 
> [Approval Request Comment] Request to uplift UA override changes.
> [Bug caused by] (feature/regressing bug #): N/A
> [User impact] if declined: Certain sites on the list will continue to
> display Android app ads. This impacts user experience.
> [Testing completed]: All override removals have been tested on device.
> [Risk to taking this patch] (and alternatives if risky): Very low risk. As
> the patch shows, this change removes prefs.
> [String changes made]: None.

Oh! in the attachment form. 
Will do next time, I didn't know I had to. Thanks.


And I added the pull request
https://github.com/mozilla-b2g/gaia/pull/12398

Comment 16

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: mozilla-central patch

Comment 17

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: mozilla-central patch

Comment 18

[Karl Dubost💡 :karlcow]

Comment on attachment 812070 [details] [diff] [review]
mozilla-central patch

Review of attachment 812070 [details] [diff] [review]:
-----------------------------------------------------------------

looks good.

Comment 19

[Preeti Raghunath(:Preeti)]

koi+ for low risk reasons

Comment 20

[(inactive) Jim Chen [:jchen] [:darchons]]

Checked in.

https://hg.mozilla.org/integration/b2g-inbound/rev/edd87e1f3268

Comment 21

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/edd87e1f3268

Comment 22

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/3aab2cb0a1a7