Remove UA override for domains starting 2013-08-30
RESOLVED
FIXED
in Firefox 26, Firefox OS v1.2
Status
People
(Reporter: karlcow, Assigned: karlcow)
Tracking
Firefox Tracking Flags
(blocking-b2g:koi+, firefox25 wontfix, firefox26 fixed, firefox27 fixed, b2g-v1.2 fixed)
Details
(URL)
Attachments
(2 attachments, 1 obsolete attachment)
|
12.17 KB,
patch
|
lmandel
:
review+
|
Details | Diff | Splinter Review |
|
6.54 KB,
patch
|
karlcow
:
review+
|
Details | Diff | Splinter Review |
New list of removal of domains
|
(Assignee) | |
Comment 1•5 years ago
|
||
Bug 802981 to remove maps.google.com
|
|
(Assignee) | |
Comment 4•5 years ago
|
||
to remove plotek.pl Bug 828376
|
|
(Assignee) | |
Comment 10•5 years ago
|
||
Fixing also the file according to https://groups.google.com/forum/#!topic/mozilla.compatibility/7rDkuiNaGWk There discrepancies in the file. +bancobrasil.com.br should be removed it is a duplicate of https://bugzilla.mozilla.org/show_bug.cgi?id=826711 +bet365.com was fixed a while ago https://bugzilla.mozilla.org/show_bug.cgi?id=878226 +live.com Bug 826332 was closed as a duplicate of Bug 759111 which has now been closed too. Removing it. https://bugzilla.mozilla.org/show_bug.cgi?id=826332
|
|
(Assignee) | |
Updated•5 years ago
|
||
|
|
(Assignee) | |
Comment 11•5 years ago
|
||
Created attachment 809244 [details] [diff] [review] patch-911260-ua-override.patch NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] [Bug caused by] (feature/regressing bug #): [User impact] if declined: [Testing completed]: [Risk to taking this patch] (and alternatives if risky): [String changes made]:
Attachment #809244 -
Flags: review?(lmandel)
|
||
Updated•5 years ago
|
||
Attachment #809244 -
Flags: review?(lmandel) → review+
|
|
||
Comment 12•5 years ago
|
||
I removed bug 887739 from the dependency list as there was no override for the associated domain.
No longer depends on: 887739
|
|
||
Comment 13•5 years ago
|
||
Karl, when requesting approval, please fill in the questionnaire. [Approval Request Comment] Request to uplift UA override changes. [Bug caused by] (feature/regressing bug #): N/A [User impact] if declined: Certain sites on the list will continue to display Android app ads. This impacts user experience. [Testing completed]: All override removals have been tested on device. [Risk to taking this patch] (and alternatives if risky): Very low risk. As the patch shows, this change removes prefs. [String changes made]: None.
|
|
(Assignee) | |
Comment 14•5 years ago
|
||
Added the pull request https://github.com/mozilla-b2g/gaia/pull/12398(In reply to Lawrence Mandel [:lmandel] from comment #12) > I removed bug 887739 ☐ from the dependency list as there was no override for > the associated domain. Ah good catch. Oversight from me.
|
|
(Assignee) | |
Comment 15•5 years ago
|
||
(In reply to Lawrence Mandel [:lmandel] from comment #13) > Karl, when requesting approval, please fill in the questionnaire. > > [Approval Request Comment] Request to uplift UA override changes. > [Bug caused by] (feature/regressing bug #): N/A > [User impact] if declined: Certain sites on the list will continue to > display Android app ads. This impacts user experience. > [Testing completed]: All override removals have been tested on device. > [Risk to taking this patch] (and alternatives if risky): Very low risk. As > the patch shows, this change removes prefs. > [String changes made]: None. Oh! in the attachment form. Will do next time, I didn't know I had to. Thanks. And I added the pull request https://github.com/mozilla-b2g/gaia/pull/12398
|
|
(Assignee) | |
Updated•5 years ago
|
||
blocking-b2g: --- → leo?
|
|
(Assignee) | |
Updated•5 years ago
|
||
blocking-b2g: leo? → koi?
|
||
Comment 16•5 years ago
|
||
Created attachment 812065 [details] [diff] [review] mozilla-central patch
|
|
||
Comment 17•5 years ago
|
||
Created attachment 812070 [details] [diff] [review] mozilla-central patch
Attachment #812065 -
Attachment is obsolete: true
|
|
(Assignee) | |
Comment 18•5 years ago
|
||
Comment on attachment 812070 [details] [diff] [review] mozilla-central patch Review of attachment 812070 [details] [diff] [review]: ----------------------------------------------------------------- looks good.
Attachment #812070 -
Flags: review+
|
|
||
Comment 20•5 years ago
|
||
Checked in. https://hg.mozilla.org/integration/b2g-inbound/rev/edd87e1f3268
|
||
Comment 21•5 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/edd87e1f3268
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.2 C3(Oct25)
|
||
Comment 22•5 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/3aab2cb0a1a7
status-b2g-v1.2: --- → fixed
status-firefox25: --- → wontfix
status-firefox26: --- → fixed
status-firefox27: --- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•