Closed Bug 921391 Opened 6 years ago Closed 6 years ago

[DSDS][Gaia] Need to show the Call forwarding notifications.

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED
1.4 S3 (14mar)

People

(Reporter: kchang, Assigned: arthurcc)

References

Details

Attachments

(3 files)

User should be able to see 2 different icons for voicemails and call forwarding indicating each subscription's status.
The effort should be minor. UX won't be changed. Only a Web API will be changed, and the new API will return the information about SIM.
blocking-b2g: --- → 1.3+
Depends on: 814629
Arthur, may I know what's the target milestone in your mind for this bug? Thanks.
Flags: needinfo?(arthur.chen)
Flags: needinfo?(arthur.chen)
Target Milestone: --- → 1.3 Sprint 5 - 11/22
Blocks: 938440
Blocks: 940752
Target Milestone: 1.3 Sprint 5 - 11/22 → 1.3 Sprint 6 - 12/6
Plan to land in the 1st week of sprint 6.
This bug is supposed to block bug 938438.
Blocks: 938438
No longer blocks: 938440, 918553
After checking user story, this is 1.4 feature.
blocking-b2g: 1.3+ → madai?
Ken, this seems like a pretty basic bug that we need to add in 1.3. Sandip what do you think?
Flags: needinfo?(skamat)
(In reply to Anshul from comment #6)
> Ken, this seems like a pretty basic bug that we need to add in 1.3. Sandip
> what do you think?

Hi Anshul, Most of the user stories that distinguish source or destinations SIMs in UI are targeted for 1.4 (e.g. indicating SIMs in call history, message inbox and voicemails UI etc). This was done as a trade off to get 1.3 committed user stories landed in time with high confidence. Even if we get this one in, there will be inconsistencies in other areas where SIMs are not distinguished in those use cases. I am not opposed to having this one in 1.3 if it can happen with no risks, just do not want some other critical (committed) user stories to be traded off for these. Hope this helps.
Flags: needinfo?(skamat)
Sandip, thanks for your prompt response. Other bugs like call history, messages per SIM are good to have but not necessary. The voicemail on the other hand is needed as other wise we would only show the voicmaail information from the last SIM we got the voicemail on, which is incorrect. I think of this very similar to two signal strength icons we already have now for each SIM.
(In reply to Anshul from comment #8)
> The voicemail on the other hand is needed as other wise we would only show the voicmaail
> information from the last SIM we got the voicemail on, which is incorrect. I
> think of this very similar to two signal strength icons we already have now
> for each SIM.

yes, we had internally discussed in the past reviews. The limitation here will be the icon will show a voicemail for either SIM. So the user needs to really clear it by calling one SIM at a time (I understand it is a hard trade off we had to make to limit scope). But if it can come in 1.3 timeframe without risks, I am okay with it. (Given that it is too late for 1.3 to commit).
I agree with the comment made by Anshul in comment #8. Call settings, specially call forwarding, wont be complete until we fix this bug. We will fix bug 928294 for v1.3 but the call forwarding feature for multi ICC card devices wont be complete until we fix this bug.
In general, if it is a dependency for a committed feature, that's a new data which we did not have before. We should fix it for that then. Can someone provide the risk assessment for this fix to land in 1.3?
I think it is less risk to display different icons for call forwarding, but we may not able to finish it before branching.

As for voicemail, I checked the code and found that things are not as what comment 1 described. We don't have an icon for voicemail even on single sim devices. So it might be too late to define the behavior and to add the icon.
(In reply to Arthur Chen [:arthurcc] from comment #12)
> I think it is less risk to display different icons for call forwarding, but
> we may not able to finish it before branching.
> 
> As for voicemail, I checked the code and found that things are not as what
> comment 1 described. We don't have an icon for voicemail even on single sim
> devices. So it might be too late to define the behavior and to add the icon.
Hello Arthur, sorry my original comments were misleading. What I meant to say is two different voicemail notifications from each sim.
Hi Etienne, can you provide a rough assessment for the change described in comment 13 in terms of risk and effort?
Flags: needinfo?(etienne)
Well I'm confused since we _do have_ an icon in the status bar for voicemail [1].
Not sure that's what this bug is about...

But anyway, we'll have to sort out the issue with the |ril.iccInfo.mbdn| setting before we can add any proper voicemail+dsds support so we should target 1.4.

[1] https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/voicemail.js#L20-21
Flags: needinfo?(etienne)
Assignee: arthur.chen → nobody
Assignee: nobody → arthur.chen
blocking-b2g: madai? → ---
Target Milestone: 1.3 Sprint 6 - 12/6 → ---
Carrie, Fang, it seems we need icons for call forwarding on different sim cards. We can use either static images or just use the current icon along with a text indicating the sim cards.
Flags: needinfo?(fshih)
Flags: needinfo?(cawang)
Target Milestone: --- → 1.4 S3 (14mar)
Use bug 975918 to track the voice mail part.
Summary: [DSDS][Gaia] Need to show the Voicemail and Call forwarding notifications. → [DSDS][Gaia] Need to show the Call forwarding notifications.
Hi Arthur,

Fang is taking care of the icon design. Thanks!
Flags: needinfo?(cawang)
Hi Arthur,

As you said, We can use the current call forwarding icon with a number indicating the SIM cards. The attached image shows the look. Thanks!
Flags: needinfo?(fshih)
Jose, could you help review settings/js/call.js and system/js/call_forwarding.js? To add unit tests, I make it as a new module and extend it to support multiple sims.

Alive, could you help review the overall system app modifications? Thanks!
Attachment #8385205 - Flags: review?(josea.olivera)
Attachment #8385205 - Flags: review?(alive)
Comment on attachment 8385205 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/16812

greak work, r+ with nits
Attachment #8385205 - Flags: review?(alive) → review+
Comment on attachment 8385205 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/16812

(In reply to Arthur Chen [:arthurcc] from comment #20)
> Created attachment 8385205 [details]
> Link to https://github.com/mozilla-b2g/gaia/pull/16812
> 
> Jose, could you help review settings/js/call.js and
> system/js/call_forwarding.js? To add unit tests, I make it as a new module
> and extend it to support multiple sims.

LGTM, thanks for adding the support for multi ICC cards. r=me

I tested the work on peak and fugu device and everything seems to work correctly. Thanks for adding some tests too.
Attachment #8385205 - Flags: review?(josea.olivera) → review+
Thanks Jose and Alive.

master: c92859677608a214b82aadadb2f57cbb0fe3f3e8
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
QA Contact: atsai
Keywords: verifyme
Attached image CallForwarding.png
Verified okay with v1.4 on Fugu.

GAIA_REV=441c4bcd8ac4f8c01a9bc5a2f8d64eaa87844803
GECKO_REV=0c18beacb37a7e1e80bcf6d46cc8ff9a18c0c653
GAIA_BRANCH=mozillaorg/v1.4
GECKO_BRANCH=mozillaorg/v1.4
BUILD_TAG=jenkins-B2G.v1.4.0.fugu-25
BuildID=20140416041552
Status: RESOLVED → VERIFIED
Keywords: verifyme
You need to log in before you can comment on or make changes to this bug.