927640 - Uncaught Exception: "File > Save As..." fails when opening attached .eml file, also when opening from compose window

Status: RESOLVED DUPLICATE of bug 1402550

(Thunderbird :: Mail Window Front End, defect, P4)

Description

[John Perkins]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130912 Firefox/17.0 (Nightly/Aurora)
Build ID: 20130913055614

Steps to reproduce:

To reproduce:
1.  save a message to a .eml file, then attach and send that message
2.  double-click the .eml attachment
3 [review].  try to File->Save As->File or Ctrl-S to save the message as a file



Actual results:

Nothing (no file selection window, no sign of file read/writes recorded in procmon on Windows platform--similar results on Linux platform)


Expected results:

Should have given a dialog box to select where to save the message.

Comment 2

[Thomas D. (:thomas8)]

Bugs which receive duplicates should be confirmed where applicable...
Also, we should strive to carry over helpful info from duplicates...

Comment 3

[Thomas D. (:thomas8)]

Here's some fresh STR and more info on the uncaught exception which occurs when this happens.

(In reply to Kai Engert (:KaiE:) from bug 1675727 comment #0)

STR:

Send a plain message (A) to yourself.
Receive the message, use forward as attachment, send it to yourself (B).
Receive message B, which has A attached.
Double click the attached message A, which opens it in its own window.
In the new window, use "CTRL-S" or "file save as file".

Expected: Get a prompt to enter the filename, then get a file on disk with the saved message.

Actual behavior: no prompt, nothing is saved, error console shows two exceptions:

Uncaught Exception
​
columnNumber: 0
​
data: null
​
filename: "chrome://messenger/content/mailCommands.js"
​
lineNumber: 413
​
location: XPCWrappedNative_NoHelper { QueryInterface: QueryInterface(), filename: Getter, name: Getter, … }
​
message: "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIMsgMessageService.messageURIToMsgHdr]"
​
name: "NS_ERROR_FAILURE"
​
result: 2147500037
​
stack: "SaveAsFile@chrome://messenger/content/mailCommands.js:413:55\nMsgSaveAsFile@chrome://messenger/content/mailWindowOverlay.js:2219:13\ndoCommand@chrome://messenger/content/messageWindow.js:1365:9\ngoDoCommand@chrome://global/content/globalOverlay.js:101:18\noncommand@chrome://messenger/content/messageWindow.xhtml:1:12\n"
​
<prototype>: ExceptionPrototype { toString: toString(), name: Getter, message: Getter, … }
mailCommands.js:413

An error occurred executing the cmd_saveAsFile command: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIMsgMessageService.messageURIToMsgHdr]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://messenger/content/mailCommands.js :: SaveAsFile :: line 413"  data: no] globalOverlay.js:104

Comment 4

[Francesco]

Update 2024 with TB 115:
When you open an attached .eml file in a tab or in a stand-alone window, "File > Save As > File" and "File > Save As > Template" both fail.

The same issue exists when you open the .eml file not from an attachment, but open a saved .eml file from the OS desktop or an OS folder.

@Chrizilla: You've been doing some triaging around old bugs, can you look whether there are move more bugs in this area. Here's a list to start with: https://mzl.la/4faweUf

Comment 5

[Jeff Bloomfield]

The behavior described in this bug can also be reproduced in Compose mode on the Macintosh port:

1. Attach a file with a .eml extension.
2. Double-click on the attachment at the bottom of the compose window.
3. Attempt to save the file using SaveAs->File

When you try to save the file from the resulting OS window, a rather opaque error message appears:

Alert!
Unable to save the message. Please check your file
and try again later.

Comment 6

[chrizilla]

(In reply to Francesco from comment #4)

Update 2024 with TB 115:
When you open an attached .eml file in a tab or in a stand-alone window, "File > Save As > File" and "File > Save As > Template" both fail.
The same issue exists when you open the .eml file not from an attachment, but open a saved .eml file from the OS desktop or an OS folder.

can confirm in TB 115.6.1 @ win10-64bit

@Chrizilla: You've been doing some triaging around old bugs, can you look whether there are move bugs in this area. Here's a list to start with: https://mzl.la/4faweUf

Sorry, I don't understand what you mean by "move bugs" ?
Do you want me to search for dupes of this bug ?

Comment 7

[Francesco]

Off-topic: "move bugs" was a typo. Corrected above. Yes, recently you were looking into bug 628098 and related bugs, so I was just thinking that the issue here might also have duplicates.

Comment 8

[chrizilla]

I was just thinking that the issue here might also have duplicates.

Yes.

scope: both .eml attachments AND external .eml files	scope: only external .eml files
bug 927640 filed in 2013	bug 1402550 filed in 2017
	+ 5 duplicates: bug 634860, bug 1557287, bug 1625447, bug 1708736, bug 1717573
	+ 1 see also: bug 1708736
	IMO all 7 bugs (1+5+1) in this column should be duped directly to bug 927640

Comment 9

[chrizilla]

Attachment: error - unable to save the message.png

image content:
pop-up alert in TB 115.6.1 @ win10-64bit: Unable to save the message. Please check your file name and try again later.

Comment 10

[Francesco]

IMO all 7 bugs (1+5+1) in this column should be duped directly to bug 927640

Nice job. Given that bug 1402550 has a patch and that the older bug 634860 got duped to 1402550, you would cause less noise by only duping 927640 to bug 1402550 and consider it as the "master bug" for that issue.

Comment 11

[chrizilla]

@Francesco: Good points. I overlooked the patch in bug 1402550. Yes, progress trumps submission date and you are also right about bug 634860 being the oldest one.

But the problem is that only bug 927640 also covers .eml attachments. All other bugs only cover external .eml files.
Therefore the issue of .eml attachments would be lost if duped to bug 1402550. So what to do ?

Comment 12

[Francesco]

Well, I added the "or save .eml file opened from OS folder" to the summary not knowing about bug 1402550. I've undone this now, so we leave both bugs open. They may have the same fix.

Comment 13

[chrizilla]

Agreed. Wayne Mery said we should only deduplicate bugs if we "know for a fact that they use the same code".
Otherwise we should keep both bugs open, but connect them via see also or dependencies.

Comment 14

[Francesco]

Tested with 132.0a1 (2024-09-06): .eml files attached in the compose window can now be opened and saved.

Fixed by bug 1402550.