932672 - [Flatfish][Camera] Cannot recording video

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Al Tsai [:atsai]]

As a user, I cannot record video.

STR:
1. Launch Camera app
2. switch to video recorder
3. tap on video icons to start to record

Expected Result:
*. Start to record

Actual Result:
*. A prompt shows there's error caused cannot trigger recorder


Gaia:     b93de939502cff5dc7ef242a6ec9af34b0864f91
Gecko:    94801a471800e7edcce71fb4d02e89a38d1b99ef
BuildID   20131030064537
Version   28.0a1

** The case is by the testing on Flatfish devices. It might not be able to reproduce on other mobile devices **

Comment 1

[Francis Lee [:frlee]]

this is function fail, mark it koi+.

hi Marco, 

may you please help to loop in the right owner to fix this bug?

Comment 2

[Marco Chen [:mchen]]

Hi Al,

It seems that this one is duplicated with bug 932204.
Please help to confirm then set as duplicated. Thanks.

Comment 3

[RaymondSu]

This is not a duplicated bug with bug 932204.  That is talking about the front/back camera switch icon.

Comment 4

[Al Tsai [:atsai]]

It's still reproducible. I cannot record video. That's the problem.

Gaia:     51e80edcfb40082793e1f3219fc1fe2729f338f9
Gecko:    b6a4edc4e3778d3844752c8998debb930890eb20
BuildID   20131105100731
Version   28.0a1

Comment 5

[Marco Chen [:mchen]]

Move some comments from bug 932204 which is related to "recording function is not working" since 932204 is opened for missing camera switching icon.

--------------------------------------------------
Currently narrow down the fail point in 
http://mxr.mozilla.org/mozilla-central/source/dom/camera/GonkRecorder.cpp#1269
I still figure out why it fails when it called.

OMXCodec::Create() failed because encoder_flags always be 0. Backed trace the code and currently narrow down the fail point in  
http://mxr.mozilla.org/mozilla-central/source/dom/camera/GonkCameraSource.cpp#482

Comment 6

[saminath]

This is due to Video Recording patches are not integrated in the Main-stream line.
Could you integrate patches(4) from the below link and test it.

https://bugzilla.mozilla.org/show_bug.cgi?id=910498#c31

Initailly I faced same, after this patch for Video recording integration, start working for me.

Comment 7

[Keven Kuo [:kkuo]]

Hi! Vincent,

Over to you.

--
Keven

Comment 8

[Vincent Liu[:vliu]]

(In reply to saminath from comment #6)
> This is due to Video Recording patches are not integrated in the Main-stream
> line.
> Could you integrate patches(4) from the below link and test it.
> 
> https://bugzilla.mozilla.org/show_bug.cgi?id=910498#c31
> 
> Initailly I faced same, after this patch for Video recording integration,
> start working for me.

Please see the below link for more detail.

https://bugzilla.mozilla.org/show_bug.cgi?id=932204#c10

Comment 9

[Francis Lee [:frlee]]

as we confirmed that Flatfish will use v1.3 and we need to respect current testing cycle, set target milestone to 12/6 since 1.3FC tag is not created yet.

Comment 10

[Francis Lee [:frlee]]

hi Vincent,

any update for this issue? as i know, this issue should be fixed already. please correct me if necessary

Comment 11

[Vincent Liu[:vliu]]

(In reply to Francis Lee [:frlee] from comment #10)
> hi Vincent,
> 
> any update for this issue? as i know, this issue should be fixed already.
> please correct me if necessary

Yes, this bug has already fixed by some patches and work around. Some modifications are in the AOSP so it landed into bitbucket server. For the work around, partner will keep working on finding out the root cause.

Comment 12

[Vincent Liu[:vliu]]

Attachment: WIP.patch

Here to summarize some issues we'd met for this issue.

1. AAC recording was not support on JB 4.2.2 base. Bug 944567 was filed for this issue tracking.
2. mCameraHw->StoreMetaDataInBuffers(true) always returns UNKNOWN_ERROR.
   Action : Partner modified code in camera.flatfish.so to force to return NO_ERROR. They will land to bitbucket server.
3. Codec's Input buffer size was smaller than Source Buffer Size.
   Cause : Camera hardware read 1280X720 as its default resolution. It conflict the the resolution we set from Gecko.
   Action : Modify the resolution from camera.cfg to match to the same with Gecko.
4. Frame rate conflicted for front camera.
   Cause : Gecko read unsupported frame rate and indicated error recording.
   Action : Modified supported setting in camera.cfg
5. SampleDelta in the first stts table was was much larger than expected value.
   Cause 1 : The unit of timestamp Gecko and camera hardware looked different. The unit of timestamp camera hardware was 1000 times than it looked in Gecko.
   Action 1 : A work around modified in GonkCameraSource.cpp. Please see WIP.patch to know the detail.
              Currently it only happens in Flatfish platform. 

   Cause 2 : The first SampleDelta of stts table was much larger than expected value. 
   Action 2 : A work around modified in MPEG4Writer.cpp. Please see WIP.patch to know the detail.
              
   Actually the timestamp from camera hardware is quite larger than we saw from Nexus-4. As my point of view, it should be the root cause for item 5. After discussed with partner, they will keep working on it.

Comment 13

[Jason Smith [:jsmith]]

I'm unsure why this would be 1.3 blocker specifically, as I don't recall work happening for flatfish on any branch other than trunk. Renominating for more discussion.

Comment 14

[Jason Smith [:jsmith]]

See https://bugzilla.mozilla.org/show_bug.cgi?id=944594#c5.

Comment 15

[Diego Marcos [:dmarcos]]

I don't have a flatfish to test on. Is this still an issue we still care about?

Comment 16

[Jason Smith [:jsmith]]

Al is the better person to answer this.

Comment 17

[Al Tsai [:atsai]]

This shouldn't be a blocker for FxOS release, but we'd like to have it solved. According to Comment 12, some causes of the issue should be solved in partner side (POVB), we can only handle those problems can be solve in gecko.

Comment 18

[Sherman Chen [:chens] (inactive)]

Verified on master, video recording function works, but once stop recording camera app will crash.

Gaia      0a2c504ae8c6d37e21d04a3b832aba4928f3028d
Gecko     46c9b0371c8c4591e0e8bd5e889a8555e5e1e4ce
BuildID   20140731110216
Version   34.0a1
ro.build.version.incremental=20140725
ro.build.date=Fri Jul 25 01:46:09 CST 2014