937461 - Make cloneNode/importNode with the "deep" arg not passed default to shallow cloning

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Fallout from https://www.w3.org/Bugs/Public/show_bug.cgi?id=23565

I'll file a bunch of bugs blocking this one on getting people off the API we're about to break.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Make cloneNode/importNode "deep" arg default to false, since the spec changed on us.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Make cloneNode/importNode "deep" arg default to false, since the spec changed on us.

Ms2ger, note the imptests change

Comment 3

[Boris Zbarsky [:bzbarsky]]

https://tbpl.mozilla.org/?tree=Try&rev=229fca5abac5

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 8347836 [details] [diff] [review]
Make cloneNode/importNode "deep" arg default to false, since the spec changed on us.

Review of attachment 8347836 [details] [diff] [review]:
-----------------------------------------------------------------

https://github.com/w3c/web-platform-tests/pull/473

Comment 5

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c59accdc321a

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c59accdc321a

Comment 7

[Kohei Yoshino [:kohei]]

https://developer.mozilla.org/en-US/docs/Web/API/Node.cloneNode
https://developer.mozilla.org/en-US/docs/Web/API/document.importNode
https://developer.mozilla.org/en-US/Firefox/Releases/29/Site_Compatibility